From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id EF5E53835691 for ; Thu, 21 Jul 2022 21:02:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EF5E53835691 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-10d83692d5aso4133877fac.1 for ; Thu, 21 Jul 2022 14:02:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=brG7Irv2P1Wx0QxpZVAoBslFIsAeD/mPwFj4GRmOuig=; b=EQ/8CTNapTAaDISDnSE7CdhW6CpRNEwMb8KUdyWHFQuwu/b2/3pUbcxHoC/w5bPuoQ gxMChIuB362U1TSUDfBMsqBcu6Ql+SxPKkr8SOMTwXiTf5+0m83fZROieYCVfO+Qyvxa b0aVJcl5MJYZKvtJXOXUcIMWqQQS4CJ2VfiBsREFnjsDIIzAW/l85myORQeenu9et63o BWDjwotN78SH1yqqRt0D1kRe+4NP+T5qPgaMbj4ZSVBiWvtyOhk7xJBB1KywAHXJ/jgP UtvIykfL2pKUkalR5/whLDszVtNN+L37qYxYRkM8/A1YTdsBrfR/Wkhcw1lnIefa4xlf pYfQ== X-Gm-Message-State: AJIora/XiveVngrLh2hmzo/o2kkFPlIF1LVSrXjqRB6iHpHOGA9+5rK7 VV8xdQHvsi9s1IiljfSFbyRjBw== X-Google-Smtp-Source: AGRyM1t/U6HtegtqRlAYGHLS3StJz2p/Y0W04Z498HEzXElL0lIfkjQo5Mh9CkXTSQWg7rlYi+2Asg== X-Received: by 2002:a05:6870:a917:b0:10d:289:ccfa with SMTP id eq23-20020a056870a91700b0010d0289ccfamr6137158oab.48.1658437373212; Thu, 21 Jul 2022 14:02:53 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:8ded:90a7:7be2:9a21:5f25? ([2804:431:c7cb:8ded:90a7:7be2:9a21:5f25]) by smtp.gmail.com with ESMTPSA id t6-20020a056871054600b0010d645d9f1asm1370221oal.1.2022.07.21.14.02.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 14:02:51 -0700 (PDT) Message-ID: <7468525b-c81b-95e2-066e-e59ad701ad6a@linaro.org> Date: Thu, 21 Jul 2022 18:02:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v7 02/13] LoongArch: Add relocations and ELF flags to elf.h and scripts/glibcelf.py Content-Language: en-US To: caiyinyu , libc-alpha@sourceware.org, joseph_myers@mentor.com, carlos@redhat.com, i.swmail@xen0n.name References: <20220719012056.1461897-1-caiyinyu@loongson.cn> <20220719012056.1461897-3-caiyinyu@loongson.cn> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20220719012056.1461897-3-caiyinyu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 21:03:04 -0000 LGTM, as for v6. Reviewed-by: Adhemerval Zanella On 18/07/22 22:20, caiyinyu wrote: > --- > elf/elf.h | 68 ++++++++++++++++++++++++++++++++++++++++++++- > scripts/glibcelf.py | 3 +- > 2 files changed, 69 insertions(+), 2 deletions(-) > > diff --git a/elf/elf.h b/elf/elf.h > index 2b5c2c5fb6..02a1b3f52f 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -358,8 +358,9 @@ typedef struct > > #define EM_BPF 247 /* Linux BPF -- in-kernel virtual machine */ > #define EM_CSKY 252 /* C-SKY */ > +#define EM_LOONGARCH 258 /* LoongArch */ > > -#define EM_NUM 253 > +#define EM_NUM 259 > > /* Old spellings/synonyms. */ > > @@ -4083,6 +4084,71 @@ enum > #define R_NDS32_TLS_TPOFF 102 > #define R_NDS32_TLS_DESC 119 > > +/* LoongArch ELF Flags */ > +#define EF_LARCH_ABI 0x07 > +#define EF_LARCH_ABI_LP64D 0x03 > + > +/* LoongArch specific dynamic relocations */ > +#define R_LARCH_NONE 0 > +#define R_LARCH_32 1 > +#define R_LARCH_64 2 > +#define R_LARCH_RELATIVE 3 > +#define R_LARCH_COPY 4 > +#define R_LARCH_JUMP_SLOT 5 > +#define R_LARCH_TLS_DTPMOD32 6 > +#define R_LARCH_TLS_DTPMOD64 7 > +#define R_LARCH_TLS_DTPREL32 8 > +#define R_LARCH_TLS_DTPREL64 9 > +#define R_LARCH_TLS_TPREL32 10 > +#define R_LARCH_TLS_TPREL64 11 > +#define R_LARCH_IRELATIVE 12 > + > +/* Reserved for future relocs that the dynamic linker must understand. */ > + > +/* used by the static linker for relocating .text. */ > +#define R_LARCH_MARK_LA 20 > +#define R_LARCH_MARK_PCREL 21 > +#define R_LARCH_SOP_PUSH_PCREL 22 > +#define R_LARCH_SOP_PUSH_ABSOLUTE 23 > +#define R_LARCH_SOP_PUSH_DUP 24 > +#define R_LARCH_SOP_PUSH_GPREL 25 > +#define R_LARCH_SOP_PUSH_TLS_TPREL 26 > +#define R_LARCH_SOP_PUSH_TLS_GOT 27 > +#define R_LARCH_SOP_PUSH_TLS_GD 28 > +#define R_LARCH_SOP_PUSH_PLT_PCREL 29 > +#define R_LARCH_SOP_ASSERT 30 > +#define R_LARCH_SOP_NOT 31 > +#define R_LARCH_SOP_SUB 32 > +#define R_LARCH_SOP_SL 33 > +#define R_LARCH_SOP_SR 34 > +#define R_LARCH_SOP_ADD 35 > +#define R_LARCH_SOP_AND 36 > +#define R_LARCH_SOP_IF_ELSE 37 > +#define R_LARCH_SOP_POP_32_S_10_5 38 > +#define R_LARCH_SOP_POP_32_U_10_12 39 > +#define R_LARCH_SOP_POP_32_S_10_12 40 > +#define R_LARCH_SOP_POP_32_S_10_16 41 > +#define R_LARCH_SOP_POP_32_S_10_16_S2 42 > +#define R_LARCH_SOP_POP_32_S_5_20 43 > +#define R_LARCH_SOP_POP_32_S_0_5_10_16_S2 44 > +#define R_LARCH_SOP_POP_32_S_0_10_10_16_S2 45 > +#define R_LARCH_SOP_POP_32_U 46 > + > +/* used by the static linker for relocating non .text. */ > +#define R_LARCH_ADD8 47 > +#define R_LARCH_ADD16 48 > +#define R_LARCH_ADD24 49 > +#define R_LARCH_ADD32 50 > +#define R_LARCH_ADD64 51 > +#define R_LARCH_SUB8 52 > +#define R_LARCH_SUB16 53 > +#define R_LARCH_SUB24 54 > +#define R_LARCH_SUB32 55 > +#define R_LARCH_SUB64 56 > +#define R_LARCH_GNU_VTINHERIT 57 > +#define R_LARCH_GNU_VTENTRY 58 > + > + > /* ARCompact/ARCv2 specific relocs. */ > #define R_ARC_NONE 0x0 > #define R_ARC_8 0x1 > diff --git a/scripts/glibcelf.py b/scripts/glibcelf.py > index 47f95d07ba..de0509130e 100644 > --- a/scripts/glibcelf.py > +++ b/scripts/glibcelf.py > @@ -252,7 +252,8 @@ class Machine(_OpenIntEnum): > EM_RISCV = 243 > EM_BPF = 247 > EM_CSKY = 252 > - EM_NUM = 253 > + EM_LOONGARCH = 258 > + EM_NUM = 259 > EM_ALPHA = 0x9026 > > class Et(_OpenIntEnum):