From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 13/13] string: Add errname_np and errdesc_np
Date: Tue, 2 Jun 2020 14:20:57 -0300 [thread overview]
Message-ID: <74694cc4-5225-33b1-c82c-47fc8944db5d@linaro.org> (raw)
In-Reply-To: <87zh9lz8pc.fsf@oldenburg2.str.redhat.com>
On 02/06/2020 14:19, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> I have removed the constant length variable, however for the extra relocations
>
> Thanks.
>
>> from the string array I am not sure if this is really an
>> improvement. The array is exported as compat symbol (we can't skip its
>> definition) and to fully optimize it would require to use a different
>> data structure (such as string containing all definitions plus a array
>> of indexes) which would require to duplicate some definition (at least
>> the extra index map).
>>
>> It might be a gain for architectures that does not have to provide the
>> compat symbols, but it increases memory usage a bit for the default
>> case (without much gain in relocation time spent).
>
> Sure, for the description arrays. But aren't the name arrays new?
Indeed, I think we can optimize it. I will send a new version.
prev parent reply other threads:[~2020-06-02 17:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 18:05 [PATCH 00/13] Signal and error list refactoring Adhemerval Zanella
2020-05-19 18:05 ` [PATCH v2 01/13] signal: Add signum-{generic,arch}.h Adhemerval Zanella
2020-05-19 18:05 ` [PATCH v3 02/13] signal: Move sys_siglist to a compat symbol Adhemerval Zanella
2020-05-28 14:50 ` Florian Weimer
2020-05-19 18:05 ` [PATCH v3 03/13] signal: Move sys_errlist " Adhemerval Zanella
2020-05-19 18:05 ` [PATCH 04/13] linux: Fix __NSIG_WORDS and add __NSIG_BYTES Adhemerval Zanella
2020-05-19 18:05 ` [PATCH 05/13] string: Remove old TLS usage on strsignal Adhemerval Zanella
2020-05-28 11:38 ` Florian Weimer
2020-06-01 18:08 ` Adhemerval Zanella
2020-06-01 18:13 ` Florian Weimer
2020-06-01 18:39 ` Adhemerval Zanella
2020-06-01 18:43 ` Florian Weimer
2020-05-19 18:05 ` [PATCH 06/13] string: Implement strerror in terms of strerror_l Adhemerval Zanella
2020-05-28 11:41 ` Florian Weimer
2020-06-01 18:28 ` Adhemerval Zanella
2020-06-03 8:24 ` Florian Weimer
2020-06-03 15:13 ` Adhemerval Zanella
2020-05-19 18:05 ` [PATCH 07/13] string: Use tls-internal on strerror_l Adhemerval Zanella
2020-05-19 18:05 ` [PATCH 08/13] string: Simplify strerror_r Adhemerval Zanella
2020-05-28 11:56 ` Florian Weimer
2020-06-01 18:31 ` Adhemerval Zanella
2020-05-19 18:05 ` [PATCH 09/13] string: Add strsignal test Adhemerval Zanella
2020-05-19 18:05 ` [PATCH 10/13] string: Add strerror, strerror_r, and strerror_l test Adhemerval Zanella
2020-05-19 18:05 ` [PATCH 11/13] string: Add strerror_l on test-strerror-errno Adhemerval Zanella
2020-05-19 18:05 ` [PATCH 12/13] string: Add sigabbrev_np and sigdescr_np Adhemerval Zanella
2020-05-19 18:47 ` Joseph Myers
2020-05-28 12:31 ` Florian Weimer
2020-06-03 16:39 ` Adhemerval Zanella
2020-05-19 18:05 ` [PATCH 13/13] string: Add errname_np and errdesc_np Adhemerval Zanella
2020-05-28 12:28 ` Florian Weimer
2020-06-01 20:52 ` Adhemerval Zanella
2020-06-02 17:13 ` Adhemerval Zanella
2020-06-02 17:19 ` Florian Weimer
2020-06-02 17:20 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74694cc4-5225-33b1-c82c-47fc8944db5d@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).