From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by sourceware.org (Postfix) with ESMTPS id 0C754386F46F for ; Fri, 25 Sep 2020 09:25:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0C754386F46F Received: by mail-ed1-x543.google.com with SMTP id ay8so1767235edb.8 for ; Fri, 25 Sep 2020 02:25:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mxFQyeir7zr6BsWbm53XWvF2+3gLoOp02DmsGeVKfmQ=; b=tCx5Vr6YpeHW4cfP8VJqSyE7/y8ZKuAOmllJiXTyjBDeMwdWnFkY3V3ZRdMfK5mCES eOKaet/xrkSHgs/3SRUhWyKIJfjEoJMgvMRMb3sHe28r3NffbtlqBiDxmz9aHUA/t/b/ Y3ZVJLzTfwbEpiKRg0x53l+zNXGVUCeMqv/HB2f1IOB5OmNtgnIBhNPpjJLMYgN6z71c 35+dxSLiQ7cQDOZEv2DbPpjKJ0Mvbrpx8nI1hQsqD3ELBBZ0ZD/yYGpFsp2Jz2h5WNgI cwrpTNHSpLZrSntQBf3qsGSwWguP3aOmue7AcfiNnMLmfYw59u3eaBKGqzm9PMRKflG5 QdjA== X-Gm-Message-State: AOAM531EtxomS2TSH6bQOqyOT0lSGpDIXttRfZjcI8l/UpWdaVPFzD/y l5Dggo6Jiq1i4h1OC/sParbiacLqD8c= X-Google-Smtp-Source: ABdhPJxLlzSey1toGcDz4Geq5dQqSXqyMhHUzxbuE1JyaA95JOqmqYAtRY7aX9DW4n6wDNwpdyGdTw== X-Received: by 2002:a05:6402:18d:: with SMTP id r13mr241436edv.267.1601025937889; Fri, 25 Sep 2020 02:25:37 -0700 (PDT) Received: from ?IPv6:2001:a61:2479:6801:d8fe:4132:9f23:7e8f? ([2001:a61:2479:6801:d8fe:4132:9f23:7e8f]) by smtp.gmail.com with ESMTPSA id j18sm1476456edj.62.2020.09.25.02.25.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 02:25:37 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH 09/10] seccomp.2: Use ARRAY_SIZE() macro instead of raw sizeof division To: Alejandro Colomar References: <20200925073140.173394-1-colomar.6.4.3@gmail.com> <20200925073140.173394-10-colomar.6.4.3@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: <7473976b-1fce-41fe-1af4-8b8f09a6b6f1@gmail.com> Date: Fri, 25 Sep 2020 11:25:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200925073140.173394-10-colomar.6.4.3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2020 09:25:40 -0000 On 9/25/20 9:31 AM, Alejandro Colomar wrote: > Signed-off-by: Alejandro Colomar Thanks, Alex. Patch applied. Cheers, Michael > --- > man2/seccomp.2 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/man2/seccomp.2 b/man2/seccomp.2 > index d6b856c32..82eb04dc6 100644 > --- a/man2/seccomp.2 > +++ b/man2/seccomp.2 > @@ -1051,6 +1051,7 @@ cecilia > #include > > #define X32_SYSCALL_BIT 0x40000000 > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0])) > > static int > install_filter(int syscall_nr, int t_arch, int f_errno) > @@ -1101,7 +1102,7 @@ install_filter(int syscall_nr, int t_arch, int f_errno) > }; > > struct sock_fprog prog = { > - .len = sizeof(filter) / sizeof(filter[0]), > + .len = ARRAY_SIZE(filter), > .filter = filter, > }; > > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/