From: Carlos O'Donell <carlos@redhat.com>
To: Alexey Makhalov <amakhalov@vmware.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix range check in do_tunable_update_val
Date: Thu, 20 Jul 2017 01:43:00 -0000 [thread overview]
Message-ID: <74d900e2-9405-5aed-f933-bd3383d0e00a@redhat.com> (raw)
In-Reply-To: <20170719213438.24573-1-amakhalov@vmware.com>
On 07/19/2017 05:34 PM, Alexey Makhalov wrote:
> Current implementation of tunables does not set arena_max and arena_test
> values. Any value provided by glibc.malloc.arena_max and
> glibc.malloc.arena_test parameters is ignored.
>
> These tunables have minval value set to 1 (see elf/dl-tunables.list file)
> and undefined maxval value. In that case default value (which is 0. see
> scripts/gen-tunables.awk) is being used to set maxval.
Alexey,
Thank you very much for continuing your contributions!
Your patch has ~10-14 lines of legally significant changes.
Given that VMWare has already contributed ~6 legally significant lines of
code with the pthread_create swbz#20116 changes that we worked on together,
this means we need to continue our discussions about copyright assignment
before we can continue to accept any further patches.
As a reminder, please review the contribution checklist:
https://sourceware.org/glibc/wiki/Contribution%20checklist
--
Cheers,
Carlos.
next prev parent reply other threads:[~2017-07-20 1:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 21:34 Alexey Makhalov
2017-07-20 1:43 ` Carlos O'Donell [this message]
2017-09-26 18:38 Alexey Makhalov
2017-09-26 18:54 ` Siddhesh Poyarekar
2017-09-26 20:07 ` Carlos O'Donell
2017-09-26 21:17 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74d900e2-9405-5aed-f933-bd3383d0e00a@redhat.com \
--to=carlos@redhat.com \
--cc=amakhalov@vmware.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).