From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s01.bc.larksuite.com (s01.bc.larksuite.com [209.127.230.18]) by sourceware.org (Postfix) with UTF8SMTPS id 0C2EE3855599 for ; Tue, 16 May 2023 09:12:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C2EE3855599 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oss.cipunited.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=oss-cipunited-com.20200927.dkim.feishu.cn; t=1684228363; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=6cTsY6J/ArDqZ+Hd4AkWF72a15t8m4jl6EnxEsccUrI=; b=jynhHjwQfDxfKqM39ro/K/60ks/UjS4cVGU+XL+ELtpTCI3ifO7u4bS6lq9dLg942ZFnxn VKJ2WsUZ33tc/2auAD76cL9JpJ6cZzgZZiRn0Ywj+Sd6efKm1HtG1J1/qy5sge2mZF2ohF FVBzw85XywTQZNG8L1Jc6KBEtenMo/f/sFJQqvoM9zQauz8NSjrP5I8vyEA1dKq99JxqOf 0LO1XqCEW5I66kzJF5oeZKl8bclLQHD5XyvRcHzV3xpMCpsBOnY/GxAfP7l5gaIHj2tRge lwMmU4Rw+u9enHcpPnCnbKOpmoLMegqBF5SkiZEvVS9LgU+rGD147UQS/raoUA== From: "Ying Huang" Mime-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Date: Tue, 16 May 2023 17:12:31 +0800 Content-Type: multipart/alternative; boundary=18af6907ecc3fa4ea8e54acfda107099caa4b3b78a5737dbd8bcbf3e7639 X-Lms-Return-Path: Content-Language: en-US To: , Subject: Re:[PATCH v2] MIPS: Sync elf.h from binutils Message-Id: <7518d9d2-138b-d58b-6d95-ef5250093bab@oss.cipunited.com> Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FAKE_REPLY_A1,HTML_MESSAGE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --18af6907ecc3fa4ea8e54acfda107099caa4b3b78a5737dbd8bcbf3e7639 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 HI, > >/+#define EF_MIPS_MACH 0x00FF0000 /* Machine variant if we know it. This= field was invented at Cygnus, />/+ but it is hoped that other vendors will= adopt it. If some standard />/+ is developed, this code should be changed = to follow it. */ />/+#define E_MIPS_MACH_3900 0x00810000 /* Cygnus is choos= ing values between 80 and 9F; />/+ 00 - 7F should be left for a future stan= dard; />/+ the rest are open. */ / > Surely after around 25 years, these comments can be more precise? =C2=A0=C2=A0=C2=A0 OK, I would delete the comments. > > >/+/* Object attribute tags. */ />/+enum />/+{ />/+ /* 0-3 are generic. *= / />/+ />/+ /* Floating-point ABI used by this object file. */ />/+ Tag_GNU= _MIPS_ABI_FP =3D 4, />/+ />/+ /* MSA ABI used by this object file. */ />/+ = Tag_GNU_MIPS_ABI_MSA =3D 8, />/+}; />/+ />/+/* Object attribute values. */ = />/+enum />/+{ />/+ /* Values defined for Tag_GNU_MIPS_ABI_MSA. */ />/+ />/= + /* Not tagged or not using any ABIs affected by the differences. */ />/+ = Val_GNU_MIPS_ABI_MSA_ANY =3D 0, />/+ />/+ /* Using 128-bit MSA. */ />/+ Val= _GNU_MIPS_ABI_MSA_128 =3D 1, />/+}; / > Any reason for using enum constants here, and not #define? I understand > there is other MIPS precedent, but why continue in this direction? > > Thanks, > =C2=A0=C2=A0=C2=A0 OK, I would change it to #define && submit PATCH v3. =C2=A0=C2=A0=C2=A0 Thanks, =C2=A0=C2=A0=C2=A0 Ying= --18af6907ecc3fa4ea8e54acfda107099caa4b3b78a5737dbd8bcbf3e7639--