Re: [PATCH] have ifunc resolver's return type match target

[Martin Sebor <msebor@gmail.com>]

On 08/23/2017 03:28 AM, Florian Weimer wrote:
> On 08/21/2017 12:30 AM, Martin Sebor wrote:
>> The following GCC patch has been submitted for review.  It
>> helps detect mismatches between the type of an ifunc or alias
>> declaration and the type of the resolver or alias.
>>
>>   https://gcc.gnu.org/ml/gcc-patches/2017-08/msg01103.html
>>
>> To let Glibc take advantage of this type checking and avoid
>> warnings when using the patched GCC when the change above is
>> committed, the patch below adjusts the Glibc __ifunc_resolver
>> macro to declare the ifunc resolver so that its return type
>> matches that of the target.  (I was going to wait to submit it
>> until after the GCC patch has been accepted but per Joseph's
>> suggestion I'm posting it here ahead of time.)
>
> Do we have to backport both patches to older releases, too, so that they
> keep building with a newer GCC?

It would make sense to me if that's how Glibc usually deals with
these sorts of things (i.e., changing code to avoid new warnings).
The other (obvious) alternative is for people to suppress the
warnings when using the new compiler.

Martin