From: Florian Weimer <fweimer@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Albert ARIBAUD <albert.aribaud@3adev.fr>, libc-alpha@sourceware.org
Subject: Re: [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time
Date: Mon, 18 Jun 2018 13:34:00 -0000 [thread overview]
Message-ID: <76091890-f279-e399-3124-97c663e64a41@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1806131422560.28522@digraph.polyomino.org.uk>
On 06/13/2018 04:24 PM, Joseph Myers wrote:
> On Wed, 13 Jun 2018, Florian Weimer wrote:
>
>>> They're going to be implementations of APIs called from user source code
>>> if/when it defines _TIME_BITS equal to 64 (that'll be the last patch in
>>> the whole series), so I don't understand how they could be considered
>>> GLIBC_PRIVATE.
>>
>> Why do they use the __ prefix? We generally do not do that.
>
> Because we want to fix bug 14106, and not replicate it for new interfaces
> (and don't intend to have explicit *64 APIs at all for 64-bit time_t, just
> new ABIs, on platforms where time_t is currently 32-bit, which can be
> selected using _TIME_BITS=64).
Ohh, right.
On the other hand, it is quite awkward why these obscure interfaces
receive protection from accidental interposition, when others where we
know that there is ongoing interposition (fadd, fdiv, canonicalize,
explicit_bzero, getrandom, even getline) do not.
This relates to an older thread:
<https://sourceware.org/ml/libc-alpha/2016-10/msg00294.html>
It also affects _GNU_SOURCE avoidance for libstdc++, depending on how we
view this. (Formal compliance vs avoiding collisions which occur in
practice.)
Thanks,
Florian
next prev parent reply other threads:[~2018-06-18 13:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 7:00 [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD (3ADEV)
2018-06-13 7:00 ` [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time Albert ARIBAUD (3ADEV)
2018-06-13 9:10 ` Florian Weimer
2018-06-13 9:37 ` Albert ARIBAUD
2018-06-13 9:40 ` Florian Weimer
2018-06-13 10:21 ` Albert ARIBAUD
2018-06-13 10:55 ` Albert ARIBAUD
2018-06-13 13:08 ` Florian Weimer
2018-06-13 14:29 ` Joseph Myers
2018-06-13 14:24 ` Joseph Myers
2018-06-18 13:34 ` Florian Weimer [this message]
2018-06-13 9:11 ` Paul Eggert
2018-06-13 9:14 ` Florian Weimer
2018-06-13 9:30 ` Albert ARIBAUD
2018-06-13 14:22 ` Joseph Myers
2018-06-13 14:18 ` Joseph Myers
2018-06-13 7:00 ` [PATCH 1/2] Y2038: add type __time64_t Albert ARIBAUD (3ADEV)
2018-06-13 8:38 ` Paul Eggert
2018-06-13 12:36 ` Albert ARIBAUD
2018-06-13 14:13 ` Joseph Myers
2018-06-13 16:19 ` Albert ARIBAUD
2018-06-13 16:35 ` Paul Eggert
2018-06-13 16:39 ` Joseph Myers
2018-06-13 18:46 ` Paul Eggert
2018-06-13 7:59 ` [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD
2018-06-13 14:08 ` Joseph Myers
2018-06-13 15:38 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76091890-f279-e399-3124-97c663e64a41@redhat.com \
--to=fweimer@redhat.com \
--cc=albert.aribaud@3adev.fr \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).