From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: "H.J. Lu" <hjl.tools@gmail.com>,
Joseph Myers <joseph@codesourcery.com>,
Thomas Schwinge <thomas@codesourcery.com>,
bug-hurd@gnu.org, GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Hurd: Add rtld-strncpy-c.c
Date: Tue, 19 Jan 2021 09:25:57 -0300 [thread overview]
Message-ID: <76eb0ae0-ea82-a5ff-09ea-fe3f4d8e1a7c@linaro.org> (raw)
In-Reply-To: <CAMe9rOogxZeLBbcxoxbveE--WB9K4oyvR7nD_XxdA1rzukWROg@mail.gmail.com>
On 19/01/2021 09:21, H.J. Lu via Libc-alpha wrote:
> On Tue, Jan 19, 2021 at 1:02 AM Samuel Thibault <samuel.thibault@gnu.org> wrote:
>>
>> H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit:
>>> On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>
>>>> On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
>>>>>
>>>>> Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit:
>>>>>> H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit:
>>>>>>> Why doesn't hurd ld.so build script mark strncpy as needed?
>>>>>>
>>>>>> I don't even know what "hurd ld.so build script" is.
>>>>>
>>>>> More precisely, I don't see why hurd should be doing anything special
>>>>> while everything is already taken care of by elf/Makefile's librtld.map
>>>>> file scripts.
>>>>
>>>> I am taking a look.
>>>
>>> Try this. I have no idea if it really works on hurd.
>>
>> It is working indeed.
>>
>> Samuel
>
> Should I check it in?
>
>
Yes please, the loader should not use ifunc on its own string usage and
it is a build issue.
next prev parent reply other threads:[~2021-01-19 12:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201108225251.3195591-1-samuel.thibault@ens-lyon.org>
[not found] ` <87h7nl1425.fsf@dem-tschwing-1.ger.mentorg.com>
2021-01-18 20:05 ` [PATCH] Hurd: Enable ifunc by default Joseph Myers
2021-01-18 20:25 ` Samuel Thibault
2021-01-19 0:04 ` Samuel Thibault
2021-01-19 0:17 ` H.J. Lu
2021-01-19 0:21 ` Samuel Thibault
2021-01-19 0:24 ` Samuel Thibault
2021-01-19 0:40 ` H.J. Lu
2021-01-19 2:24 ` [PATCH] Hurd: Add rtld-strncpy-c.c H.J. Lu
2021-01-19 9:02 ` Samuel Thibault
2021-01-19 12:21 ` H.J. Lu
2021-01-19 12:25 ` Adhemerval Zanella [this message]
2021-01-19 12:35 ` H.J. Lu
2021-01-19 12:44 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76eb0ae0-ea82-a5ff-09ea-fe3f4d8e1a7c@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=bug-hurd@gnu.org \
--cc=hjl.tools@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).