From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-89280-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 98674 invoked by alias); 17 Jan 2018 21:47:55 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 98661 invoked by uid 89); 17 Jan 2018 21:47:54 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=age, HContent-Transfer-Encoding:8bit
X-HELO: mail-qt0-f178.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:cc:references:from:organization
         :message-id:date:user-agent:mime-version:in-reply-to
         :content-language:content-transfer-encoding;
        bh=kDSwZIQPsgHoT3vDUxHN7lMTskL+nmafsYCHkSF18Ck=;
        b=mfyMGjXPQKlQx+AmH1pA3f6X2Enu6pDSL9agRqcTxq0+PinbmFQ35wekOsPWubaopT
         76rkTjOkUhYzF4JC2vpJamWe3kNuhqexCiSeNW6uH7Ix3hZe/mS++af34/OMLVL2rfJu
         lLbXdsyRiumMvikqU/iRdzXVfgAHcF4hmeU+BGC7Ge3vjF9xtpKUv7FFv318WiqpS8hf
         fCMgH5z1FM6i8tmTuIq+lhckKi/vGlkejYHVtloqvSy7oDvf6PikhGfvRGzVW6QSeHlT
         xenfMz9yg4+Ke1PhZYl3GN0cAgXB4uOiSWhOehS7c4/jWXOPW3td25smZaMBruvopIuu
         LlJw==
X-Gm-Message-State: AKwxytewWEn7x9E7ey5Fi5Wl8G/1sk/b493SXivJLUBVLu+U/zdthtnb
	Thl1bY+g6kZw8FNPcEoYm6G5gg==
X-Google-Smtp-Source: ACJfBotgFsBBEUVb92+6a5jwGmRCAdIR8DvNzse12DsO23Hlb+vZ8bCPAmsqPw59Ww+HtWI3BVjRfg==
X-Received: by 10.237.60.145 with SMTP id d17mr38630339qtf.319.1516225671583;
        Wed, 17 Jan 2018 13:47:51 -0800 (PST)
Subject: Re: [PATCH] Fix integer overflows in internal memalign and malloc
 functions [BZ #22343]
To: Florian Weimer <fweimer@redhat.com>, Arjun Shankar <arjun.is@lostca.se>,
 libc-alpha@sourceware.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
References: <20180117202641.GA58783@aloka.lostca.se>
 <eb6b17ee-6101-74d0-dc57-e0df6ba81c89@redhat.com>
From: Carlos O'Donell <carlos@redhat.com>
Message-ID: <76f34184-8e48-0aac-cc68-9265c4352148@redhat.com>
Date: Wed, 17 Jan 2018 21:47:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <eb6b17ee-6101-74d0-dc57-e0df6ba81c89@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2018-01/txt/msg00584.txt.bz2

On 01/17/2018 12:52 PM, Florian Weimer wrote:
> On 01/17/2018 09:26 PM, Arjun Shankar wrote:
>> +#define TIMEOUT 5
> 
> The default timeout is 20 seconds (scaled by the timeout factor), so this reduces the timeout to one fourth of the default value.  I think you should remove this.
> 
> (I haven't looked at the other parts of the patch.)

support/test-driver.h:    DEFAULT_TIMEOUT = 20,
 
You are absolutely right, I thought the default was 2 seconds, but
that's just my age showing... the old test-skeleton.c had a 2 second
timeout. That has changed to 20 seconds with the new support framework.

-- 
Cheers,
Carlos.