From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 1A0023857818 for ; Sun, 11 Apr 2021 19:23:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1A0023857818 Received: by mail-wr1-x435.google.com with SMTP id p6so3985775wrn.9 for ; Sun, 11 Apr 2021 12:23:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZY4SwBgi/tjHyUGLDPGpwuTBPJvHgwyp9ogpnox3Hzc=; b=XQN1DDtFG0QR9EnrkuzEqgDOG/SbL0c+kRr0ivAny6WcxgGcfGvA6Y8H/IS4xebHop b8WtWhPdkKRYWpisPudqyFF0jaVtOinXB0/zIyZe/jqLkK1wLPaQMN/ydyDAEpdlPdu8 LYFXka+9K97x2n6BjFI2KrnrE5kSM65umHEZLchp9tMN0/tk8INep19gY5yCEk4t67dO xYBh5E/SrwsLyjoY8KUGXGUP5zFe3jHFk/pyCNn0LgtfyLt7Z846FArkNaiwelD2zcyj oYT9WBWLnj8afw6RWmkWIngjHQoSjfFboYGIaLI0nITiO8pa4CB0Rhr5eU3PgmVjPZPx /x9g== X-Gm-Message-State: AOAM532xYGBMCzDnu+0/p8XC7SSQgCA91WCmhY6nwTyYmik/0npzR3wo quaKc4OqFANR7SnGPVHxIHqu+Bp8a/M= X-Google-Smtp-Source: ABdhPJyFzCsHqT412jB2INJbo2VyzOwPfps3RSvMCWtjF1EYHtXVWpcKrWIY4E87dhyqY/Yqz41mbA== X-Received: by 2002:a5d:650d:: with SMTP id x13mr15021687wru.264.1618168999321; Sun, 11 Apr 2021 12:23:19 -0700 (PDT) Received: from [192.168.1.143] ([170.253.51.130]) by smtp.gmail.com with ESMTPSA id m25sm12128818wmi.33.2021.04.11.12.23.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Apr 2021 12:23:18 -0700 (PDT) Subject: Re: [PATCH v5 00/35] SYNOPSIS: Use syscall(SYS_...); and fix '#include's To: "Michael Kerrisk (man-pages)" Cc: linux-man@vger.kernel.org, libc-alpha@sourceware.org References: <20210403194026.102818-1-alx.manpages@gmail.com> <20210404115847.78166-1-alx.manpages@gmail.com> <4298cc3c-8f24-5a3c-3c54-b24ca804d373@gmail.com> From: "Alejandro Colomar (man-pages)" Message-ID: <7750fa83-c252-7a60-bddc-34fb7ebed0bf@gmail.com> Date: Sun, 11 Apr 2021 21:23:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <4298cc3c-8f24-5a3c-3c54-b24ca804d373@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Apr 2021 19:23:21 -0000 Hi Michael, On 4/5/21 1:49 PM, Michael Kerrisk (man-pages) wrote: > So, I think I'm okay with the syscall() changes in the SYNOPSIS. > It might just take me a moment to get used to them. However, I do > wonder if it is worth retaining a comment in the SYSNOPSIS, > something like: > > SYNOPSIS > #include /* Definition of ARCH_* constants */ > #include /* Definition of SYS_* constants */ > #include > > int syscall(SYS_arch_prctl, int code, unsigned long addr); > int syscall(SYS_arch_prctl, int code, unsigned long *addr); > > Note: glibc provides no wrapper for arch_prctl(), necessitating > the use of syscall(2). > > Without something like this, the reader may be puzzled at the use of > syscall(). > > What do you think? Yes. I had doubts, and you confirmed them. I'll add that. Thanks, Alex -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/