From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 1DB8F3858C54 for ; Tue, 4 Apr 2023 13:44:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DB8F3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x331.google.com with SMTP id x8-20020a9d3788000000b0069f922cd5ceso17348002otb.12 for ; Tue, 04 Apr 2023 06:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680615864; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NvMY3961+5Y3tbPowL7zhz+XQqFQPtsmOkAxipYGTS4=; b=kRrLeYd1rR2YEhcFATQ1SiXmbSZLwTmTC7J2vjc63T0Op5ney+Gr5PM9obAka0PaIp 5WN4qGsn0R/+8ITJTyGxb/9zAe0qikSWxp9Al7ywVacbOa0YOpDgrEJ3SS5QTTIsknKI Nw4GlZOvp6bVYKC3lAZzG5SGiYDl6SeAHjlRaQUMG7Bssm8Z4C3UOYN+Un9ycipOcgUy 639jEJbQWeDp7MDY+ZC7gVXHGAl3bPphgmkW1gvziuLoMYEQZpDByM7HQ86X1Mv9B21R gpxLn8cHPSOgAw4D291/By7yJJhbGGfV4ZT1lxglXgxa6n0qLM3gzm+t8+tlUs23tXKL G7NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680615864; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NvMY3961+5Y3tbPowL7zhz+XQqFQPtsmOkAxipYGTS4=; b=yEvOy/HtbFNMOzj74a9LY4LMYCHAZJ9AdCbcbNxMR3WFqh5t1S27872Mlx13eerYS+ XJBqWHJwZGi20LPhYsp+3oAee5pFH71xLfKUeQxsZJs/ZZEBI+8Lozjmi20bvL1F0VCz 1mHLg7wd2MmZd7tPzGmXImrYt5lbvhBeGPTRCG1t8mKyNtZwsY4kuNzQ7OS6ozbns66v 9bgyjMibyMyPh7FfKwlasd08hsKiOKtuxCmdRJOcM197B6eWXj3oUXNgxxQvWNnrqvMw TKgTMusXlvq4/uOlbMJgBPwkB/V6ONIhru8JJO3OLu820PbrLXGPHUKYsmRdvLHDWYJC 0aLw== X-Gm-Message-State: AAQBX9eYO/b3vmOZhixjOedshFwEDzmglK8zwkenoa0Pf7JwXGzOqi8W gknHIdlF4HwvnRIJhKJsXbZ8N5N29ndxLi0lEHpHEA== X-Google-Smtp-Source: AKy350YnAcIFlcvjet1FOWGwJwAGZkwEeM39MA7RVwB2fydhYkqgMXvAczk0VyNLdKq230WteL9H4g== X-Received: by 2002:a9d:4586:0:b0:69f:96a3:8bdc with SMTP id x6-20020a9d4586000000b0069f96a38bdcmr10884475ote.3.1680615864227; Tue, 04 Apr 2023 06:44:24 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:e5a5:d98f:a7e2:1bb3:d0a7? ([2804:1b3:a7c1:e5a5:d98f:a7e2:1bb3:d0a7]) by smtp.gmail.com with ESMTPSA id p11-20020a9d694b000000b006a113d75b90sm5514221oto.68.2023.04.04.06.44.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:44:23 -0700 (PDT) Message-ID: <78253195-7362-156f-9ac9-507f1bbda848@linaro.org> Date: Tue, 4 Apr 2023 10:44:21 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 1/2] strdup: Add tests (BZ #30266) Content-Language: en-US To: Joe Simmons-Talbott , libc-alpha@sourceware.org References: <20230329150500.2886135-1-josimmon@redhat.com> <20230330145008.3035194-1-josimmon@redhat.com> <20230330145008.3035194-2-josimmon@redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230330145008.3035194-2-josimmon@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30/03/23 11:50, Joe Simmons-Talbott via Libc-alpha wrote: > Copy strcpy tests for strdup. Covers some basic testcases with random > strings. Add a zero-length string testcase. > > Signed-off-by: Joe Simmons-Talbott > --- > string/Makefile | 1 + > string/test-strdup.c | 241 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 242 insertions(+) > create mode 100644 string/test-strdup.c > > diff --git a/string/Makefile b/string/Makefile > index c84b49aaa5..472e318aea 100644 > --- a/string/Makefile > +++ b/string/Makefile > @@ -157,6 +157,7 @@ tests := \ > test-strcmp \ > test-strcpy \ > test-strcspn \ > + test-strdup \ > test-strlen \ > test-strncasecmp \ > test-strncat \ > diff --git a/string/test-strdup.c b/string/test-strdup.c > new file mode 100644 > index 0000000000..04eedafc24 > --- /dev/null > +++ b/string/test-strdup.c > @@ -0,0 +1,241 @@ > +/* Test and measure strdup functions. > + Copyright (C) 2023 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + // Spurious '//'. > +#include > + > +#ifdef WIDE > +# include > +# define CHAR wchar_t > +# define UCHAR wchar_t > +# define sfmt "ls" > +# define BIG_CHAR WCHAR_MAX > +# define SMALL_CHAR 1273 > +# define STRCMP wcscmp > +# define MEMCMP wmemcmp > +# define MEMSET wmemset > +#else > +# define CHAR char > +# define UCHAR unsigned char > +# define sfmt "s" > +# define BIG_CHAR CHAR_MAX > +# define SMALL_CHAR 127 > +# define STRCMP strcmp > +# define MEMCMP memcmp > +# define MEMSET memset > +#endif > + > +#ifndef STRDUP_RESULT > +# define STRDUP_RESULT(dst, len) dst > +# define TEST_MAIN > +# ifndef WIDE > +# define TEST_NAME "strdup" > +# else > +# define TEST_NAME "wcsdup" > +# endif > +# include "test-string.h" > +# ifndef WIDE > +# define STRDUP strdup > +# else > +# define STRDUP wcsdup > +# endif > + > +IMPL (STRDUP, 1) There is no need to use IMPL here, no architecture provides strdup ifunc variants. > + > +/* Also check the generic implementation. */ > +#undef STRDUP > +#undef libc_hidden_builtin_def > +#define libc_hidden_builtin_def(a) > +#undef libc_hidden_def > +#define libc_hidden_def(a) > +#undef weak_alias > +#define weak_alias(a,b) > +#undef attribute_hidden > +#define attribute_hidden > +#endif This is also not required (it is essentially dead definitions). > + > +typedef CHAR *(*proto_t) (const CHAR *); > + > +static void > +do_zero_len_test (void) > +{ > + char src[1] = { '\0' }; > + char *dst = strdup (src); > + > + TEST_COMPARE_STRING (dst, src); Since you are testing the interface, also call free here (and it avoid leak reports on memory profiling tools). > +} > + > +static void > +do_one_test (const CHAR *src, > + size_t len __attribute__((unused))) > +{ > + char *dst = strdup (src); > + > + if (STRCMP (dst, src) != 0) > + { > + error (0, 0, > + "Wrong result in function strdup dst \"%" sfmt "\" src \"%" sfmt "\"", > + dst, src); > + ret = 1; > + return; > + } > +} > + > +static void > +do_test (size_t align1, size_t align2, size_t len, int max_char) > +{ > + size_t i; > + CHAR *s1; > +/* For wcsdup: align1 and align2 here mean alignment not in bytes, > + but in wchar_ts, in bytes it will equal to align * (sizeof (wchar_t)) > + len for wcschr here isn't in bytes but it's number of wchar_t symbols. */ > + align1 &= 7; > + if ((align1 + len) * sizeof (CHAR) >= page_size) > + return; > + > + align2 &= 7; > + if ((align2 + len) * sizeof (CHAR) >= page_size) > + return; > + > + s1 = (CHAR *) (buf1) + align1; > + > + for (i = 0; i < len; i++) > + s1[i] = 32 + 23 * i % (max_char - 32); > + s1[len] = 0; > + > + do_one_test (s1, len); > +} > + > +static void > +do_random_tests (void) > +{ > + size_t i, j, n, align1, align2, len; > + UCHAR *p1 = (UCHAR *) (buf1 + page_size) - 512; > + UCHAR *p2 = (UCHAR *) (buf2 + page_size) - 512; This variable is not required (see below). > + UCHAR *res; > + > + for (n = 0; n < ITERATIONS; n++) > + { > + /* align1 and align2 are expressed as wchar_t and not in bytes for wide > + char test, and thus it will be equal to align times wchar_t size. > + > + For non wide version we need to check all alignments from 0 to 63 > + since some assembly implementations have separate prolog for alignments > + more 48. */ > + > + align1 = random () & (63 / sizeof (CHAR)); > + if (random () & 1) > + align2 = random () & (63 / sizeof (CHAR)); > + else > + align2 = align1 + (random () & 24); > + len = random () & 511; > + j = align1; > + if (align2 > j) > + j = align2; > + if (len + j >= 511) > + len = 510 - j - (random () & 7); > + j = len + align1 + 64; > + if (j > 512) > + j = 512; > + for (i = 0; i < j; i++) > + { > + if (i == len + align1) > + p1[i] = 0; > + else > + { > + p1[i] = random () & BIG_CHAR; > + if (i >= align1 && i < len + align1 && !p1[i]) > + p1[i] = (random () & SMALL_CHAR) + 3; > + } > + } > + > + FOR_EACH_IMPL (impl, 1) As before, there is no need to use the ifunc variant test mechanism. > + { > + MEMSET (p2 - 64, '\1', 512 + 64); > + res = (UCHAR *) CALL (impl, (CHAR *) (p1 + align1)); This test does not make sense: strdup returns a newly allocated buffer on 'res' and you test the 'p2' which is different mmap region. Just use: char *r = strdup (p1 + align1) TEST_COMPARE_STRING (r, (CHAR *) (p1 + align1)); free (r); Since you can really check out of bounds access (as other string tests do) without trigger UB. > + for (j = 0; j < align2 + 64; ++j) > + { > + if (p2[j - 64] != '\1') > + { > + error (0, 0, "Iteration %zd - garbage before, %s (%zd, %zd, %zd)", > + n, impl->name, align1, align2, len); > + ret = 1; > + break; > + } > + } > + for (j = align2 + len + 1; j < 512; ++j) > + { > + if (p2[j] != '\1') > + { > + error (0, 0, "Iteration %zd - garbage after, %s (%zd, %zd, %zd)", > + n, impl->name, align1, align2, len); > + ret = 1; > + break; > + } > + } > + if (MEMCMP (p1 + align1, res, len + 1)) > + { > + error (0, 0, "Iteration %zd - different strings, %s (%zd, %zd, %zd)", > + n, impl->name, align1, align2, len); > + ret = 1; > + } > + } > + } > +} > + > + > +int > +test_main (void) > +{ > + size_t i; > + > + test_init (); > + > + printf ("%23s", ""); > + FOR_EACH_IMPL (impl, 0) > + printf ("\t%s", impl->name); > + putchar ('\n'); > + > + for (i = 0; i < 16; ++i) > + { > + do_test (0, 0, i, SMALL_CHAR); > + do_test (0, 0, i, BIG_CHAR); > + do_test (0, i, i, SMALL_CHAR); > + do_test (i, 0, i, BIG_CHAR); > + } > + > + for (i = 1; i < 8; ++i) > + { > + do_test (0, 0, 8 << i, SMALL_CHAR); > + do_test (8 - i, 2 * i, 8 << i, SMALL_CHAR); > + } > + > + for (i = 1; i < 8; ++i) > + { > + do_test (i, 2 * i, 8 << i, SMALL_CHAR); > + do_test (2 * i, i, 8 << i, BIG_CHAR); > + do_test (i, i, 8 << i, SMALL_CHAR); > + do_test (i, i, 8 << i, BIG_CHAR); > + } > + > + do_zero_len_test (); > + do_random_tests (); > + > + return ret; > +} > + > +#include