Re: [PATCH] test-container: Add $complocaledir and mkdirp.

[Carlos O'Donell <carlos@redhat.com>]

On 4/27/20 3:49 AM, Florian Weimer wrote:
> * Carlos O'Donell via Libc-alpha:
> 
>> From 925c47b47d597663606486402c38e2e729ed663c Mon Sep 17 00:00:00 2001
>> From: Carlos O'Donell <carlos@redhat.com>
>> Date: Thu, 23 Jan 2020 09:45:00 -0500
>> Subject: [PATCH] test-container: Add $complocaledir and mkdirp.
>>
>> In order to test localedef in the test-container framework it
>> is necessary to add support for one new variable and one new
>> command. For localedef to install a compiled locale in the default
>> location the directory needs to be created
>> e.g. mkdir -p $complocaledir/dir.  This command requires both the
>> new command 'mkdirp' e.g. mkdir -p, and the new variable
>> $complocaledir. The only way to avoid this would be to install
>> locales into the pristine container root, but that would slow down
>> container testing (currently only has builtin C/POSIX available).
> 
> You could create the directory unconditionally, without installing any
> locales into it?

That's a very good point. I know of no reason we would want the directory
*not* to be present. 

My argument is about saving time during testing and avoiding needing to
run 'make localedata/install-locales' and build all the SUPPORTED locales.

I'm going to adjust the patches and break them out like this:
- Create $(complocaledir) when making testroot.pristine
- Add new test.
- Fixup old test which uses xmkdirp to create $(complocaledir) since
  it is no longer required.

-- 
Cheers,
Carlos.