From: Paul Eggert <eggert@cs.ucla.edu>
To: Sunil Pandey <skpgkp2@gmail.com>
Cc: Noah Goldstein <goldstein.w.n@gmail.com>,
libc-alpha@sourceware.org, hjl.tools@gmail.com
Subject: Re: [PATCH] x86_64: Implement AVX2 version of strlcpy/wcslcpy function
Date: Mon, 3 Jul 2023 09:30:49 -0700 [thread overview]
Message-ID: <78aabdcb-bae8-abed-4ad1-ff9cc0285eab@cs.ucla.edu> (raw)
In-Reply-To: <CAMAf5_cZbEE2t_t9TtafV8=RS5eNBE95083UQM3enJd-S_nbUQ@mail.gmail.com>
On 2023-06-30 15:21, Sunil Pandey wrote:
> Attached is strcpy/wcslcpy microbenchmark data based on Noah
> strlcpy/wcslcpy microbenchmark patch.
Although it's helpful to know that the proposed patch improves
microbenchmark scores, that's not enough to justify it. Let's see
benchmarks of real programs. If they don't show significant wins, let's
not bother.
Programs that use strlcpy, by and large, don't use it in
performance-sensitive areas, and their developers and users are far more
worried about security than about performance. Making the implementation
harder to audit will likely be a net negative for these applications.
This doesn't sound a like a win at all.
Plus, who uses wcslcpy? Why bother to tune it if nobody uses it?
next prev parent reply other threads:[~2023-07-03 16:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 20:48 Sunil K Pandey
2023-06-30 21:04 ` Noah Goldstein
2023-06-30 21:27 ` Paul Eggert
2023-06-30 22:21 ` Sunil Pandey
2023-06-30 23:22 ` Noah Goldstein
2023-06-30 23:27 ` Noah Goldstein
2023-07-03 16:30 ` Paul Eggert [this message]
2023-07-03 18:40 ` Noah Goldstein
2023-07-03 18:54 ` Adhemerval Zanella Netto
2023-07-03 21:14 ` Paul Eggert
2023-07-03 22:04 ` Gabriel Ravier
2023-07-03 23:12 ` Paul Eggert
2023-07-04 7:45 ` Andreas Schwab
2023-07-03 12:55 ` Adhemerval Zanella Netto
2023-07-01 9:41 ` Florian Weimer
2023-07-02 1:22 ` Noah Goldstein
2023-07-02 6:51 ` Florian Weimer
2023-07-02 16:55 ` Noah Goldstein
2023-07-02 17:02 ` Florian Weimer
2023-07-02 17:03 ` Noah Goldstein
2023-07-02 18:37 ` Sunil Pandey
2023-07-02 18:54 ` Noah Goldstein
2023-07-03 1:03 ` Sunil Pandey
2023-07-03 1:47 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78aabdcb-bae8-abed-4ad1-ff9cc0285eab@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).