public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Rafal Luzynski <digitalfreak@lingonborough.com>
To: libc-alpha@sourceware.org, Jakub Martisko <jamartis@redhat.com>
Subject: Re: [PATCH][BZ #15527] strftime_l.c: Support lowercase output
Date: Tue, 06 Dec 2016 22:47:00 -0000	[thread overview]
Message-ID: <79385043.337806.1481064453550@poczta.nazwa.pl> (raw)
In-Reply-To: <58457FE6.9060803@redhat.com>

5.12.2016 15:55 Jakub Martisko <jamartis@redhat.com> wrote:
>
>
> Hello Rafal,
>
> as for the order of ^# flags - right now the change case
> flag works as an upper case flag for options which are in
> title case by default (Sun -> SUN) and as lowercase for
> those, which are in uppercase by default (AM -> am). In my
> opinion, treating "%^#A" and "%#^A" as an idiom for lower
> case makes the most sense. If you consider "%#^A", the
> output would switch case (whatever that means) and then be
> switched to uppercase. The "#" flag would thus be ignored.

Yes, that's true. Switching the case and then converting to
uppercase wouldn't make sense. And this is how your patch
works, as far as I remember: it switches to lowercase no matter
what is the order of "#" and "^".

I think that this either should be documented or (maybe better)
should be treated as an undefined behavior: not documented,
maybe producing bad results, maybe even producing correct
results, maybe will be changed in future. It may be also
explicitly documented as undefined behavior.

> As for the title case part of your message, I am probably
> not the right person to answer it:-(.

I don't think so. :-) I thought you were a non-English native
speaker; sorry if I'm wrong but if I'm not then you can
provide some valuable input here. How does it look in your
native language? Are all months and weekdays names always
written in lowercase? Wouldn't you like them to start with
an uppercase letter sometimes? For example, if you display
a calendar would you prefer "December" or "december"
in the header? Or if you display a date with a weekday
would you prefer "Wednesday, 7th of december" or
"wednesday, 7th of decebmer"? What is your solution to
achieve a proper result?

Regards,

Rafal

  reply	other threads:[~2016-12-06 22:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15  8:54 Jakub Martisko
2016-06-15  9:09 ` Andreas Schwab
2016-06-29  7:55   ` Jakub Martisko
2016-12-06 23:20     ` Mike Frysinger
2016-12-07 10:18       ` Jakub Martisko
2016-12-07 15:39         ` Mike Frysinger
2016-12-09  1:14           ` Rafal Luzynski
2016-12-09  4:08             ` Mike Frysinger
2016-12-09 11:00               ` Rafal Luzynski
2016-12-09 16:20                 ` Mike Frysinger
2016-12-09 22:37                   ` Rafal Luzynski
2017-04-07 23:29                     ` Rafal Luzynski
2016-11-29 12:21 ` Jakub Martisko
2016-11-29 12:42   ` Jakub Martisko
2016-12-01 23:29     ` Rafal Luzynski
2016-12-05 14:55       ` Jakub Martisko
2016-12-06 22:47         ` Rafal Luzynski [this message]
2016-12-06 23:21 ` Mike Frysinger
  -- strict thread matches above, loose matches on Subject: below --
2016-05-12 15:26 [PATCH][BZ 15527] " Jakub Martisko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79385043.337806.1481064453550@poczta.nazwa.pl \
    --to=digitalfreak@lingonborough.com \
    --cc=jamartis@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).