From: Stefan Liebler <stli@linux.ibm.com>
To: libc-alpha@sourceware.org,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] io: Return EBAFD for negative file descriptor on fstat (BZ #27559)
Date: Fri, 12 Mar 2021 14:44:24 +0100 [thread overview]
Message-ID: <7991f809-7071-88ba-88da-773af958f28f@linux.ibm.com> (raw)
In-Reply-To: <8ed07bf3-5695-0637-092c-c4fc0a3de95f@linaro.org>
On 3/11/21 1:37 PM, Adhemerval Zanella via Libc-alpha wrote:
>
>
> On 11/03/2021 09:13, Florian Weimer wrote:
>> * Adhemerval Zanella via Libc-alpha:
>>
>>> Now that fstat is implemented on top fstatat we need to handle negative
>>> inputs.
>>
>> Please mention AT_FDCWD in the commit message. Or add a comment to the
>> code that the check rejects AT_FDCWD, which would otherwise be accepted
>> by the kernel.
>>
>> The patch looks okay otherwise.
>
> Ack. I will also add the missing tst-stat-lfs (which is just a wrapper
> to set __FILE_OFFSET_BITS=64).
>
Hi Adhemerval,
I've just recognized that io/tst-stat is failing on my s390 (31bit) system:
tst-stat.c:94: numeric comparison failure
left: 315117680 (0x12c85070); from: stx.stx_ctime.tv_nsec
right: 0 (0x0); from: st.st_ctim.tv_nsec
tst-stat.c:96: numeric comparison failure
left: 315117680 (0x12c85070); from: stx.stx_mtime.tv_nsec
right: 0 (0x0); from: st.st_mtim.tv_nsec
tst-stat.c:94: numeric comparison failure
left: 315117680 (0x12c85070); from: stx.stx_ctime.tv_nsec
right: 0 (0x0); from: st.st_ctim.tv_nsec
tst-stat.c:96: numeric comparison failure
left: 315117680 (0x12c85070); from: stx.stx_mtime.tv_nsec
right: 0 (0x0); from: st.st_mtim.tv_nsec
tst-stat.c:94: numeric comparison failure
left: 315117680 (0x12c85070); from: stx.stx_ctime.tv_nsec
right: 0 (0x0); from: st.st_ctim.tv_nsec
tst-stat.c:96: numeric comparison failure
left: 315117680 (0x12c85070); from: stx.stx_mtime.tv_nsec
right: 0 (0x0); from: st.st_mtim.tv_nsec
tst-stat.c:94: numeric comparison failure
left: 315117680 (0x12c85070); from: stx.stx_ctime.tv_nsec
right: 0 (0x0); from: st.st_ctim.tv_nsec
tst-stat.c:96: numeric comparison failure
left: 315117680 (0x12c85070); from: stx.stx_mtime.tv_nsec
right: 0 (0x0); from: st.st_mtim.tv_nsec
error: 8 test failures
But I have to admit, I haven't looked into the test yet and won't be
able before next week. But I wanted to report it now.
Bye,
Stefan
next prev parent reply other threads:[~2021-03-12 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 12:03 Adhemerval Zanella
2021-03-11 12:13 ` Florian Weimer
2021-03-11 12:37 ` Adhemerval Zanella
2021-03-12 13:44 ` Stefan Liebler [this message]
2021-03-12 13:57 ` Adhemerval Zanella
2021-03-12 14:21 ` Adhemerval Zanella
2021-03-16 13:57 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7991f809-7071-88ba-88da-773af958f28f@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).