From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C0F6C3858D38 for ; Sat, 3 Jun 2023 02:02:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0F6C3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685757756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7jL/88e/sYmn6S1XqQBM9RjJ18jZ+K2ONUGear93hpE=; b=KxuxK9HuWD2YHMBuutKwV2t3Ve30lZ/8vVvY3teX62a/5/CDWF16dXnqMR0KnZN7VMSxhb 8tskS8OFdDTtd2QkDp72ggDveog651ioYgUSUdm2ntka2fvi+jKk0hB9a4vtaKG5lLYsaN jSdY5BvSqxsdgGl6MigIZ3XgoT8f8mE= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-444-QEiHpgM0Psy-pfwIUWd0kA-1; Fri, 02 Jun 2023 22:02:35 -0400 X-MC-Unique: QEiHpgM0Psy-pfwIUWd0kA-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-5695f6ebd85so16082517b3.3 for ; Fri, 02 Jun 2023 19:02:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685757754; x=1688349754; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7jL/88e/sYmn6S1XqQBM9RjJ18jZ+K2ONUGear93hpE=; b=k02b+3It8Nv1kkcqVb/OV5fJTC3cfJY+NftQVGUGwZc2hUmE0Dbi9s7TchlURQX23F xKpUCYWAiyRljMytazPs+iUgAD21HFEu3eynzqwn1GATO8Q30oD8bzXbLa+hD32skPAL tg7vkf6DDObob3WyDd5HmGjb7ybrD/GNK/uIB3if/KsPpF9l2IWzjnOXra/Vhr/Cqawi pVOkl3HQMz552g9VkhXjKdF1GXkY++IgoBjlsBhhfykxyACkSftctoLVPDrROYhMhXg2 PNHyhK0UbsUChhJmodc8STP4ToJ9k6LbsYyWuYGk2A+29jGUvazU3RXy+SCzUH1uMEoj gOBQ== X-Gm-Message-State: AC+VfDxrCZpfUvl7OyiZ5CjI9Pf7Co9bDpvymigYCBFTcKc4F64YguQt ZFKzzlFy/VNU3lnedKWJHksbQ0USeYlDqY7oWQ8m2fo0HRvciQolVsc+a1T2VBcfHeq8DRQMoPq MdF/JL+2R9FoItxOr1X2Ry6loha2d X-Received: by 2002:a0d:d747:0:b0:55d:ba47:5359 with SMTP id z68-20020a0dd747000000b0055dba475359mr2035527ywd.31.1685757754675; Fri, 02 Jun 2023 19:02:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6uaCBYrC7k5xZrn5KeJQrDNtcoZkFnwAQK69kDgW2c8sgNnoi4HMx96mgm/MWZt/CRq7+lgA== X-Received: by 2002:a0d:d747:0:b0:55d:ba47:5359 with SMTP id z68-20020a0dd747000000b0055dba475359mr2035510ywd.31.1685757754429; Fri, 02 Jun 2023 19:02:34 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id x186-20020a817cc3000000b0054fba955474sm1050638ywc.17.2023.06.02.19.02.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 19:02:33 -0700 (PDT) Message-ID: <79b2a685-1efc-be61-c8db-4f19531b38e6@redhat.com> Date: Fri, 2 Jun 2023 22:02:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: Remove MAP_VARIABLE from hppa bits/mman.h To: Joseph Myers , libc-alpha@sourceware.org References: <6e50c64-98e6-7cbf-52be-c0167eb2dd9@codesourcery.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <6e50c64-98e6-7cbf-52be-c0167eb2dd9@codesourcery.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/17/23 16:38, Joseph Myers wrote: > As suggested in > , > remove the MAP_VARIABLE define from the hppa bits/mman.h, for > consistency with Linux 6.2 which removed the define there. > > Tested with build-many-glibcs.py for hppa-linux-gnu. > > diff --git a/sysdeps/unix/sysv/linux/hppa/bits/mman.h b/sysdeps/unix/sysv/linux/hppa/bits/mman.h > index f5a69693af..651b7dcb72 100644 > --- a/sysdeps/unix/sysv/linux/hppa/bits/mman.h > +++ b/sysdeps/unix/sysv/linux/hppa/bits/mman.h > @@ -24,7 +24,6 @@ > > /* Other flags. */ > #define __MAP_ANONYMOUS 0x10 /* Don't use a file */ > -#define MAP_VARIABLE 0 > > /* These are Linux-specific. */ > #define MAP_DENYWRITE 0x0800 /* ETXTBSY */ > LGTM. Reviewed Linux at commit 933174ae28ba72ab8de5b35cb7c98fc211235096 (6.4.0-rc3) and there is no more references to MAP_VARIABLE. The references are removed as of 71bdea6f798b425bc0003780b13e3fdecb16a010 and are no longer in the UAPI mman.h headers. Reviewed-by: Carlos O'Donell -- Cheers, Carlos.