From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from glow.apple.relay.mailchannels.net (glow.apple.relay.mailchannels.net [23.83.208.71]) by sourceware.org (Postfix) with ESMTPS id E74FB3850414 for ; Thu, 15 Apr 2021 06:05:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E74FB3850414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 415CA7028D3; Thu, 15 Apr 2021 06:05:30 +0000 (UTC) Received: from pdx1-sub0-mail-a91.g.dreamhost.com (100-96-16-53.trex.outbound.svc.cluster.local [100.96.16.53]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 07CA5702358; Thu, 15 Apr 2021 06:05:29 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a91.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.16.53 (trex/6.1.1); Thu, 15 Apr 2021 06:05:30 +0000 X-MC-Relay: Good X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Illegal-Abiding: 361a19df19198eae_1618466730119_960975743 X-MC-Loop-Signature: 1618466730119:3453323711 X-MC-Ingress-Time: 1618466730119 Received: from pdx1-sub0-mail-a91.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a91.g.dreamhost.com (Postfix) with ESMTP id 9F5307E3C2; Wed, 14 Apr 2021 23:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=BK0M3r rEz8mCDVNd8Y8CEhI8zQE=; b=uFnTevmcxk3na/c0ueCEb5tXJHzNK8nKFXXDUP DkOguJoLopInrmgpVWXitjfeV/xOpvpf88BaG6BX6+Mvt7JHz3G5Vh/qCzCvHRmV WPO2pHfjeNKxinyI10PEMlvLR1cEnDgSKgVZYMBDIAfLld7lF9XsLO2Tte6xwoR5 Zyi+I= Received: from [192.168.1.111] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a91.g.dreamhost.com (Postfix) with ESMTPSA id 710917E3B9; Wed, 14 Apr 2021 23:05:24 -0700 (PDT) Subject: Re: [PATCH 08/15] time: Add timegm/timelocal basic tests To: Adhemerval Zanella , Andreas Schwab , Adhemerval Zanella via Libc-alpha References: <20210323134458.2563022-1-adhemerval.zanella@linaro.org> <20210323134458.2563022-9-adhemerval.zanella@linaro.org> <87zgyulzbc.fsf@igel.home> X-DH-BACKEND: pdx1-sub0-mail-a91 From: Siddhesh Poyarekar Message-ID: <79cafa7e-d2c8-9420-996d-bca40728e6de@gotplt.org> Date: Thu, 15 Apr 2021 11:35:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3028.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2021 06:05:33 -0000 On 3/23/21 9:23 PM, Adhemerval Zanella via Libc-alpha wrote: >=20 >=20 > On 23/03/2021 11:28, Andreas Schwab wrote: >> On M=C3=A4r 23 2021, Adhemerval Zanella via Libc-alpha wrote: >> >>> +=C2=A0 /* timelocal is a alias to timegm with the only difference it= =20 >>> takes local >>> +=C2=A0=C2=A0=C2=A0=C2=A0 timezone into account, while timegm takes t= he input value to be=20 >>> UTC.=C2=A0 */ >> >> That doesn't make sense.=C2=A0 How can they be aliases if they differ? >=20 > Indeed, I got confused there.=C2=A0 A better comment would be: >=20 > | /* timelocal is an alias to mktime and behaves like timegm with the > |=C2=A0=C2=A0=C2=A0 difference that it takes timezone into account.=C2=A0= */ >=20 LGTM with this comment change. Reviewed-by: Siddhesh Poyarekar