From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id 94E6E3857C5F for ; Wed, 24 Mar 2021 13:04:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 94E6E3857C5F Received: by mail-qk1-x730.google.com with SMTP id v70so17851786qkb.8 for ; Wed, 24 Mar 2021 06:04:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AsPKaajUaX4r6IaYsKETeLUssBQmYnEJaYfWN7yqgP0=; b=pk7c5CHRx3bnOHhJnAY4+Xqi7AMO4zj+iHjI3S94DHdxfJ7bcDgSH4sTdm1R86EuMS vuQhBfQtT7MZBP6ni6uQ8ivlLu2syVSLjePvqoqi/NUNhPymiqntdr1cxWmvI5nBMyTZ JU2xaaN+RLsBcEUdpuqSATKpdRBHykWfRQSOFByxu2awBoxLCJyct1g1tDu+8UTr6Re0 w1Jao1EBWXngHX+fHtFnT8H9oJJOa/yWoSYN5KaV4cn6gvvaa+1SuIfBPbMsWaOkPHr5 lwwZ6FqCrRXmAwq9irTjdPoOug0un9NvQrqiTtDsixDRJaX6Uy3QX5xwcalEFqa5HNvW TcNQ== X-Gm-Message-State: AOAM530/cnu5oSYGoyXnuyDYRakb+NTi+1krM9FTSRGc1Jzues1wHAfH EPMHI9aBLr8TA5z9xFtLbWY7Eekljhst6w== X-Google-Smtp-Source: ABdhPJx6YJsA0KyGNJj5rOEWB+GpMv3BLwthJyp7+JklkmxbRSb+qRFTCZe5YjamHsoQ4dqgvRblhA== X-Received: by 2002:a05:620a:22ea:: with SMTP id p10mr2875980qki.27.1616591043014; Wed, 24 Mar 2021 06:04:03 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id d24sm1554293qkl.49.2021.03.24.06.04.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 06:04:02 -0700 (PDT) Subject: Re: [hurd,commited] htl: Add missing fork.h To: Samuel Thibault Cc: libc-alpha@sourceware.org References: <20210324002015.338244-1-samuel.thibault@ens-lyon.org> <20210324123136.x5ab7fkrcm557enm@begin> <6aa8826c-b8ab-d999-4b99-e61c27282587@linaro.org> <20210324124532.sp6nkal764gwyatj@begin> <20210324130039.stnuexy2tw7wnkuf@begin> From: Adhemerval Zanella Message-ID: <79f51c68-8820-1994-8802-91411a705de3@linaro.org> Date: Wed, 24 Mar 2021 10:04:00 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324130039.stnuexy2tw7wnkuf@begin> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 13:04:07 -0000 On 24/03/2021 10:00, Samuel Thibault wrote: > Adhemerval Zanella, le mer. 24 mars 2021 09:56:47 -0300, a ecrit: >> On 24/03/2021 09:45, Samuel Thibault wrote: >>> Adhemerval Zanella, le mer. 24 mars 2021 09:40:36 -0300, a ecrit: >>>> Why exactly tst-atfork2 fails without this includes? >>> >>> It misses the atfork unregister hook called at module unload. >> >> Ok, but *why* exactly? The sysdeps/htl/pt-atfork.c already >> includes register-atfork.h after the fork.h inclusion. > > It's not pt-atfork.c which needs UNREGISTER_ATFORK, but > stdlib/cxa_finalize, which gets it from fork.h Thanks, this is a good indication that is better to just remove the ifdef UNREGISTER_ATFORK from cxa_finalize (since now it is defined on generic implementation).