From: Florian Weimer <fweimer@redhat.com>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: RFC V3 [1/2] test-in-container
Date: Mon, 25 Jun 2018 15:17:00 -0000 [thread overview]
Message-ID: <7a010a26-3d68-8da3-cf06-2ce8c1685cd1@redhat.com> (raw)
In-Reply-To: <xnfu5js8fl.fsf@greed.delorie.com>
On 03/02/2018 12:05 AM, DJ Delorie wrote:
> +CFLAGS-test-container.c = \
> + -DSRCDIR_PATH=\"`cd .. ; pwd`\" \
> + -DOBJDIR_PATH=\"`cd $(objpfx)/..; pwd`\" \
> + -DINSTDIR_PATH=\"${prefix}\" \
> + -DLIBDIR_PATH=\"${libdir}\"
I think OBJDIR_PATH could be $(objdir). It's also odd to see make
variables expanded with ${â¦}.
Could you add variables (maybe support_srcdir, support_objdir,
support_prefix, support_libdir) to a separate file under support/ and
add matching declarations, perhaps in support/support.h? This looks
generally useful to me.
Thanks,
Florian
next prev parent reply other threads:[~2018-06-25 15:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 23:05 DJ Delorie
2018-06-25 15:01 ` Florian Weimer
2018-06-25 21:49 ` DJ Delorie
2018-06-26 11:43 ` Florian Weimer
2018-06-29 1:57 ` RFC V4 test-in-container DJ Delorie
2018-06-29 16:05 ` Joseph Myers
2018-06-29 16:16 ` DJ Delorie
2018-06-29 17:43 ` Joseph Myers
2018-07-06 5:20 ` RFC V5 test-in-container DJ Delorie
2018-07-06 12:36 ` Carlos O'Donell
2018-06-25 15:17 ` Florian Weimer [this message]
2018-06-25 22:58 ` RFC V3 [1/2] test-in-container DJ Delorie
2018-06-25 23:09 ` Florian Weimer
2018-06-26 1:57 ` DJ Delorie
2018-06-26 12:28 ` Florian Weimer
2018-06-26 12:56 ` Florian Weimer
2018-06-26 12:57 ` Florian Weimer
2018-06-28 20:35 ` DJ Delorie
2018-06-26 13:00 ` Florian Weimer
2018-06-26 13:04 ` Florian Weimer
2018-06-28 21:07 ` DJ Delorie
2018-06-29 5:01 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a010a26-3d68-8da3-cf06-2ce8c1685cd1@redhat.com \
--to=fweimer@redhat.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).