From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-93584-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 124080 invoked by alias); 25 Jun 2018 15:17:49 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 124071 invoked by uid 89); 25 Jun 2018 15:17:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit
X-HELO: mx1.redhat.com
Subject: Re: RFC V3 [1/2] test-in-container
To: DJ Delorie <dj@redhat.com>
References: <xnfu5js8fl.fsf@greed.delorie.com>
From: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Message-ID: <7a010a26-3d68-8da3-cf06-2ce8c1685cd1@redhat.com>
Date: Mon, 25 Jun 2018 15:17:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <xnfu5js8fl.fsf@greed.delorie.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SW-Source: 2018-06/txt/msg00738.txt.bz2

On 03/02/2018 12:05 AM, DJ Delorie wrote:
> +CFLAGS-test-container.c = \
> +		-DSRCDIR_PATH=\"`cd .. ; pwd`\" \
> +		-DOBJDIR_PATH=\"`cd $(objpfx)/..; pwd`\" \
> +		-DINSTDIR_PATH=\"${prefix}\" \
> +		-DLIBDIR_PATH=\"${libdir}\"


I think OBJDIR_PATH could be $(objdir).  It's also odd to see make 
variables expanded with ${…}.

Could you add variables (maybe support_srcdir, support_objdir, 
support_prefix, support_libdir) to a separate file under support/ and 
add matching declarations, perhaps in support/support.h?  This looks 
generally useful to me.

Thanks,
Florian