From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5899E3858D33 for ; Sat, 20 Jan 2024 23:27:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5899E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5899E3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705793270; cv=none; b=YvpIuDtFFWso4uaOZmbU/iQIDUbJok314V7yPB9qww/BXZOuYVEijLjusVvcHjN5evT75ih4p0KXV9bJo+lsnqnhlFyJ7VfFjpV86sYuOhKZ5Pv1BYRvoABFAV/AKNJ/L6xausgltIy/HtHNBqIr7Dvbnx9h8VXPp8WoyB/3IYw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705793270; c=relaxed/simple; bh=kb7ZnxpB/C30RCdItlzZunIu3ixJy2W6Mf5zLVxDgsc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=nSSWAsFXGx24L7Y6ZJK0XidkVCcl5MbuMKqqhPbTzpHh58D/XMqAJ7MAVtklYio0oYhOWYPdVxfWoA7C9/UIFI6yzR9YBjo8v5+HCzyrKGl8fFqZ0bEsodVI5atbGtGTk50VCd6PxR5qdWRhVWGJk1ztRxArShGxQ6uudUwF8c4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705793268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ep7JlKzq8z9qROf/5UJHex0QS85pEy+hM3/vujwl7M4=; b=VWcMiq0zu/QQthCtEsI19DAQXoTZG9F6ep1urLG7dex5Jyltt6uvwQIAFbosWIB1KfUbe1 MN/YIBtCPHLkr2cRgUnptVeqoksTsUU/ZGGbvZQvco8Q/FgOBfLL/vPHTyFH7JFFNZyG3v u7qpXjmioTQPYjudaD1ePjiPsrgvKzk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-NjntnYD0N3OPneGGVudUPw-1; Sat, 20 Jan 2024 18:27:46 -0500 X-MC-Unique: NjntnYD0N3OPneGGVudUPw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3392d419c7dso116166f8f.1 for ; Sat, 20 Jan 2024 15:27:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705793265; x=1706398065; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ep7JlKzq8z9qROf/5UJHex0QS85pEy+hM3/vujwl7M4=; b=XlkvdYTw8v4HGQfwTARBjyMNla9beBCx1O51PBMMkL3VIHUan+lAhgrSDEcePv7wVV xTS4bvQILI0fcWTghV5+nOthIJvKR9F5sXGOXU5l2XT0CmG4MnZlMl3BoXtFqsYVSTFE euqQketawNbXEIFSeUpiVhPpt5NNPszflbWTqN84Qu6+seRgUHMmYesmJFQlgTFPqD8E A3u+KsMOI++7kQ2mH7g50DTA7MxvfFi3IwxGE95NqABkftkCH8xX+r1jQQsYxtkJqHV4 z2597OaOyvYn5VTYUHjnPMjd5Khcfp2yI7mQzvMHxviuBasfWviI2bAt9V4sle8jX1Br QdqQ== X-Gm-Message-State: AOJu0YytAhdyNcMAZWM1A/bGpXjVPg1coXHpF8g+dS5PdLPLfDmPt+vj nazR2h6XCibRIWYrE/b+5hIz9b2InqYbUyClSGXx6eJLWN0mYCmLLXTZCZMxRWKOFrs1e6bXsow +Pq6H4utIiYuTi+G6uO3jg8+kKoKa1VHizkPT1TT3eWb9KeB/j7xj+J5bqeqvOU6wOQ== X-Received: by 2002:a5d:448b:0:b0:337:c555:18b5 with SMTP id j11-20020a5d448b000000b00337c55518b5mr1012357wrq.115.1705793265337; Sat, 20 Jan 2024 15:27:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHy3+qrMAQV7wfHcrRWg/tJxdLeYgAOnNORUVoPZYcKBO+xtswrFhiolLtYHNOY+MSn/jt56w== X-Received: by 2002:a5d:448b:0:b0:337:c555:18b5 with SMTP id j11-20020a5d448b000000b00337c55518b5mr1012355wrq.115.1705793265065; Sat, 20 Jan 2024 15:27:45 -0800 (PST) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id x1-20020adff641000000b0033922db3f74sm4262392wrp.116.2024.01.20.15.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jan 2024 15:27:44 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rRKk9-003MSA-4o; Sat, 20 Jan 2024 23:27:17 +0000 Date: Sat, 20 Jan 2024 23:27:17 +0000 (UTC) From: Joseph Myers To: Jakub Jelinek cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Use gcc __builtin_stdc_* builtins in stdbit.h if possible In-Reply-To: Message-ID: <7aa693ad-514e-7b7a-8d3-2c59af649ca@redhat.com> References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 20 Jan 2024, Jakub Jelinek wrote: > +# define stdc_leading_zeros_uc(x) \ > + (__builtin_stdc_leading_zeros ((unsigned char) (x))) > +# define stdc_leading_zeros_us(x) \ > + (__builtin_stdc_leading_zeros ((unsigned short) (x))) > +# define stdc_leading_zeros_ui(x) \ > + (__builtin_stdc_leading_zeros ((unsigned int) (x))) > +# define stdc_leading_zeros_ul(x) \ > + (__builtin_stdc_leading_zeros ((unsigned long int) (x))) > +# define stdc_leading_zeros_ull(x) \ > + (__builtin_stdc_leading_zeros ((unsigned long long int) (x))) I don't like defining any of the type-specific functions as macros using casts (as opposed to implicit conversions); implicit conversions ensure they have appropriate diagnostics for bad argument types that might be lost with a cast (in particular, if someone passes a pointer to one of the functions taking a pointer-sized integer, getting an error from the implicit conversion is desirable, rather that a cast from pointer to integer without a diagnostic). -- Joseph S. Myers josmyers@redhat.com