public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Stefan Liebler <stli@linux.ibm.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
	libc-alpha@sourceware.org
Subject: Re: [PATCH] build-many-glibcs.py: Add s390 --disable-multi-arch / multi-arch configurations.
Date: Wed, 21 Feb 2024 08:53:21 +0100	[thread overview]
Message-ID: <7b02803e-77dc-4499-a5ed-a2e756be3fb5@linux.ibm.com> (raw)
In-Reply-To: <25182574-bb9d-427b-acd6-7d6a713355ca@linaro.org>

On 20.02.24 15:48, Adhemerval Zanella Netto wrote:
> 
> 
> On 31/01/24 09:02, Stefan Liebler wrote:
>> This patch adds some --disable-multi-arch variants for s390x.
>>
>> As the used IFUNC variants and __GI symbols depend on the used
>> gcc -march=cpu-level, there are multiple new configurations.
> 
> Not really sure if this optimization to avoid building/providing ifunc
> variants for zseries really pays off the extra burden to check if 
> all possible permutations build fine.
> 
> LGTM, thanks.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
> 
Thanks. I've committed the patch.
>> ---
>>  scripts/build-many-glibcs.py | 17 ++++++++++++++++-
>>  1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
>> index d142684fdf..1cc9847815 100755
>> --- a/scripts/build-many-glibcs.py
>> +++ b/scripts/build-many-glibcs.py
>> @@ -417,7 +417,22 @@ class Context(object):
>>                          glibcs=[{},
>>                                  {'arch': 's390', 'ccopts': '-m31'}],
>>                          extra_glibcs=[{'variant': 'O3',
>> -                                       'cflags': '-O3'}])
>> +                                       'cflags': '-O3'},
>> +                                      {'variant': 'zEC12',
>> +                                       'ccopts': '-march=zEC12'},
>> +                                      {'variant': 'z13',
>> +                                       'ccopts': '-march=z13'},
>> +                                      {'variant': 'z15',
>> +                                       'ccopts': '-march=z15'},
>> +                                      {'variant': 'zEC12-disable-multi-arch',
>> +                                       'ccopts': '-march=zEC12',
>> +                                       'cfg': ['--disable-multi-arch']},
>> +                                      {'variant': 'z13-disable-multi-arch',
>> +                                       'ccopts': '-march=z13',
>> +                                       'cfg': ['--disable-multi-arch']},
>> +                                      {'variant': 'z15-disable-multi-arch',
>> +                                       'ccopts': '-march=z15',
>> +                                       'cfg': ['--disable-multi-arch']}])
>>          self.add_config(arch='sh3',
>>                          os_name='linux-gnu')
>>          self.add_config(arch='sh3eb',


      reply	other threads:[~2024-02-21  7:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 12:02 Stefan Liebler
2024-02-19 13:34 ` Stefan Liebler
2024-02-20 14:48 ` Adhemerval Zanella Netto
2024-02-21  7:53   ` Stefan Liebler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b02803e-77dc-4499-a5ed-a2e756be3fb5@linux.ibm.com \
    --to=stli@linux.ibm.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).