From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by sourceware.org (Postfix) with ESMTPS id E98703855002 for ; Wed, 23 Jun 2021 21:15:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E98703855002 Received: by mail-qk1-x72c.google.com with SMTP id c23so8871658qkc.10 for ; Wed, 23 Jun 2021 14:15:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=80QgI/4shqk9tzRb73HUsujg4KytvP+NQebF1/a+kHw=; b=FSdT8CxSyr7x9oKJM7FCQ75oZrKW/Xp+NJIRwwykIlnyb6XYcruS9q8E3EaJ8nBmpr BZ/p7huVod5axw4HhD/ZaTT7FtnhAQY3a4HB33RbFZQYTusRd8wGCmgKDSr6teKY7HP2 erIHXHMBuOERassQPLUqr9bLJUmFQDIt0bvcIIR7dzOuIQArAtlneVRzmok9WqY8tR98 39QE7Q5H8kKLUfr0sxwCy0Ao25dpS/RMJDU/88/rQgdZb3CyDpJSQ90CZUhS5wBW8dGS UF/SMG4t9rfcJzOrKxmacvXj/ECFugaAduY863lOJQph3wiKrg+fZyqVbs84KIBPJK3Z u2sw== X-Gm-Message-State: AOAM532VYC/e9k9yTQ3hqufsIHeyo9XkLf5OYZDQG3XXWJqYsfB+BSYt aWSwvwxL1bwNJw/MiGlytfNKbq33qsWyFw== X-Google-Smtp-Source: ABdhPJxqFCza744Wn4+XvStjSxtyrw0biQv2PHXkTVB9//fDUYlHzGglw+silrY8aIO85KlVYnVfXw== X-Received: by 2002:a05:620a:4109:: with SMTP id j9mr2146679qko.188.1624482957239; Wed, 23 Jun 2021 14:15:57 -0700 (PDT) Received: from [192.168.1.108] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id 4sm877979qkv.134.2021.06.23.14.15.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jun 2021 14:15:56 -0700 (PDT) Subject: Re: [PATCH] x86: Fix tst-cpu-features-cpuinfo on Ryzen 9 (BZ #27873) To: "H.J. Lu" Cc: GNU C Library References: <20210623145419.3025540-1-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Message-ID: <7b2557a7-9b86-7121-a366-5fee330f8364@linaro.org> Date: Wed, 23 Jun 2021 18:15:54 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 21:15:59 -0000 On 23/06/2021 17:41, H.J. Lu wrote: >> @@ -216,12 +233,15 @@ do_test (int argc, char **argv) >> fails += CHECK_PROC (sgx, SGX); >> fails += CHECK_PROC (sgx_lc, SGX_LC); >> fails += CHECK_PROC (sha_ni, SHA); >> - fails += CHECK_PROC (shstk, SHSTK); >> + fails += CHECK_PROC_OPTIN (shstk, SHSTK); > > Why do you need this? If kernel doesn't support SHSTK, it will be > turned off: > > /* Check CET status. */ > unsigned int cet_status = get_cet_status (); > > if ((cet_status & GNU_PROPERTY_X86_FEATURE_1_IBT) == 0) > CPU_FEATURE_UNSET (cpu_features, IBT) > if ((cet_status & GNU_PROPERTY_X86_FEATURE_1_SHSTK) == 0) > CPU_FEATURE_UNSET (cpu_features, SHSTK) The problem is this is only enabled for CET_ENABLED, the configuration I am using does not define __CET__. So the CPU I am using does support SHSTK, but the bit ended up not being cleared by glibc.