From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by sourceware.org (Postfix) with ESMTPS id 60F783857007 for ; Wed, 1 Jul 2020 19:45:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60F783857007 Received: by mail-qt1-x844.google.com with SMTP id u17so19445215qtq.1 for ; Wed, 01 Jul 2020 12:45:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=c4zpncRf/53Fw9b9WE/YB69yuU0m4G/4KFqvY9EzQz4=; b=Ay7cKu0emiHicPjvYJ0FITUcX7bhLVG01jZmECb5VwtyIka3/rnw0mtZ7i2F6X0DRy NwpcScD/bsQlha3jyVtpCkG8Wib1HqlaaRF0jUOVEHLVDagzUWqthCH6bFYuzCv0XY4w MpOiqw9sNxRy87AqQq74cszMuuOuY9cO1XzvjjDayxw4iw/WdEtJZfkTo/f62mrumgit Vxmep15TdrbDK+9cW0wM2gF1ul6f17J4ei4IrUGlMOnBffV+IE/pyi44J5ZUtdH/gIi+ SHk2UU8C3Y/ZFbtRVswcXtYdBsbWJWq2G3EuxpDpTJWsmluFM8p3wroRxsA9w2NJZ7fh 7Tzw== X-Gm-Message-State: AOAM5337eVvvVXjou6Jcf6LT2Ole+EX/ecKIUoxDtyd92HLP1l0+sGZK 1Lt12y3a/9n0G9ne6RbmedhSvhas03g= X-Google-Smtp-Source: ABdhPJxNWtKA+bnt9TEuEfdPWlOEHLq7bf+HDcuo9fedZUFGwWW8/xALI71e/NSpWSOVwzhoOp2dNw== X-Received: by 2002:ac8:7a69:: with SMTP id w9mr28217718qtt.179.1593632757894; Wed, 01 Jul 2020 12:45:57 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id x14sm6242635qki.65.2020.07.01.12.45.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2020 12:45:57 -0700 (PDT) Subject: Re: [PATCH v7.1 01/13] ARC: ABI Implementation To: Vineet Gupta , "libc-alpha@sourceware.org" Cc: arcml References: <20200615201441.31820-2-vgupta@synopsys.com> <20200701000643.14065-1-vgupta@synopsys.com> <96a79297-9161-89a2-25d6-473979525367@synopsys.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <7b8f6b61-c75c-b0b5-d2fc-89a6fa007569@linaro.org> Date: Wed, 1 Jul 2020 16:45:54 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <96a79297-9161-89a2-25d6-473979525367@synopsys.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2020 19:45:59 -0000 On 01/07/2020 16:36, Vineet Gupta wrote: > On 7/1/20 9:50 AM, Adhemerval Zanella via Libc-alpha wrote: >> >> >> On 30/06/2020 21:06, Vineet Gupta via Libc-alpha wrote: >>> This code deals with the ARC ABI. >>> --- >>> Changes since v7: >>> - Used void * (iso int *) in tls-macros.h >> >> LGTM, with just a couple of syntax nits below. >> >> Reviewed-by: Adhemerval Zanella > > Thx. I suppose the process for new ports is to have a Reviewed-by on all patches, > squash them and push in 1 go (although in past I was asked to push the ARC elf > header patch). I think there is no need to squash them up in one commit, but I think it would be better to commit them at the same time. > Also do we need more than 1 Reviewed-by for this to be "push worthy" ? I don't think so, unless someone raise some questioning on the review itself. I plan to finish them up by the end of the week. > >>> +ENTRY (__longjmp) >>> + >>> + LDR (blink, r0, 0) >>> + LDR (sp, r0, 1) >>> + LDR (fp, r0, 2) >>> + LDR (gp, r0, 3) >>> + >>> + LDR (r13, r0, 4) >>> + LDR (r14, r0, 5) >>> + LDR (r15, r0, 6) >>> + LDR (r16, r0, 7) >>> + LDR (r17, r0, 8) >>> + LDR (r18, r0, 9) >>> + LDR (r19, r0, 10) >>> + LDR (r20, r0, 11) >>> + LDR (r21, r0, 12) >>> + LDR (r22, r0, 13) >>> + LDR (r23, r0, 14) >>> + LDR (r24, r0, 15) >>> + >>> + mov.f r0, r1 >>> + j.d [blink] >>> + mov.z r0, 1 /* don't return 0 to setjmp callsite from longjmp. */ >>> + >>> +END (__longjmp) >> >> Ok, you have removed r25 save as pre previous discussion. > > Right, and GP is being saved now. > >>> diff --git a/sysdeps/arc/bits/setjmp.h b/sysdeps/arc/bits/setjmp.h >>> new file mode 100644 >>> index 000000000000..6bba95fafe0f >>> --- /dev/null >>> +++ b/sysdeps/arc/bits/setjmp.h >>> @@ -0,0 +1,26 @@ >>> +/* Define the machine-dependent type `jmp_buf'. ARC version. >> >> I think current trend is to just use apostrophe instead of the grave >> accent in such cases. > > Ok changed. > >>> +reloc_index (uintptr_t plt0, uintptr_t pltn, size_t size) >>> +{ >>> + unsigned long int idx = pltn - plt0; >>> + >>> + /* PLT trampoline is 16 bytes. */ >> >> Double space after period. > > Fixed. > >>> +#define _JMPBUF_UNWINDS_ADJ(_jmpbuf, _address, _adj) \ >>> + ((uintptr_t) (_address) - (_adj) < (uintptr_t) (_jmpbuf_sp (_jmpbuf) - (_adj))) >>> + >>> +/* We use the normal longjmp for unwinding. */ >>> +#define __libc_unwind_longjmp(buf, val) __libc_longjmp (buf, val) >> >> Ok. As a side note teh jmpbuf-unwind.h is candidate for some consolidation >> (the same macros are replicated in each architecture). > > OK. >