From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from black.elm.relay.mailchannels.net (black.elm.relay.mailchannels.net [23.83.212.19]) by sourceware.org (Postfix) with ESMTPS id E7B883890423; Wed, 23 Dec 2020 10:20:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E7B883890423 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 771F910199B; Wed, 23 Dec 2020 10:20:47 +0000 (UTC) Received: from pdx1-sub0-mail-a1.g.dreamhost.com (100-96-5-6.trex.outbound.svc.cluster.local [100.96.5.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7B001102057; Wed, 23 Dec 2020 10:20:46 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a1.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.11); Wed, 23 Dec 2020 10:20:47 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Reign-Macabre: 06f6961a5e05f111_1608718846833_2221349441 X-MC-Loop-Signature: 1608718846833:2475285687 X-MC-Ingress-Time: 1608718846833 Received: from pdx1-sub0-mail-a1.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a1.g.dreamhost.com (Postfix) with ESMTP id 377BF7F0A3; Wed, 23 Dec 2020 02:20:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=0PfaAX fHG01/5kv/ozL68NW0XoE=; b=W3D27spERkprAObNM52uObJPx8TnZk4kdtyAz/ R+x4OPUgf5AGW8mQg9AiHoS5NTMlGipDYJ0H9iF/iV5B/BEj9gS1bbESJhEL0RnP IlD/ZxjiHOxt5GZY66B8uD3d52vPygSrSyA/h8tLRW86+gMjn36als2qEmetErDL cfW2Y= Received: from [192.168.1.111] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a1.g.dreamhost.com (Postfix) with ESMTPSA id 472DE7F0A4; Wed, 23 Dec 2020 02:20:41 -0800 (PST) Subject: Re: [PATCH 5/5] x86 long double: Add tests for pseudo normal numbers To: Siddhesh Poyarekar , Adhemerval Zanella , libc-alpha@sourceware.org Cc: fweimer@redhat.com, joseph@codesourcery.com References: <20201215141339.2684384-1-siddhesh@sourceware.org> <20201215141339.2684384-6-siddhesh@sourceware.org> X-DH-BACKEND: pdx1-sub0-mail-a1 From: Siddhesh Poyarekar Message-ID: <7bc285d3-c8ec-66ce-75a5-5acb84e78ab0@gotplt.org> Date: Wed, 23 Dec 2020 15:50:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Dec 2020 10:20:50 -0000 On 12/23/20 7:28 AM, Siddhesh Poyarekar via Libc-alpha wrote: > On 12/23/20 3:18 AM, Adhemerval Zanella via Libc-alpha wrote: >> >> >> On 15/12/2020 11:13, Siddhesh Poyarekar via Libc-alpha wrote: >>> Add some tests for fpclassify, isnanl, isinfl and issignaling. >>> --- >>> =C2=A0 sysdeps/x86/fpu/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0=C2=A0 3 +- >>> =C2=A0 sysdeps/x86/fpu/test-unnormal.c | 196 ++++++++++++++++++++++++= ++++++++ >>> =C2=A0 2 files changed, 198 insertions(+), 1 deletion(-) >>> =C2=A0 create mode 100644 sysdeps/x86/fpu/test-unnormal.c >>> >>> diff --git a/sysdeps/x86/fpu/Makefile b/sysdeps/x86/fpu/Makefile >>> index 600e42c3db..e77de56d14 100644 >>> --- a/sysdeps/x86/fpu/Makefile >>> +++ b/sysdeps/x86/fpu/Makefile >>> @@ -4,11 +4,12 @@ CPPFLAGS +=3D -I../soft-fp >>> =C2=A0 libm-support +=3D powl_helper >>> =C2=A0 tests +=3D test-fenv-sse test-fenv-clear-sse test-fenv-x87=20 >>> test-fenv-sse-2 \ >>> -=C2=A0=C2=A0=C2=A0=C2=A0 test-flt-eval-method-387 test-flt-eval-meth= od-sse >>> +=C2=A0=C2=A0=C2=A0=C2=A0 test-flt-eval-method-387 test-flt-eval-meth= od-sse test-unnormal >>> =C2=A0 CFLAGS-test-fenv-sse.c +=3D -msse2 -mfpmath=3Dsse >>> =C2=A0 CFLAGS-test-fenv-clear-sse.c +=3D -msse2 -mfpmath=3Dsse >>> =C2=A0 CFLAGS-test-fenv-sse-2.c +=3D -msse2 -mfpmath=3Dsse >>> =C2=A0 CFLAGS-test-flt-eval-method-387.c +=3D -fexcess-precision=3Dst= andard=20 >>> -mfpmath=3D387 >>> =C2=A0 CFLAGS-test-flt-eval-method-sse.c +=3D -fexcess-precision=3Dst= andard=20 >>> -msse2 \ >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -mfpmath=3D= sse >>> +CFLAGS-test-unnormal.c +=3D -fsignaling-nans -std=3Dc2x >>> =C2=A0 endif >> >> A possibility is to hookup this tests on >> math/libm-test-{fpclassify,isnan,isinf,issignaling}.inc using the new=20 >> define >> I suggested on the 4/5 part [1] so you can also check if no exceptions= =20 >> are being >> generated and errno is not set. >> >> It increases the tests coverage and avoid a arch-specific tests. >> >> [1] https://sourceware.org/pipermail/libc-alpha/2020-December/121004.h= tml >=20 > OK, it will need changes to the driver. >=20 I took a look at this and it looks like it will need a significant=20 amount of changes to the driver and test generation scripts, since these=20 numbers are not generated by the CPU. Would it be OK if I defer this to=20 later if we ever feel the need to add tests beyond test-unnormal? Siddhesh