public inbox for
 help / color / mirror / Atom feed
From: Joseph Myers <>
To: Jakub Jelinek <>
Subject: Re: [PATCH] v3: Use gcc __builtin_stdc_* builtins in stdbit.h if possible
Date: Mon, 29 Jan 2024 21:30:19 +0000 (UTC)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <ZbgWHFYdAGWJOHwi@tucnak>

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

On Mon, 29 Jan 2024, Jakub Jelinek wrote:

> Most of the other tests (except the tests for side-effects in arguments)
> have constant arguments and so can be folded very early during compilation,
> even the side-effects in arguments tests can be folded soon when optimizing,
> so these functions were just an attempt to make sure the macros can be
> compiled/linked when the arguments are certainly not known.
> But if you think it isn't worth checking that or if it is already tested by
> some other test, I can remove that.

I think the existing tests adequately cover non-constant arguments 
(non-constant unless you unroll the test loop and extract the arguments 
from a const array of structures then propagate from the variable storing 
them after loading from the array, that is).  What the existing tests 
don't actually cover for standard types (and this new test does cover) is 
constant arguments.

Note that as we're currently in release freeze for glibc 2.39, a new 
feature change such as this should probably only go in before 2.39 is 
released with the approval of Andreas K. Hüttel as release manager (while 
if going in after 2.39 is released, the new feature of unsigned __int128 / 
unsigned _BitInt support should get a NEWS entry for 2.40).

Joseph S. Myers

  reply	other threads:[~2024-01-29 21:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-20 18:04 [PATCH] " Jakub Jelinek
2024-01-20 23:27 ` Joseph Myers
2024-01-22  9:19   ` [PATCH] v2: " Jakub Jelinek
2024-01-22 17:58     ` Joseph Myers
2024-01-26 10:12       ` [PATCH] v3: " Jakub Jelinek
2024-01-29 21:07         ` Joseph Myers
2024-01-29 21:18           ` Jakub Jelinek
2024-01-29 21:30             ` Joseph Myers [this message]
2024-01-29 22:10               ` [PATCH] v4: " Jakub Jelinek
2024-01-30  0:28                 ` Andreas K. Huettel
2024-01-31 18:03                   ` Joseph Myers
2024-02-01 10:12                 ` Mark Wielaard
2024-02-01 10:23                   ` Mark Wielaard
2024-02-01 10:33                   ` [PATCH] Fix up stdbit.texi Jakub Jelinek
2024-02-01 11:05                     ` Mark Wielaard
2024-02-01 14:42                     ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).