From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122981 invoked by alias); 20 May 2017 21:03:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 122971 invoked by uid 89); 20 May 2017 21:03:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:209.85.216.195, Hx-spam-relays-external:209.85.216.195 X-HELO: mail-qt0-f195.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=8ZHdX2+kjhnex+W5zHDEgzMzuxwqTQ+Xgq30dRKasHI=; b=au1fMeSIG+za0GGxy3sjalMb3J/BrXC0HvBFgNAb40wQAGF3bx/FQkec2SSDr2KVA6 44mkzJZSAFnVF9/pPGaWmiy8dlY1uuQ4pmbUCgf94wt+KK/T2N84LVOQThWRTLgmTVML WvsFatI71ZCF+pZIbpiC9qOHdzOC/xCVV9nOW8H69CgBEFaftMfwg59lUavemE2njzv8 4Dk5Z6Pox57I5I0QyEpyzjbjhS332+uNPAg6IQVf+IuiO79Tu8w0AvRpTBVBz4/VFy07 N7filNxE5bRRZ98ixrP35pLb40ljXEd2Syia3BYr99SNwJkZzEfVI8Ugj/IAJsvhGjQJ mGBA== X-Gm-Message-State: AODbwcDyN3sbmE+bxfja7SqF0MEZ7toR/A+/R3So/lO955SjBmSKtcaY 8aRzFUldyQi5BpCcltM= X-Received: by 10.200.40.193 with SMTP id j1mr16038009qtj.186.1495314217509; Sat, 20 May 2017 14:03:37 -0700 (PDT) Subject: Re: [PATCH 04/10] Convert signal.h from __need macros to bits/types/ headers. To: Joseph Myers References: <20170509154103.11973-1-zackw@panix.com> <20170509154103.11973-5-zackw@panix.com> Cc: libc-alpha@sourceware.org From: Zack Weinberg Message-ID: <7bcf8dc2-4e37-d794-9063-ebc33d68e6ca@panix.com> Date: Sat, 20 May 2017 21:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00630.txt.bz2 On 05/17/2017 01:40 PM, Joseph Myers wrote: > On Tue, 9 May 2017, Zack Weinberg wrote: > >> Internal code that wants to manipulate signal masks must now include >> (which is not installed) and should be aware that > > As noted, should be renamed to something not in the bits/ namespace for > installed headers. (signal/sigsetops.h already exists, so that shouldn't > be the name.) It turns out that nothing in signal/sigsetops.h is used by anything anymore, so I have removed it and recycled the name. >> +/* These macros needn't check for a bogus signal number; >> + checking is done in the non-__ versions. */ >> +# define __sigismember(set, sig) \ >> + (__extension__ ({ \ >> + __sigset_t __mask = __sigmask (sig); \ >> + (set) & mask ? 1 : 0; \ > > You're referencing plain "mask" here, when the local variable is __mask. Good catch, thanks. This is a problem with generic code that's not used on any testable platform. > Indentation messed up here (was using tabs, changed to spaces). Likewise > elsewhere in this patch). Fixed. > Include 2017 in copyright dates. Fixed. > Should be GLIBC_2_26, as the version where these were obsoleted. (As > there weren't any new ports in 2.25, having the wrong version here doesn't > actually break any ABIs.) Fixed. This patch has been kicking around my local git repo for quite a while - it would have been correct when I wrote it. >> diff --git a/sysdeps/unix/sysv/linux/bits/types/siginfo_t.h b/sysdeps/unix/sysv/linux/bits/types/siginfo_t.h > >> + /* SIGSYS. */ >> + struct >> + { >> + void *_call_addr; /* Calling user insn. */ >> + int _syscall; /* Triggering system call number. */ >> + unsigned int _arch; /* AUDIT_ARCH_* of syscall. */ >> + } _sigsys; > > This (and the macros using it) needs to be conditional. ia64 (only) lacks > this part of siginfo_t. How inconvenient. Fixed. >> +/* Additional fields for _sifields._sigfault. */ >> +#define __SI_SIGFAULT_ADDL_2 \ >> + struct \ >> + { \ >> + void *_lower; \ >> + void *_upper; \ >> + } si_addr_bnd; > > Remark (not needing fixing for the patch to go in, though if fixed there > would be no need for __SI_SIGFAULT_ADDL_2): this is in fact part of > siginfo_t in the Linux kernel for all architectures rather than just > x86-specific (as is the more recent _pkey there), so logically should > probably be so in glibc as well, though I don't know if it's *used* by the > kernel on any other architectures or if it's entirely MPX-specific. I went ahead and added this for all architectures (and _pkey as well). zw