From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CD4F93858D3C for ; Mon, 24 Jan 2022 21:59:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD4F93858D3C Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-516-gcVIKC7OPoaU9xQUEc1YrQ-1; Mon, 24 Jan 2022 16:59:31 -0500 X-MC-Unique: gcVIKC7OPoaU9xQUEc1YrQ-1 Received: by mail-qt1-f200.google.com with SMTP id a6-20020ac844a6000000b002cf3968d32aso2933592qto.1 for ; Mon, 24 Jan 2022 13:59:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=20d5G1YFSHorBdw8fBipzKqcCJ0hs9NPDllclstVEzY=; b=BsHkiT3A32NA4nfJWq4ZJepNa0jSwAu502VXvwj4a1lJ5Hd+3UfccWR00+FbYh4M1d G1M5xWq+ZtJof6G9SwvAYr0aToFs1FNlKAt70npAUBeeWxrGlf7CXZrrgBJK80s6AXEI zwUJJMY5iyOJ80vEBo+1d6cqSuaVwV9rUEVT8NA+3jmQ5ge6lewPBPNZl3j9AhuoBMCo Lp0b01qVVycWvJFq+kAlkS6cC6eyaEjqQcEgDxuWd1bhYj+P0ahwb2uccMf/mrRly3By QTc9tjDE8HqCghXtcbpg8Y0BOhIY+dDMWOVYzbxoRI25xmgtRRBQWxfkoSm/ro5bQZbF EKqA== X-Gm-Message-State: AOAM533f4v7eWmyyao876fLAnj6F68MMMGD7ZzVCZUt5FZ1+KwzpUw6J 68Gr78s71S4KiPFuCLg/AVvzI0ZbEKvx4peXFbARKb52mFZec/4wW4UZ+F7NpHk6GFbnyHbtRqn ugRWd42BB1v1ftb3YOor0 X-Received: by 2002:ac8:7d88:: with SMTP id c8mr12164614qtd.135.1643061570225; Mon, 24 Jan 2022 13:59:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTIHALEYSWGsJeDjEQFx03vlWQKwWr+j28p+XdtuujQ6gHU+qfPcnJUu9fl7wDv5VSrKvBmg== X-Received: by 2002:ac8:7d88:: with SMTP id c8mr12164599qtd.135.1643061569874; Mon, 24 Jan 2022 13:59:29 -0800 (PST) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id h9sm8696639qkn.101.2022.01.24.13.59.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 13:59:29 -0800 (PST) Message-ID: <7d45acad-0065-461d-93b7-3d4e68ed39c2@redhat.com> Date: Mon, 24 Jan 2022 16:59:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] glibc [BZ #27781] To: Ilyahoo Proshel , libc-alpha@sourceware.org References: <20220124180749.1592069-1-ip@ipshel.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220124180749.1592069-1-ip@ipshel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2022 21:59:37 -0000 On 1/24/22 13:07, Ilyahoo Proshel wrote: > Test case for rif_MA [BZ #27781] Thanks for the submission! Please adjust the subject to reflect the contribution. I would suggest "Add rif_MA locale [BZ #27781]" The CI/CD framework shows this patch does not pass regression testing: https://patchwork.sourceware.org/project/glibc/patch/20220124180749.1592069-1-ip@ipshel.com/ Specifically it looks like the sorting tests fail given the inputs you've provided. Did you make sure to run 'make check' to look for errors? The failures are here: rif_MA.UTF-8 collate-test FAIL rif_MA.UTF-8 xfrm-test FAIL You will need to review these and determine why the characters don't sort as expected by the data you provided. > --- > .../strcoll-inputs/filelist#en_US.UTF-8 | 1 + > .../strcoll-inputs/lorem_ipsum#rif_MA.UTF-8 | 15 ++ > locale/iso-639.def | 1 + > localedata/Makefile | 2 + > localedata/SUPPORTED | 2 + > localedata/locales/rif_MA | 161 ++++++++++++++++++ > localedata/rif_MA.UTF-8.in | 55 ++++++ > 7 files changed, 237 insertions(+) > create mode 100644 benchtests/strcoll-inputs/lorem_ipsum#rif_MA.UTF-8 > create mode 100644 localedata/locales/rif_MA > create mode 100644 localedata/rif_MA.UTF-8.in > > diff --git a/benchtests/strcoll-inputs/filelist#en_US.UTF-8 b/benchtests/strcoll-inputs/filelist#en_US.UTF-8 > index 197700ec90..ab9e2fc3b1 100644 > --- a/benchtests/strcoll-inputs/filelist#en_US.UTF-8 > +++ b/benchtests/strcoll-inputs/filelist#en_US.UTF-8 > @@ -11478,6 +11478,7 @@ en_ZM > de_DE@euro > fr_LU@euro > sw_KE > +rif_MA > id_ID > is_IS > gez_ER@abegede > diff --git a/benchtests/strcoll-inputs/lorem_ipsum#rif_MA.UTF-8 b/benchtests/strcoll-inputs/lorem_ipsum#rif_MA.UTF-8 > new file mode 100644 > index 0000000000..66f1e66c01 > --- /dev/null > +++ b/benchtests/strcoll-inputs/lorem_ipsum#rif_MA.UTF-8 > @@ -0,0 +1,15 @@ > +Yuffu-d Arrif iḍennaḍ x uneɣmis n tmettant n Prof. Dr. Hassan Benɛaqiya, Lexbar-a yejja ij n uxeyyeq d ameqqran deg imeddukal d imeḥḍaren-nnes. > + > +Benɛaqiya i yellan d aselmad n tsekla Tafransist di tesdawit n Selwan, mamec i t-tuɣa zeg yewdan i yessersen ddsas i tebridt n tɣuriwin Timaziɣin di tesdawit n Wejda aseggas n 2007. Aked uyenni, issers ddsas i tebridt n tɣuriwin Timaziɣin di tesdawit n Selwan deg iseggusa imeggura. Ɛawed, ibedd ad yili x yixef n umaster n tutlayt Tamaziɣt di tɣiwant-a s ixef-nnes. > + > +Prof. Dr. Hasan Benɛaqiya, yettwaḥsab zeg ipilaren n Tmaziɣt di Arif, la s trezzutin-nnes, la s tira-nnes. Amek yettwassen deg iger n tussna Tamaziɣt s ufus-nnes yessiɣen lebda ad iɛawen imeḥḍaren-nnes, d qaε wi icerken amnus. > + > +Deg ussan yeɛdun yemser waṭṭas n wawal jer Irifiyyen belli Aliman, ixes ad yerẓem i ixeddamen zi barra. Niɣ mamek qqarn s wawal n leqhawi: Aliman ad yerẓem i lekwaɣeḍ. Deg umegraḍ anekkes afray x uneɣmis‑a (Lexbar), a nessen tidet, deg ixarriqen. > + > +Pulitik n wenɛarq deg uliman tella zeg wami yella Uliman, deg ineggura‑ya n iseggusa, tedwel d ijj n ṭṭema labud a x‑as yili wawal melmi reccḥen i lintixab. Igrawen marra tteggen‑tt deg uprugram‑nsen, Jer wenni yexsen imenneɛraq, d wenni yexsen ad yazzel x yinni da, marra qat ɣer‑sen d ij n lkartet ttiraren zeg‑sen. > + > +Lḥukuma n useggwasa, tettwassen s “Ampel” , i yexsen ad yini sṭup n yebriden, izegzawen n twennaḍt (Envirement), Spd (Agraw asuṣyal, azeggwaɣ) FDP (ilibiraliyyen, awraɣ), Igrawen‑a msafaqen x waṭṭas n tmeslayin, munen mani wer yettmun ḥed, minzi lxezrat‑nsen temsebḍa deg waṭṭas n tmeslayin. Zi min xef firmarn, d lqanun amaynu n wenɛarq.Kunṭra‑ya, tiwi‑asen‑dd aṭṭas n ukritik zeg igrawen‑nneɣni, d waṭṭasn Ilimaniyyen, > +Aṭṭas n imenneɛraq deg iseggusa yeɛdun, inni d irewlen zeg iɣewwiɣen d umquṭṭes, niɣ iḍriben, d yenni wer ɣer llin lekwaɣeḍ. Ssa d usawen ad x‑asen yehwen lḥal. Aṭaf zemmern ad ggen lekwaɣeḍ, wer ttɣimin mkul twalat tticen‑asen sett‑chur niɣ d ɛam n visa waha. Min isseqsiḥen afsay deg wamun aliman, xsen ad teksen. Iwdan‑a ad yedwel ɣer‑sen lḥeq ad xedmen. A ten‑ɛayaren s lekwaɣeḍ umi semman “lekwaɣeḍ n ujarreb”. Di lweqt nni di ten‑ɣa‑jarrben, ixessa ad ḍebbren x uzellif‑nsen, ad afen lxedmet. > + > +Kritik: Agraw n merkel (CDU), ittwala wa d acejjeɛ x ukular ɣer Uliman, wer yettɣimi manaya deg yenni da waha, maca ad mmernin inneɣni. > +Tamunt n yegrawen iḥekkmen aliman, xsen ad ggen ij n usistim d jjdid i ixeddamen yexsen ad adfen zi barra ad xedmen zeg Uliman. Xsen ad ggen ij n usistim am Green Card n Kanada. Asistim yebna x tneqqiḍin, Maca deg Uliman ɛad wer nnin man tneqqiḍin (ccuruṭ) i xef ɣa yebna usistim‑a. Zeg ij n uɣeẓḍis nneɣni, xsen ad shewnen asemquddi n ddiplumat n barra deg Uliman. > diff --git a/locale/iso-639.def b/locale/iso-639.def > index 926aebada0..3e07eca967 100644 > --- a/locale/iso-639.def > +++ b/locale/iso-639.def > @@ -399,6 +399,7 @@ DEFINE_LANGUAGE_CODE3 ("Quechua, Southern", quz, quz) > DEFINE_LANGUAGE_CODE ("Raeto-Romance", rm, roh, roh) > DEFINE_LANGUAGE_CODE3 ("Rajasthani", raj, raj) > DEFINE_LANGUAGE_CODE3 ("Rapanui", rap, rap) > +DEFINE_LANGUAGE_CODE3 ("Tarifit", rif, rif) > DEFINE_LANGUAGE_CODE3 ("Rarotongan", rar, rar) > DEFINE_LANGUAGE_CODE3 ("Romance (Other)", roa, roa) > DEFINE_LANGUAGE_CODE ("Romanian", ro, ron, rum) > diff --git a/localedata/Makefile b/localedata/Makefile > index 79db713925..d601626ffb 100644 > --- a/localedata/Makefile > +++ b/localedata/Makefile > @@ -98,6 +98,7 @@ test-input := \ > pl_PL.UTF-8 \ > ps_AF.UTF-8 \ > ro_RO.UTF-8 \ > + rif_MA.UTF-8 \ > ru_RU.UTF-8 \ > sah_RU.UTF-8 \ > sc_IT.UTF-8 \ > @@ -268,6 +269,7 @@ LOCALES := \ > pl_PL.UTF-8 \ > ps_AF.UTF-8 \ > ro_RO.UTF-8 \ > + rif_MA.UTF-8 \ > ru_RU.UTF-8 \ > sah_RU.UTF-8 \ > sc_IT.UTF-8 \ > diff --git a/localedata/SUPPORTED b/localedata/SUPPORTED > index d768aa4795..ca39131596 100644 > --- a/localedata/SUPPORTED > +++ b/localedata/SUPPORTED > @@ -378,6 +378,8 @@ pt_PT/ISO-8859-1 \ > pt_PT@euro/ISO-8859-15 \ > quz_PE/UTF-8 \ > raj_IN/UTF-8 \ > +rif_MA/UTF-8 \ > +rif_MA.UTF-8/UTF-8 \ > ro_RO.UTF-8/UTF-8 \ > ro_RO/ISO-8859-2 \ > ru_RU.KOI8-R/KOI8-R \ > diff --git a/localedata/locales/rif_MA b/localedata/locales/rif_MA > new file mode 100644 > index 0000000000..526b1b87fd > --- /dev/null > +++ b/localedata/locales/rif_MA > @@ -0,0 +1,161 @@ > +comment_char % > +escape_char / > + > +% This file is part of the GNU C Library and contains locale data. > +% The Free Software Foundation does not claim any copyright interest > +% in the locale data contained in this file. The foregoing does not > +% affect the license of the GNU C Library as a whole. It does not > +% exempt you from the conditions of the license if your use would > +% otherwise be governed by that license. > + > +% Tarifit language locale for Morocco > +% Contact: Ilyahoo Proshel > +% Email: ip@ipshel.com > + > + > +LC_IDENTIFICATION > +title "Tarifit locale for Morocco" > +source "" > +contact "Ilyahoo Proshel" > +email "ip@ipshel.com" > +language "Tarifit" > +territory "Morocco" > +revision "1.0" > +date "2020-04-26" > + > +category "i18n:2012";LC_IDENTIFICATION > +category "i18n:2012";LC_CTYPE > +category "i18n:2012";LC_COLLATE > +category "i18n:2012";LC_TIME > +category "i18n:2012";LC_NUMERIC > +category "i18n:2012";LC_MONETARY > +category "i18n:2012";LC_MESSAGES > +category "i18n:2012";LC_PAPER > +category "i18n:2012";LC_NAME > +category "i18n:2012";LC_ADDRESS > +category "i18n:2012";LC_TELEPHONE > +category "i18n:2012";LC_MEASUREMENT > +END LC_IDENTIFICATION > + > +LC_CTYPE > +copy "i18n" > + > +translit_start > +include "translit_combining";"" > +translit_end > +END LC_CTYPE > + > +LC_COLLATE > +copy "iso14651_t1" > +END LC_COLLATE > + > +LC_TIME > +abday "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "" > +day "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "" > +abmon "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "" > +mon "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "";/ > + "" > +d_t_fmt "%a %d %b %Y %T %Z" > +d_fmt "%d//%m//%y" > +t_fmt "%T" > +am_pm "";"" > +t_fmt_ampm "" > +date_fmt "%a %e %b %Y %H:%M:%S %Z" > +week 7;19971130;4 > +first_weekday 2 > +END LC_TIME > + > +LC_NUMERIC > +decimal_point "." > +thousands_sep "" > +grouping 3 > +END LC_NUMERIC > + > +LC_MONETARY > +int_curr_symbol "" > +currency_symbol "" > +mon_decimal_point "." > +mon_thousands_sep "" > +mon_grouping 3;3 > +positive_sign "" > +negative_sign "-" > +int_frac_digits 2 > +frac_digits 2 > +p_cs_precedes 1 > +p_sep_by_space 0 > +n_cs_precedes 0 > +n_sep_by_space 0 > +p_sign_posn 1 > +n_sign_posn 1 > +END LC_MONETARY > + > +LC_MESSAGES > +yesexpr "^[]" > +noexpr "^[]" > +yesstr "" > +nostr "" > +END LC_MESSAGES > + > +LC_PAPER > +copy "i18n" > +END LC_PAPER > + > +LC_NAME > +name_fmt "%g%t%f" > +END LC_NAME > + > +LC_ADDRESS > +postal_fmt "%f%N%a%N%d%N%b%N%s %h %e %r%N%z %T%N%c%N" > +country_name "" > +country_ab2 "" > +country_ab3 "" > +country_num 504 > +country_car "" > +lang_term "" > +lang_lib "" > +END LC_ADDRESS > + > +LC_TELEPHONE > +tel_int_fmt "+%c%l" > +tel_dom_fmt "0%l" > +int_select "00" > +int_prefix "212" > +END LC_TELEPHONE > + > +LC_MEASUREMENT > +copy "i18n" > +END LC_MEASUREMENT > + > diff --git a/localedata/rif_MA.UTF-8.in b/localedata/rif_MA.UTF-8.in > new file mode 100644 > index 0000000000..1544dda31c > --- /dev/null > +++ b/localedata/rif_MA.UTF-8.in > @@ -0,0 +1,55 @@ > +a > +A > +aa > +ɛ > +Ɛ > +ɛɛ > +b > +B > +bb > +c > +C > +cc > +d > +D > +dd > +ḍ > +Ḍ > +ḍḍ > +g > +G > +gg > +ɣ > +Ɣ > +ɣɣ > +h > +H > +hh > +ḥ > +Ḥ > +ḥḥ > +q > +Q > +qq > +r > +R > +rr > +s > +S > +ss > +ṣ > +Ṣ > +ṣṣ > +t > +T > +tt > +ṭ > +Ṭ > +ṭṭ > +z > +Z > +zz > +ẓ > +Ẓ > +ẓẓ > +ʷ -- Cheers, Carlos.