From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-87798-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 117782 invoked by alias); 4 Dec 2017 19:23:13 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 117773 invoked by uid 89); 4 Dec 2017 19:23:12 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=rights
X-HELO: zimbra.cs.ucla.edu
Subject: Re: [PATCH] support: Add TEST_COMPARE macro
To: Florian Weimer <fweimer@redhat.com>,
 Siddhesh Poyarekar <siddhesh@gotplt.org>,
 GNU C Library <libc-alpha@sourceware.org>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
References: <8d63a2dc-f9e9-acaa-5ac5-ac5c4fbd6c9f@redhat.com>
 <8c399cde-3093-0195-a89a-ca230540cffb@gotplt.org>
 <8339a519-935a-019c-4a8f-798e37f6f346@redhat.com>
 <5c5fbfc4-0077-22ad-1fd4-53388acaf1e7@cs.ucla.edu>
 <c51c9a5a-29f2-6461-3a53-f91868b222ca@redhat.com>
 <96692ad0-180c-6e7c-79c8-e5c96d79e34c@cs.ucla.edu>
 <7e965c74-8113-72b9-276c-baa031df007e@redhat.com>
 <24bc9987-5af7-6e8a-9b3d-aeae4a45f60a@cs.ucla.edu>
 <aa669215-dd46-18c8-07bb-94a67092fc73@redhat.com>
 <72d1c0c0-44b3-69f7-7630-0d47be285a30@cs.ucla.edu>
 <f0593826-1721-d424-905c-6755b813bbf7@redhat.com>
 <2b76ec51-8dac-2fc9-ba32-512fdfbec2ff@cs.ucla.edu>
 <17e4d3db-8a69-e50c-07b1-71e1e8739d9d@redhat.com>
 <742d0fab-b17e-a7f5-62df-d87510454aa4@cs.ucla.edu>
 <c71a4c4e-764a-9756-bcc5-fe3e6369af6f@redhat.com>
 <b71faa1c-b9e2-29e3-dc69-7d366f69e4ff@cs.ucla.edu>
 <d5c497b6-90fb-2949-4d3b-7fa47899abb5@redhat.com>
From: Paul Eggert <eggert@cs.ucla.edu>
Message-ID: <7d7a1b49-7c7c-64f5-5518-adac62571202@cs.ucla.edu>
Date: Mon, 04 Dec 2017 19:23:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <d5c497b6-90fb-2949-4d3b-7fa47899abb5@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-12/txt/msg00098.txt.bz2

On 12/04/2017 08:35 AM, Florian Weimer wrote:
> +      __left_converts_to_right = __left_is_unsigned                     \
> +        && sizeof (__left_value) < sizeof (__right_value),              \

Thanks, this implementation looks good. Two minor style issues. First, 
please indent this decl according to the usual glibc style, where 
multiline expressions are parenthesized (or perhaps you can put the " = 
" on the next line). Second, I suggest changing the name from 
"__left_converts_to_right" to "__unsigned_left_converts_to_wider", as 
this more-accurately describes the expression (as there are cases where 
the left's value is converted to the right's type but 
__left_converts_to_right is false). Similarly for 
__right_converts_to_left of course.