[PATCH] libio: Remove comment in <stdio.h>

[PATCH] libio: Remove comment in <stdio.h>

[Jonny Grant]

[-- Attachment #1: Type: text/plain, Size: 77 bytes --]

Hello

Please find attached patch created against latest git.

Regards, Jonny

[-- Attachment #2: 0001-Remove-C-comment.patch --]
[-- Type: text/x-patch, Size: 717 bytes --]

From fad8ca3bb29bb1da7167677e9fe14185aab103ba Mon Sep 17 00:00:00 2001
From: Jonathan Grant <jg@jguk.org>
Date: Sat, 28 Oct 2023 23:34:31 +0100
Subject: [PATCH] libio: Remove comment in <stdio.h>

Signed-off-by: Jonathan Grant <jg@jguk.org>
---
 libio/stdio.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libio/stdio.h b/libio/stdio.h
index a640e9beb5..ac36a43f74 100644
--- a/libio/stdio.h
+++ b/libio/stdio.h
@@ -1,5 +1,4 @@
-/* Define ISO C stdio on top of C++ iostreams.
-   Copyright (C) 1991-2023 Free Software Foundation, Inc.
+/* Copyright (C) 1991-2023 Free Software Foundation, Inc.
    Copyright The GNU Toolchain Authors.
    This file is part of the GNU C Library.
 
-- 
2.39.2

Re: [PATCH] libio: Remove comment in <stdio.h>

[Adhemerval Zanella Netto]

On 28/10/23 19:37, Jonny Grant wrote:
> Hello
> 
> Please find attached patch created against latest git.
> 
> Regards, Jonny

For new header the current practice is to add a one-line comment to
describe it, so I think it would be better to follow it on old header
changes.

Re: [PATCH] libio: Remove comment in <stdio.h>

[Jonny Grant]

On 30/10/2023 12:36, Adhemerval Zanella Netto wrote:
> 
> 
> On 28/10/23 19:37, Jonny Grant wrote:
>> Hello
>>
>> Please find attached patch created against latest git.
>>
>> Regards, Jonny
> 
> For new header the current practice is to add a one-line comment to
> describe it, so I think it would be better to follow it on old header
> changes.

Hi Adhemerval

May I clarify, this file has this after the copyright & license. I considered that was enough. Do you mean I should put that at the top of the file as well?

/*
 *	ISO C99 Standard: 7.19 Input/output	<stdio.h>
 */

With kind regards, Jonny

Re: [PATCH] libio: Remove comment in <stdio.h>

[Adhemerval Zanella Netto]

On 23/11/23 16:54, Jonny Grant wrote:
> 
> 
> On 30/10/2023 12:36, Adhemerval Zanella Netto wrote:
>>
>>
>> On 28/10/23 19:37, Jonny Grant wrote:
>>> Hello
>>>
>>> Please find attached patch created against latest git.
>>>
>>> Regards, Jonny
>>
>> For new header the current practice is to add a one-line comment to
>> describe it, so I think it would be better to follow it on old header
>> changes.
> 
> Hi Adhemerval
> 
> May I clarify, this file has this after the copyright & license. I considered that was enough. Do you mean I should put that at the top of the file as well?
> 
> /*
>  *	ISO C99 Standard: 7.19 Input/output	<stdio.h>
>  */
> 
> With kind regards, Jonny

Yes.  Our current practice is always add one-line comment on a new file, even
the installed ones, with a brief description. 

Re: [PATCH] libio: Update comment in <stdio.h>

[Jonny Grant]

[-- Attachment #1: Type: text/plain, Size: 68 bytes --]

Adhemerval,

Updated patch attached for review.

Kind regards, Jonny

[-- Attachment #2: 0001-Update-description-comment-stdio.h.patch --]
[-- Type: text/x-patch, Size: 660 bytes --]

From 76efde6ddde9b9d299f6d4116ac36af5fcd0bdd4 Mon Sep 17 00:00:00 2001
From: Jonathan Grant <jg@jguk.org>
Date: Fri, 24 Nov 2023 12:48:07 +0000
Subject: [PATCH] libio: Update comment in <stdio.h>

---
 libio/stdio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libio/stdio.h b/libio/stdio.h
index a640e9beb5..f3fccb4644 100644
--- a/libio/stdio.h
+++ b/libio/stdio.h
@@ -1,4 +1,4 @@
-/* Define ISO C stdio on top of C++ iostreams.
+/* ISO C99 Standard: 7.19 Input/output	<stdio.h>
    Copyright (C) 1991-2023 Free Software Foundation, Inc.
    Copyright The GNU Toolchain Authors.
    This file is part of the GNU C Library.
-- 
2.40.1