From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) by sourceware.org (Postfix) with ESMTPS id 5C165385C410 for ; Wed, 13 Jul 2022 03:43:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C165385C410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xen0n.name DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1657683793; bh=kY0UZ+ojvoT73V3C4lqRhJbJKjl9m/NbHFWBToNDeCM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FW4yI54INic7kpj0j//XscN4u1/2pZMBW1udxBP6kq7Z5DNQ+Z/vX5CgyE6f85Isp bW6s9qJEV29nodQnV4Ei11YriEB729GxDUbFrwQ2MXJeQdQ24YgQlv+h8PWhLK83b9 8nOygOKfdMUW+cLvlwc6AAx/oswP2APSJWmH4r/M= Received: from [100.100.57.190] (unknown [220.248.53.61]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 6CAD26010B; Wed, 13 Jul 2022 11:43:13 +0800 (CST) Message-ID: <7eabd567-a222-13ad-349e-ab9ea1b4a29f@xen0n.name> Date: Wed, 13 Jul 2022 11:43:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:104.0) Gecko/20100101 Thunderbird/104.0a1 Subject: Re: [PATCH v6 11/13] LoongArch: Build Infastructure To: Xi Ruoyao , caiyinyu , libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.or, joseph_myers@mentor.com References: <20220708065255.2316410-1-caiyinyu@loongson.cn> <20220708065255.2316410-12-caiyinyu@loongson.cn> Content-Language: en-US From: WANG Xuerui In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 03:43:20 -0000 On 2022/7/13 11:07, Xi Ruoyao wrote: > On Fri, 2022-07-08 at 14:52 +0800, caiyinyu wrote: >> grlen=`$CC $CFLAGS $CPPFLAGS -E -dM -xc /dev/null | sed -n 's/^#define __loongarch_grlen \(.*\)/\1/p'` > I suggest to use "__loongarch_lp64" for checking ABI grlen. Consider: > > "gcc -march=la464 -mabi=ilp32d ..." > > Once ILP32 ABIs are available, will __loongarch_grlen be 64 or 32 in > this case, where the hardware has 64-bit registers but the ABI uses them > as 32-bit? Our documentation is not clear about this question and > currently we understand __loongarch_grlen as hardware GR length instead > of the register length used in ABI [1]. > > [1]:https://github.com/loongson/LoongArch-Documentation/pull/28#discussion_r917364055 > > OTOH if you think "we should define __loongarch_grlen as the register > length for ABI, irrelevant to the hardware", you need to inform your > colleagues to clarify it in the doc. To my intuition it's the hardware GRLEN, but thinking about it harder, there is indeed ambiguity. Some clarification would be useful here. (BTW, Yinyu, could you keep me CC-ed when sending your next revisions? I'd like to take a quick review to ensure there are as few historical warts as possible when the patchset get updated.)