From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 2AF163854804 for ; Tue, 16 Mar 2021 16:31:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2AF163854804 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12GGRAOV130370; Tue, 16 Mar 2021 12:31:01 -0400 Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 37ap2tkxjw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Mar 2021 12:31:01 -0400 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 12GGUDXR014531; Tue, 16 Mar 2021 16:30:59 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma05fra.de.ibm.com with ESMTP id 378n189kms-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 16 Mar 2021 16:30:59 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 12GGUerT38011154 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Mar 2021 16:30:40 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EE9984204B; Tue, 16 Mar 2021 16:30:56 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B81BA42045; Tue, 16 Mar 2021 16:30:56 +0000 (GMT) Received: from li-ab9d22cc-354d-11b2-a85c-e984af76f811.ibm.com (unknown [9.171.15.233]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 16 Mar 2021 16:30:56 +0000 (GMT) Subject: Re: [PATCH] Don't test nanoseconds for non-LFS interface in io/tst-stat.c To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20210316135612.1400708-1-stli@linux.ibm.com> From: Stefan Liebler Message-ID: <7eb4bf10-0ce2-03cd-d50f-f6bc0c8f4129@linux.ibm.com> Date: Tue, 16 Mar 2021 17:30:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-16_05:2021-03-16, 2021-03-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 suspectscore=0 priorityscore=1501 spamscore=0 mlxscore=0 phishscore=0 clxscore=1015 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103160106 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 16:31:04 -0000 On 16/03/2021 15:24, Adhemerval Zanella wrote: > > > On 16/03/2021 10:56, Stefan Liebler wrote: >> Both new tests io/tst-stat and io/tst-stat-lfs (_FILE_OFFSET_BITS=64) >> are comparing the nanosecond fields with the statx result. Unfortunately >> e.g. on s390(31bit) those fields are always zero if old KABI with non-LFS >> support is used. With _FILE_OFFSET_BITS=64 stat is using statx internally. > > This might also happens for LFS interface if statx is not supported by the > kernel, since the LFS call will fall back to the use the stat syscall that > has this issue. > > Maybe it would be better to make it an internal tests and add a flag > somewhere to just disable it for s390-32. > gcc is setting the macros __s390x__ and __s390__ on s390x(64bit), but only __s390__ on s390(31bit). Thus I can detect s390(31bit) at compile-time via "#if" and disable the nanoseconds checks on s390(31bit) at all and run it on all other cases. Then I don't need to make the test an internal test and don't need special flags. If this is okay for you, I will prepare a further patch (also with a different subject). Thanks, Stefan