From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by sourceware.org (Postfix) with ESMTPS id 91BBC3856091 for ; Mon, 31 Oct 2022 18:32:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 91BBC3856091 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-12c8312131fso14394603fac.4 for ; Mon, 31 Oct 2022 11:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=TkHWdDmgs+q/91rQHaC7OH2axrzghFStmICRpgH3ZCM=; b=PUa96vt3tbYTIaRjO34MGRLuzpEX77qxu4Ybfdl/8FpaTpcJ8BLhsoS4NlDpuVJcZO dsyUxfYhNA4yazUfsKWd7LZn9zCQKTvOxt60p97qNCdmLSGzyBbBsk3Qtqlc1wjliBo/ MO0KbL/2IAR3plkKhd3KX4EmqYWNJa+yUH2NbH/GwcWG3sljkVSn3nqh6xogCwGaPFlw C84bcIj5gyhaZXcivVF0Z9LdMmhx8ldUwELe3nKb3T6sg1e8iKbLzGk+EgQVvKUWuSIK b1Ve9wlMN53A+fFJqwD9TaFz02Zp/aayF51sSwotTUNIAYJ7UyguRUmhKeRK1GQN7661 9lhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TkHWdDmgs+q/91rQHaC7OH2axrzghFStmICRpgH3ZCM=; b=t6RWMU5hEsfrE/vaIzblfrwuSH5HKceKey/fv6U6c8yueye+tDhFSw97EVu+EACUpb 07Vt+d3IsTr1U3uUQIqj+i6L5le6ELPyI5CmGmLve2cfht+/4tii+nFfOtf47K51jpYT V4pVeUj++H54PWs9sOh3iQVQcrlj34YaRV1qi8CA7ZrWeB5e7ElyxACcfzKOszKDCqK+ i4fWyn4X1uC7ptPuvN0JcqWHi0NINkFmje4hiETf7yKKlwsrIhHsPUGveA0Qh5Qwb6K7 Zhgq7cB48AuTTCY+xZ2R5noVnZtyjxYI+k+LGNmm5tgEiSBdMQdzKIFLX4yQkgp0PjoN hGFw== X-Gm-Message-State: ACrzQf0s/J3/F6JdxaAF1HHoW/1NBpsaKBOU19P2aIeRGzO5CWw20SCi o/sgkXK1DTJ3UQD5i7+DYsv+sA== X-Google-Smtp-Source: AMsMyM7pJtP4MGsOQTvuOs+Z0ikw+8XBFPVDGvOcbGKVGflEDcsZSA7VDIxG7Srh0G4MkHl7dG8zJA== X-Received: by 2002:a05:6870:8910:b0:131:2f31:dc1c with SMTP id i16-20020a056870891000b001312f31dc1cmr18305801oao.290.1667241167795; Mon, 31 Oct 2022 11:32:47 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:17c8:29c8:c66:a795:b2b1? ([2804:1b3:a7c0:17c8:29c8:c66:a795:b2b1]) by smtp.gmail.com with ESMTPSA id e66-20020a4a5545000000b004805e9e9f3dsm2661243oob.1.2022.10.31.11.32.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 11:32:47 -0700 (PDT) Message-ID: <7eb7deb7-4431-c32f-daa4-0f9f0d560dec@linaro.org> Date: Mon, 31 Oct 2022 15:32:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 01/11] stdlib/longlong.h: Remove incorrect lvalue to rvalue conversion from asm output constraints Content-Language: en-US To: Fangrui Song , Joseph Myers Cc: libc-alpha@sourceware.org References: <20221028173532.876027-1-adhemerval.zanella@linaro.org> <20221028173532.876027-2-adhemerval.zanella@linaro.org> <20221028213233.anuo3qzfssgjg4g6@google.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20221028213233.anuo3qzfssgjg4g6@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28/10/22 18:32, Fangrui Song wrote: > On 2022-10-28, Joseph Myers wrote: >> On Fri, 28 Oct 2022, Adhemerval Zanella via Libc-alpha wrote: >> >>> From: Fangrui Song >>> >>> An output constraint takes a lvalue. While GCC happily strips the >>> incorrect lvalue to rvalue conversion, Clang rejects the code by >>> default: >> >> We treat GCC as the upstream source of this file. > > I tried gcc-patches in 2021-10 > https://gcc.gnu.org/pipermail/gcc-patches/2021-October/581722.html > stdlib/longlong.h: Remove incorrect lvalue to rvalue conversion from asm output constraints > > If the GCC patch is not favored, the clang build will have to use -fheinous-gnu-extensions :( I recall this conversion, thanks for bring this up again. I don't have a strong preference, using -fheinous-gnu-extensions might be an option. It would require an additional configure check and add the flag on each file.