From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 53068385BF9E for ; Tue, 23 Mar 2021 16:13:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 53068385BF9E Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12NGB8e2140392; Tue, 23 Mar 2021 12:13:44 -0400 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com with ESMTP id 37fkax8qkv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Mar 2021 12:13:44 -0400 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 12NG37FR018161; Tue, 23 Mar 2021 16:13:41 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03fra.de.ibm.com with ESMTP id 37d9bpsu4t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Mar 2021 16:13:41 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 12NGDLKp33751512 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Mar 2021 16:13:21 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 89B0111C05E; Tue, 23 Mar 2021 16:13:39 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5E0AD11C04C; Tue, 23 Mar 2021 16:13:39 +0000 (GMT) Received: from li-ab9d22cc-354d-11b2-a85c-e984af76f811.ibm.com (unknown [9.171.12.175]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 23 Mar 2021 16:13:39 +0000 (GMT) Subject: Re: [PATCH] S390: Don't test nanoseconds in io/tst-stat.c To: Adhemerval Zanella , libc-alpha@sourceware.org, Joseph Myers References: <20210317130352.1782897-1-stli@linux.ibm.com> <1b859ba2-29bf-03f9-7b5d-db5b451857db@linaro.org> From: Stefan Liebler Message-ID: <7f30b64e-63f7-7f8d-17bb-134fc5ea102a@linux.ibm.com> Date: Tue, 23 Mar 2021 17:13:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: <1b859ba2-29bf-03f9-7b5d-db5b451857db@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-TM-AS-GCONF: 00 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-23_07:2021-03-22, 2021-03-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 priorityscore=1501 lowpriorityscore=0 mlxscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103230118 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 16:13:51 -0000 On 18/03/2021 14:31, Adhemerval Zanella wrote: > > > On 17/03/2021 10:03, Stefan Liebler wrote: >> Both new tests io/tst-stat and io/tst-stat-lfs (_FILE_OFFSET_BITS=64) >> are comparing the nanosecond fields with the statx result. Unfortunately >> on s390(31bit) those fields are always zero if old KABI with non-LFS >> support is used. With _FILE_OFFSET_BITS=64 stat is using statx internally. >> >> As suggested by Adhemerval this patch disables the nanosecond check for >> s390(31bit). > > LGTM, the fstatat call does not call statx and even for LFS that call statx > it might ended calling old stat syscall in the fallback part that does not > > About the __ASSUME_STATX note Joseph has raised, I think we should add it > on Linux at least for fstatat64 implementation. However it does not really > help on the fstatat one. I will try to spare some time to make fstatat.c > use statx as well, so we can tie the test to __ASSUME_STATX. > > Reviewed-by: Adhemerval Zanella > Hi Adhemerval, Sorry for the delay, I was busy with another project. Thanks for your series "[PATCH 1/5] linux: Implement fstatat with __fstatat64_time64" https://sourceware.org/pipermail/libc-alpha/2021-March/124191.html As also mentioned there, with your series, at least on my s390 systems, stat is then using statx and the nanosecond fields are not zero anymore. Shall I commit my patch as is and as soon as you've commited your series, you can adjust support_stat_nanoseconds to return false if __ASSUME_STATX is not defined? Thanks, Stefan