From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 1974B3858D28 for ; Tue, 1 Aug 2023 13:52:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1974B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3a1ebb85f99so4427664b6e.2 for ; Tue, 01 Aug 2023 06:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690897973; x=1691502773; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=tFO19AZpM+NZnfe2dN0iajk74wo+XxZ8V6oFr6ZE6JU=; b=GUrLvmPUW8c3xkaoBeyjOTnrf2ZLtdkSoksILf2tT+b7MWwJL29xqPOa7dIPK+l+1z UhX5QPxgwlC5zvHrV/r38iicw/uCSDwrHuM4UwTQ6fJQd7+2htiq89kgs1Px/mErGgHl PxgIO+mtuppSDSCwwoU9a98B7EAaTyhHZP3i4MpcboCUuBQkbOJhUVKPfTAqW7Ek4qkI a3p2lx+pvxBuWE4XuutSml2kx3qNwbJQUExkMGm995vjSJyGwgPlxxPTGehING8AgJhi dky8YDd2eKE6uqYPZH1cazzPV75J1aimvYIyz4RCPhyULd067BaWlzw/eFsC8g52hMmC k0FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690897973; x=1691502773; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tFO19AZpM+NZnfe2dN0iajk74wo+XxZ8V6oFr6ZE6JU=; b=K3Uw1Vv29yumof+wwW9rAEpwDl8XcXtwJSCTBF9MBdzqyLk5Ymylf3KMgRiZjJ38Xe K67fvFMnXHgM5Wcks43T8EP7zVC1DHDnWg2AlOeqxzeAmWLHbaqx3A96hLrfYD+JlXYQ xFxxEdwfu5epHCpKXTt+S3DsiRzkPWc2kz8oBVPmqVWjgQ3gftZb5n4BWybtcuSsKB7M 35j1hTESWevflBpKx9m+1IgYnZ+rdY0siIarAloPcvukaDux6FHXodIDOu/HcxHXfp2u DJ7l0+nAICr+3Y1ZSkzrzZ0uaG2p2ahodPEaXdQWssE0VsOkspCh6mwcI/va2z7094Qj L/3Q== X-Gm-Message-State: ABy/qLbsSANoasO09vyXthSCbtJ7DR1kdR8IjEGHvHIJR4qn3Yzb8mRL v6moMv+vqAWIcBw8lro0VrPpOw== X-Google-Smtp-Source: APBJJlHMvV1bG4e3Y7yXXUrh+rdp5tCt6g/RVIxz7x1Spc7ZFD+1VKlsR+4SbGad4+JdPtdyx0LdXA== X-Received: by 2002:a05:6808:1706:b0:3a1:e85f:33c3 with SMTP id bc6-20020a056808170600b003a1e85f33c3mr13557439oib.50.1690897973160; Tue, 01 Aug 2023 06:52:53 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:440b:a49a:e567:9a27:3db8? ([2804:1b3:a7c1:440b:a49a:e567:9a27:3db8]) by smtp.gmail.com with ESMTPSA id q26-20020a056808201a00b003a3b321712fsm2813143oiw.35.2023.08.01.06.52.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 06:52:52 -0700 (PDT) Message-ID: <7fa9bc64-771e-5b46-f29d-c77e427b8f10@linaro.org> Date: Tue, 1 Aug 2023 10:52:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] stdlib: Make abort AS-safe (BZ 26275) Content-Language: en-US To: Florian Weimer , Adhemerval Zanella via Libc-alpha Cc: Carlos O'Donell References: <20230731171900.4065501-1-adhemerval.zanella@linaro.org> <20230731171900.4065501-3-adhemerval.zanella@linaro.org> <87cz075gk2.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87cz075gk2.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01/08/23 05:10, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/sysdeps/generic/internal-signals.h b/sysdeps/generic/internal-signals.h >> index e2e9f9fd49..1c0f7b2e6c 100644 >> --- a/sysdeps/generic/internal-signals.h >> +++ b/sysdeps/generic/internal-signals.h >> @@ -42,7 +42,31 @@ clear_internal_signals (sigset_t *set) >> typedef sigset_t internal_sigset_t; >> >> #define internal_sigemptyset(__s) __sigemptyset (__s) >> +#define internal_sigfillset(__s) __sigfillset (__s) >> #define internal_sigaddset(__s, __i) __sigaddset (__s, __i) >> #define internal_sigprocmask(__h, __s, __o) __sigprocmask (__h, __s, __o) >> >> +static inline void >> +internal_signal_block_all (internal_sigset_t *oset) >> +{ >> + internal_sigset_t set; >> + internal_sigfillset (&set); >> + internal_sigprocmask (SIG_BLOCK, &set, oset); >> +} >> + >> +static inline void >> +internal_signal_restore_set (const internal_sigset_t *set) >> +{ >> + internal_sigprocmask (SIG_SETMASK, set, NULL); >> +} >> + >> +static inline void >> +internal_signal_unblock_signal (int sig) >> +{ >> + internal_sigset_t set; >> + internal_sigemptyset (&set); >> + internal_sigaddset (&set, sig); >> + internal_sigprocmask (SIG_UNBLOCK, &set, NULL); >> +} >> + >> #endif /* __INTERNAL_SIGNALS_H */ > > This should probably go into a separate patch. I recall writing a > similar patch, can't find it right now. These function are not really used and only required for Hurd for the abort change. I think it is more logical to add them when they are actually used instead of a separated patch.