From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eastern.birch.relay.mailchannels.net (eastern.birch.relay.mailchannels.net [23.83.209.55]) by sourceware.org (Postfix) with ESMTPS id E15753858C3A for ; Mon, 14 Aug 2023 19:53:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E15753858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id AE905760BA9; Mon, 14 Aug 2023 19:53:53 +0000 (UTC) Received: from pdx1-sub0-mail-a228.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 153A6760BEC; Mon, 14 Aug 2023 19:53:53 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1692042833; a=rsa-sha256; cv=none; b=Sp25mPbc+LHsjaZx8EIRgeSNH07ZhgYSI0HCtcYHKxjD9F13ht7qCery9Ibt2TABT1sajL O2uBezsxeApnoxivx0r0OhAFdYKQA8n1mPHG/PP2KErU4gzghtFwo311nilqpjGj17HKnT LYtCAzZWm3OWQmE0x8Ktc8GdGDFyGMkJ3dnjKYcsndBkDMd1R1M4Lr+Z4HHAZkjsfzDUOe tMwXNyJOLgOm/mDw/4DYzePdyDVUKUsJIvQi32W/8/KBg2K3a26F80MgrAbxfhST22j3hH pUYTIW3B7Jzl8u6n/wnU0G9V5xk4HVKTgt51Ow/Q2N8ZYrkJ42XFB0ofnBfOiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1692042833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p+2CXlweNVFShCRLZ3V9I7Jo9Lao0r8upWm9sMeQt5M=; b=3aaIMelBJMNbcUb8bu6k0nEtFhtH75UaZvre6RTBpNw/Z5l43ZZ19EzG7/PxfO4g5ISZ2g BlU4FTfFNIQ25X9C+0tVM8fCF1Jlq58Cns/brBfzWe2u8t6FYmb8zTYuyXOs8WsCvxkv/i RqlX18M8nIBHVVDmdcf63KzKgHxrZZFdLMK5tT3Wcw219WdUHbOhzFjbEKtHdA2qgaL7yW uzbnpNl9quVSyVKE4DBggWx3w7A3LzLT/MzUDP0PaGAANzVDfSItZ46n7rnJsS8sNQrJMG wQZgl7aIUQ4oZwnWocSnjdglMYNKNLxHNGn44St5EJbpHzXex4+lBBx5Af0ZoA== ARC-Authentication-Results: i=1; rspamd-749bd77c9c-gcdnc; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Share-Thoughtful: 2e67d2bd1c3d7a5d_1692042833536_1797496723 X-MC-Loop-Signature: 1692042833536:2639559039 X-MC-Ingress-Time: 1692042833536 Received: from pdx1-sub0-mail-a228.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.121.110.70 (trex/6.9.1); Mon, 14 Aug 2023 19:53:53 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-02-142-113-138-184.dsl.bell.ca [142.113.138.184]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a228.dreamhost.com (Postfix) with ESMTPSA id 4RPlTD557xz33; Mon, 14 Aug 2023 12:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1692042832; bh=p+2CXlweNVFShCRLZ3V9I7Jo9Lao0r8upWm9sMeQt5M=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=ixXmsd53tTlMq5PxD7ee9WLQQ/nTbVA/86AaNe3s6BN8YW4RkeapQd3Dfhqqb1sX7 zWn/PRQdjRsHxT5GB2mBcGDhJyQRUoeCc5Etxz78/nhQ7reIGfpWwhLsM/+oA8ZtBD 3FhbL3A5TW1g75o6ENZuJXRdm1cdbSic4TvVvcAm1MAt/r9LEp+nrhncFBUY7GEXuO +LH2yRCJvjMhyTjEFjPACdGS5uzaCO2pM4P4HuHhS9R5ktpePP1z/ZLRKJac0xtNB1 065Z5dqVJaqyGpReVNr3T5qdveZkbKPHPeSyqd5CWr7VmPzae0s1b+VWiQd9irsI/8 Mv+0J/UfTTGIw== Message-ID: <7fd38024-d285-0610-80cb-91baf3413425@gotplt.org> Date: Mon, 14 Aug 2023 15:53:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4] resolv/nss_dns/dns-host: Get rid of alloca. Content-Language: en-US To: Joe Simmons-Talbott , libc-alpha@sourceware.org References: <20230814145833.1679316-1-josimmon@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230814145833.1679316-1-josimmon@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3037.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-08-14 10:58, Joe Simmons-Talbott via Libc-alpha wrote: > Since the alloca is a small constant size use an array instead. > --- > Changes to v3: > * Move tmp back up one level of scope since it is used within the > enclosing scope as 'name'. > > resolv/nss_dns/dns-host.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Siddhesh Poyarekar > > diff --git a/resolv/nss_dns/dns-host.c b/resolv/nss_dns/dns-host.c > index 1d60c51f5e..c8b77bbc35 100644 > --- a/resolv/nss_dns/dns-host.c > +++ b/resolv/nss_dns/dns-host.c > @@ -378,6 +378,7 @@ _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat, > int *herrnop, int32_t *ttlp) > { > enum nss_status status = check_name (name, herrnop); > + char tmp[NS_MAXDNAME]; > if (status != NSS_STATUS_SUCCESS) > return status; > struct resolv_context *ctx = __resolv_context_get (); > @@ -395,8 +396,7 @@ _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat, > */ > if (strchr (name, '.') == NULL) > { > - char *tmp = alloca (NS_MAXDNAME); > - const char *cp = __res_context_hostalias (ctx, name, tmp, NS_MAXDNAME); > + const char *cp = __res_context_hostalias (ctx, name, tmp, sizeof (tmp)); > if (cp != NULL) > name = cp; > }