From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Cc: Stefan Liebler <stli@linux.ibm.com>,
Nick Clifton <nickc@redhat.com>,
Arjun Shankar <ashankar@redhat.com>
Subject: Re: [PATCH] s390: Use long branches across object boundaries (jgh instead of jh)
Date: Tue, 9 Nov 2021 14:06:31 -0500 [thread overview]
Message-ID: <800880a2-33bc-3007-dce4-1b839263c523@redhat.com> (raw)
In-Reply-To: <875yt19q0w.fsf@oldenburg.str.redhat.com>
On 11/9/21 12:50, Florian Weimer wrote:
> Depending on the layout chosen by the linker, the 16-bit displacement
> of the jh instruction is insufficient to reach the target label.
>
> Analysis of the linker failure was carried out by Nick Clifton.
>
> Tested on a z13 and z15, s390x-linux-gnu only.
Looks correct to me. Converting from BRC to BRCL doubles the available offset bits.
I tested assembling a few variants and they look good to me.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> sysdeps/s390/memmem-arch13.S | 2 +-
> sysdeps/s390/strstr-arch13.S | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sysdeps/s390/memmem-arch13.S b/sysdeps/s390/memmem-arch13.S
> index c5c8d8c97e..58df8cdb14 100644
> --- a/sysdeps/s390/memmem-arch13.S
> +++ b/sysdeps/s390/memmem-arch13.S
> @@ -41,7 +41,7 @@ ENTRY(MEMMEM_ARCH13)
> # error The arch13 variant of memmem needs the z13 variant of memmem!
> # endif
> clgfi %r5,9
> - jh MEMMEM_Z13
OK. jh is BRC (branch relative on condition, A7-M-4-RI) with a 16-bit offset.
> + jgh MEMMEM_Z13
OK. jgh is BRCL (branch relative on condition long, C0-M-4-RI) with a 32-bit offset.
>
> aghik %r0,%r5,-1 /* vll needs highest index. */
> bc 4,0(%r14) /* cc==1: return if needle-len == 0. */
> diff --git a/sysdeps/s390/strstr-arch13.S b/sysdeps/s390/strstr-arch13.S
> index c7183e627c..222a6de91a 100644
> --- a/sysdeps/s390/strstr-arch13.S
> +++ b/sysdeps/s390/strstr-arch13.S
> @@ -49,7 +49,7 @@ ENTRY(STRSTR_ARCH13)
> # error The arch13 variant of strstr needs the z13 variant of strstr!
> # endif
> clgfi %r4,9
> - jh STRSTR_Z13
> + jgh STRSTR_Z13
Likewise.
>
> /* In case of a partial match, the vstrs instruction returns the index
> of the partial match in a vector-register. Then we have to
>
--
Cheers,
Carlos.
next prev parent reply other threads:[~2021-11-09 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 17:50 Florian Weimer
2021-11-09 19:06 ` Carlos O'Donell [this message]
2021-11-10 13:57 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=800880a2-33bc-3007-dce4-1b839263c523@redhat.com \
--to=carlos@redhat.com \
--cc=ashankar@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=nickc@redhat.com \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).