public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] locale: Add transliteration for Geresh, Gershayim (U+05F3, U+05F4)
@ 2020-05-13  5:37 Florian Weimer
  2020-05-14 20:32 ` Carlos O'Donell
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2020-05-13  5:37 UTC (permalink / raw)
  To: libc-alpha

ISO-8859-8-based locales will need this transliteration if the locale
files contain these Unicode characters.

---
 locale/C-translit.h.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/locale/C-translit.h.in b/locale/C-translit.h.in
index 31cd86a5cf..a0c545b7d3 100644
--- a/locale/C-translit.h.in
+++ b/locale/C-translit.h.in
@@ -360,6 +360,8 @@
 "\x04f5"	"ch`"	# <U04F5> CYRILLIC SMALL LETTER CHE WITH DIAERESIS
 "\x04f8"	"Y`"	# <U04F8> CYRILLIC CAPITAL LETTER YERU WITH DIAERESIS
 "\x04f9"	"y`"	# <U04F9> CYRILLIC SMALL LETTER YERU WITH DIAERESIS
+"\x05f3"	"'"	# <U05F3> HEBREW PUNCTUATION GERESH
+"\x05f4"	"\""	# <U05F4> HEBREW PUNCTUATION GERSHAYIM
 "\x2002"	" "	# <U2002> EN SPACE
 "\x2003"	" "	# <U2003> EM SPACE
 "\x2004"	" "	# <U2004> THREE-PER-EM SPACE

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] locale: Add transliteration for Geresh, Gershayim (U+05F3, U+05F4)
  2020-05-13  5:37 [PATCH] locale: Add transliteration for Geresh, Gershayim (U+05F3, U+05F4) Florian Weimer
@ 2020-05-14 20:32 ` Carlos O'Donell
  0 siblings, 0 replies; 2+ messages in thread
From: Carlos O'Donell @ 2020-05-14 20:32 UTC (permalink / raw)
  To: Florian Weimer, libc-alpha

On 5/13/20 1:37 AM, Florian Weimer wrote:
> ISO-8859-8-based locales will need this transliteration if the locale
> files contain these Unicode characters.
> 

OK for master.

The two transliterations seem reasonable for the C locale.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---

OK. Good to see 3-dashes! :-)

>  locale/C-translit.h.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/locale/C-translit.h.in b/locale/C-translit.h.in
> index 31cd86a5cf..a0c545b7d3 100644
> --- a/locale/C-translit.h.in
> +++ b/locale/C-translit.h.in
> @@ -360,6 +360,8 @@
>  "\x04f5"	"ch`"	# <U04F5> CYRILLIC SMALL LETTER CHE WITH DIAERESIS
>  "\x04f8"	"Y`"	# <U04F8> CYRILLIC CAPITAL LETTER YERU WITH DIAERESIS
>  "\x04f9"	"y`"	# <U04F9> CYRILLIC SMALL LETTER YERU WITH DIAERESIS
> +"\x05f3"	"'"	# <U05F3> HEBREW PUNCTUATION GERESH

OK. Confirmed matches UTF-8 charmap.

> +"\x05f4"	"\""	# <U05F4> HEBREW PUNCTUATION GERSHAYIM

OK. Confirmed matches UTF-8 charmap. 

>  "\x2002"	" "	# <U2002> EN SPACE
>  "\x2003"	" "	# <U2003> EM SPACE
>  "\x2004"	" "	# <U2004> THREE-PER-EM SPACE
> 


-- 
Cheers,
Carlos.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-14 20:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13  5:37 [PATCH] locale: Add transliteration for Geresh, Gershayim (U+05F3, U+05F4) Florian Weimer
2020-05-14 20:32 ` Carlos O'Donell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).