From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by sourceware.org (Postfix) with ESMTPS id 696773858D28 for ; Wed, 29 Dec 2021 11:59:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 696773858D28 Received: by mail-qk1-x72a.google.com with SMTP id 69so19649707qkd.6 for ; Wed, 29 Dec 2021 03:59:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=hU+UJJvovjw+IV/s3JuYDdYIKLZAxmlcEvIPoh9MQdg=; b=DvP6DJQTh9zOuCuO1XG4FdiETTV8XsjLUClhyTZLu305JvobKNIvfGAvYw4RccenEa Z6mwL8Z2wk77udH2LXwwCsTNc8bQDVAGku5OxLqsy4Fy7m4kKOZ2YoPNjYhdwu2bZ3EM XqDozRH7s4IUfDN737WCrB3uoUdAWoLBolCIXTDcSyfMEKdfxrf8VnzEHhwOlE7bxuwk 8j13DzWO1KRMoFPsDNFRpT5EVdjJGcFhleMIp3NQgzpl0upZhaHlpGjf1WnSCeSbo6Qw m4BoxXHZPDKX4FoNKhk2X1uwGBJNCG9XEVhQb1A+teYAQ5HUn+KfY2h2Kot9UFnyHpcd vdFw== X-Gm-Message-State: AOAM530qD4uQVlGWMIsnaXQ7fhJL8L5O6l3YgdbgRcIt1TyeJ7UMGX7L hkSdVfhgePgZkq355PwzWwtboG/qDvPkgQ== X-Google-Smtp-Source: ABdhPJyC+3kRRI73nxOhIShFMViVofBS7FHRcHCmf+M9SRwdlrIVb4+YDEWOhdX+0RFjBQ4Z5q+IPQ== X-Received: by 2002:a05:620a:254a:: with SMTP id s10mr18296032qko.543.1640779192838; Wed, 29 Dec 2021 03:59:52 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a350:349e:1fa8:ba3d:5b36? ([2804:431:c7ca:a350:349e:1fa8:ba3d:5b36]) by smtp.gmail.com with ESMTPSA id o17sm17752046qkp.89.2021.12.29.03.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Dec 2021 03:59:52 -0800 (PST) Message-ID: <8021a5c8-1c46-49fc-6950-6612a4a7a618@linaro.org> Date: Wed, 29 Dec 2021 08:59:50 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2] Use LFS and 64 bit time for installed programs (BZ #15333) Content-Language: en-US To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210622172713.3504003-1-adhemerval.zanella@linaro.org> <87ilv8cvov.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87ilv8cvov.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Dec 2021 11:59:54 -0000 On 28/12/2021 17:37, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> The installed programs are built with a combination of different >> values for MODULE_NAME, as below. To enable both Long File Support >> and 64 bt time, -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64 is added for >> nonlibi, nscd, lddlibc4, libresolv, ldconfig, locale_programs, >> iconvprogs, libnss_files, libnss_compat, libnss_db, libnss_hesiod, >> libutil, libpcprofile, and libSegFault. > > -D_TIME_BITS=64 does not work for building glibc because the internal > aliases such as __fstat64 do not follow _TIME_BITS and are hard-wired to > 32-bit time. A symptom is a broken ldconfig, e.g.: > > $ elf/ldconfig -p > elf/ldconfig: mmap of cache file failed. > : Invalid argument I think the real problem is the usage of internal symbol in installed binaries, it works for LFS stat because they are either redirected to compat xstat ones or __stat (which I think it is also error prone). I am fixing it by using the default stat names, installed programs should not use proper LFS and time64.