From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 996C93853516 for ; Fri, 27 Oct 2023 12:52:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 996C93853516 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 996C93853516 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698411155; cv=none; b=IvuvZ1F3oVr3U16ZUmZZ8WX28yafYfK4AhS3Msc7WNMXU9M4hsXw+EA/BlM5GMqKTtgKp+j2b2XxTjjEm8C1gVdr51t+6S3D0sjoeEmhsWgyLYi5d4tQhYXBcrJI1SklUGsJN+8LLY/fqH7acrgBehLdMjOp8rA8bFlywypzca4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698411155; c=relaxed/simple; bh=D2Te7x9Ba+G9C9AJaXWP/GV8VU2hC4AgASxnE8ZIzZg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=MkdFsIKBU7QUPfyjzp4kHlqifiDbf7gON4BnScaiIABWhocRp9VzvHG1SZWCs+HwiMtuOlRaQhbo2K4mViLKr7i7PN2wM2o70bJUkVPF722/ZTW74CO5+rCaLt+ozJcxiJB/pDy37jTrsr8ywbUUULRw+HJ09MoOXXdsfdD/7Ck= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6b44befac59so2349916b3a.0 for ; Fri, 27 Oct 2023 05:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698411153; x=1699015953; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xqOR+rujEplkXvPK1pCZZ2+QLInJrniZRWTYHK8e/Jc=; b=gjU3jRvKLsKKTPm+pT8oJbTqQY/DkUFRMlTnUt4eXRGTf7Y54N2eryPshEv6jWumbl uNvkC3mtoNFACcvx+mTHQ6FjkJI9E0coul6XvCI/TUoBaszIkqWCJlUZo4xWkKGa5nTO okQOvBdL1vJfhjmPyhbp37XAUZYQ5SmAgxCZsqqjv+2eBHYWCA4AWXu2f9BPXSkbMgrL MXYvQX77Wmc12yVTuDJ7VtRlYg60tnWs7EPzc+FEFPBCZ6hlG1RLHW0vW10PM8wpnMyb 872x1SsigAcPSZLxx2leXhBZ/rsJBCtoiU6a3soji76rWM4mGYeu7ozgmM1HWEjRZAUL nyJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698411153; x=1699015953; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xqOR+rujEplkXvPK1pCZZ2+QLInJrniZRWTYHK8e/Jc=; b=BJhcLF4C3+smPXlHenkuyXyJkjCkyduf09TztiyCF6Vt6CuP5GEAPqntHh4WPyU2IX c9tZ0vYDHGE8rB9FtxKiaHB47Zp0K8bO+PueFAmnNC4aKW06pa8hXIntlkamJlS67H5H K9oY7G7HOuT10WpgHsV3PUYeRoRdCI7jSzFNgAydG3zjUhuBzfT295QqRnXrO4Ldlwag 0zkAYv1v0VxATMa9mvOTl817uYEUQLchW0SiGrHjGO7XEI3WPzMMXBuEmr5N48ZTKUQH ll4xgvamRqMw/Id+G0B5wY7oL0tc7OqG6EKTvasBwyusXVWpEXkpOFRGscer7Fncih4g FIyQ== X-Gm-Message-State: AOJu0Yy4XhFnmXEW8rs3fVH88CoZ81xtHfU94AHbi1KpHF3SRFmJD5iw VBScnsev/RpZC9DzS4W3ATU2vJ+5G9Pq7dE578m2FQ== X-Google-Smtp-Source: AGHT+IFGA+zz+UrKZcXJuybg4kOX1hqaUECRMnNQ8WVSjlx3YNY+HcvHkk7gWML8TTNitMUWVjWAHA== X-Received: by 2002:a05:6a20:7da1:b0:13f:13cb:bc50 with SMTP id v33-20020a056a207da100b0013f13cbbc50mr2928807pzj.25.1698411152749; Fri, 27 Oct 2023 05:52:32 -0700 (PDT) Received: from [192.168.15.31] (189-46-2-229.dsl.telesp.net.br. [189.46.2.229]) by smtp.gmail.com with ESMTPSA id g17-20020a056a0023d100b006c0316485f9sm1303125pfc.64.2023.10.27.05.52.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Oct 2023 05:52:32 -0700 (PDT) Message-ID: <802c682e-3366-430b-90c5-a316daea8256@linaro.org> Date: Fri, 27 Oct 2023 09:51:15 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/19] elf: Emit warning if tunable is ill-formatted Content-Language: en-US To: Siddhesh Poyarekar , libc-alpha@sourceware.org References: <20231017130526.2216827-1-adhemerval.zanella@linaro.org> <20231017130526.2216827-9-adhemerval.zanella@linaro.org> <46a29286-6716-45ed-8b32-eca495595246@sourceware.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <46a29286-6716-45ed-8b32-eca495595246@sourceware.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/10/23 07:28, Siddhesh Poyarekar wrote: > > > On 2023-10-17 09:05, Adhemerval Zanella wrote: >> So caller knows that the tunable will be ignored. >> >> Checked on x86_64-linux-gnu. >> --- >>   elf/dl-tunables.c | 6 +++++- >>   1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c >> index 5d4b8c5bc0..b39c14694c 100644 >> --- a/elf/dl-tunables.c >> +++ b/elf/dl-tunables.c >> @@ -236,7 +236,11 @@ parse_tunables (char *valstring) >>     struct tunable_toset_t tunables[tunables_list_size]; >>     int ntunables = parse_tunables_string (valstring, tunables); >>     if (ntunables == -1) >> -    return; >> +    { >> +      _dl_error_printf ( >> +        "ERROR: ld.so: invalid GLIBC_TUNABLES `%s': ignored.\n", valstring); > > If it's a warning, then we should say WARNING here. Ack. > >> +      return; >> +    } >>       for (int i = 0; i < ntunables; i++) >>       tunable_initialize (tunables[i].t, tunables[i].value);