From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81840 invoked by alias); 23 Jan 2019 17:41:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 81827 invoked by uid 89); 23 Jan 2019 17:41:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=thanking, our, you! X-HELO: mail-qt1-f170.google.com Return-Path: Subject: LTP highlights and thanks reviewers using Reviewed-by tags, so should we! References: <20190115145747.GB7842@rei.lan> To: GNU C Library From: Carlos O'Donell Openpgp: preference=signencrypt X-Forwarded-Message-Id: <20190115145747.GB7842@rei.lan> Message-ID: <8042e438-bc3b-e4d1-21a4-59cbd6553ac3@redhat.com> Date: Wed, 23 Jan 2019 17:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190115145747.GB7842@rei.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-01/txt/msg00584.txt.bz2 See here: https://www.sourceware.org/ml/libc-alpha/2019-01/msg00339.html ~~~ git log 20180926.. | grep -Ei '(reviewed|acked)-by:' | sed 's/.*by: //' | sort | uniq -c | sort -n -r 86 Cyril Hrubis 20 Petr Vorel 13 Li Wang 10 Jan Stancek 7 Alexey Kodanev 4 Xiao Yang 3 Richard Palethorpe 1 Steve Muckle 1 Richard Palethorpe 1 Jan Kara 1 Amir Goldstein ~~~ I just wanted to point out that I think the example below of highlighting and thanking reviewers is a really great example of how Reviewed-by: tags in commits helps the community as a whole and gives thanks to those that are doing the often thankless task of review :-) I encourage everyone to review patches, give your Reviewed-by: and to put the Reviewed-by: tags in your commits when you receive them. Eventually we'll get our workflow down to the point where this is easier not to forget. Thank you! -- Cheers, Carlos.