From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40437 invoked by alias); 11 May 2018 14:34:26 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 40068 invoked by uid 89); 11 May 2018 14:34:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=harmless, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Subject: Re: [PATCH] Use 64-bit time_t for time zone file parsing To: Paul Eggert , Andreas Schwab Cc: GNU C Library , Albert ARIBAUD References: <264af3e6-84ae-d1a4-c204-c00786b61dd9@redhat.com> From: Florian Weimer Message-ID: <80ab7f6b-ecbd-4eb7-acae-d1ce2a7c3e58@redhat.com> Date: Fri, 11 May 2018 14:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-05/txt/msg00499.txt.bz2 On 05/10/2018 04:04 AM, Paul Eggert wrote: > On 05/08/2018 07:29 AM, Florian Weimer wrote: >> Ah. I'm dropping the check of BYTE_ORDER. > > Thanks, this looks good to me. One minor suggestion. This line: > >       i = (transitions[num_transitions - 1] - timer) / 15778476; > > is now trickier than it used to be. Although the code still works since > it's just computing a guess, this new behavior might be worth a comment, > something along the lines "If size_t is 32 bits the assignment to I > could in theory overflow and wrap around, but this is harmless." Thanks, I added a comment and pushed thechange. Florian