From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 0AC9C3882057 for ; Fri, 30 Jun 2023 15:55:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AC9C3882057 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35UFr9ph016326; Fri, 30 Jun 2023 15:55:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Ko7Tc+cRfJsFZmurc2FnolRkgzahDqS1RHc/mJh1HKc=; b=cvTP6aCEdm5WPD8KwJFauSmFU3p1rKbYR0fmkAR9KnTuWM0M0/NFAQCbmsEyKGnyC0dM wquHYRv7WTHeHnh/kMxecU2qwrOTYmvdcXwaZTEFlGzwitPy2wCAyQPaI7WN1JRWkxmL PANDEc3HCiZSB/0DHUn15YH/ORVTUKDW3Lvg46kz8B6Bcxuyp2PBInrVeWi/WGThiYsh ksGdivUz1rFdPkw6rbwU0nHfQrOMDMS/0RDFCDxHKC6ugQivYUC1nrT4GzfseQjM8gnc t8m+RcsFnpBaFvqM/OW/nCLz34ns1mwJPL7evuOCu9xbag0ck/yH6JYIPr1yQx+Afwl1 Pg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rj22t814k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 15:55:38 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35UFtbQB022971; Fri, 30 Jun 2023 15:55:37 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rj22t814c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 15:55:37 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35UBxHdf027987; Fri, 30 Jun 2023 15:55:36 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([9.208.130.101]) by ppma03wdc.us.ibm.com (PPS) with ESMTPS id 3rdr460tac-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 15:55:36 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35UFtZgR983612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Jun 2023 15:55:35 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8CF875805F; Fri, 30 Jun 2023 15:55:35 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B44865805C; Fri, 30 Jun 2023 15:55:34 +0000 (GMT) Received: from [9.67.87.76] (unknown [9.67.87.76]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 30 Jun 2023 15:55:34 +0000 (GMT) Message-ID: <8108ba62-564d-e6f4-e590-5e2463265ea0@linux.ibm.com> Date: Fri, 30 Jun 2023 10:55:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 03/16] sysdeps: Ensure ieee128*_chk routines to be properly named To: Siddhesh Poyarekar , =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org, Rajalakshmi Srinivasaraghavan References: <20230628084246.778302-1-fberat@redhat.com> <20230628084246.778302-4-fberat@redhat.com> Content-Language: en-US From: Paul E Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: TSaRAbmvbTi348vNDr2zq7-3dYo8vpJD X-Proofpoint-GUID: Sd7UsrkjhlsnrBszvZ0SLW0jl2MDycpq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-30_08,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 suspectscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1011 malwarescore=0 mlxlogscore=784 bulkscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306300132 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/30/23 9:58 AM, Siddhesh Poyarekar wrote: > > > On 2023-06-28 04:42, Frédéric Bérat wrote: >> The *_chk routines naming doesn't match the name that would be generated >> using libc_hidden_ldbl_proto. Since the macro is needed for some of >> these *_chk functions for _FORTIFY_SOURCE to be enabled, that needed to >> be fixed. >> While at it, all the *_chk function get renamed appropriately for >> consistency, even if not strictly necessary. >> --- > > LGTM, but I'd like Raji to pitch in as well as ppc maintainer. This LGTM (on behalf of Raji). I am surprised this wasn't noticed sooner. Was it not noticed because there are no internal calls within libc to these functions? Reviewed-by: Paul E. Murphy