From: Richard Henderson <richard.henderson@linaro.org>
To: "H.J. Lu" <hjl.tools@gmail.com>, libc-alpha@sourceware.org
Cc: goldstein.w.n@gmail.com, skpgkp2@gmail.com
Subject: Re: [PATCH] x86-64: Don't use SSE resolvers for ISA level 3 or above
Date: Thu, 29 Feb 2024 10:55:04 -1000 [thread overview]
Message-ID: <8124c4fc-1838-40b3-bc2e-edf667248568@linaro.org> (raw)
In-Reply-To: <20240228175114.271103-1-hjl.tools@gmail.com>
On 2/28/24 07:51, H.J. Lu wrote:
> --- a/sysdeps/x86/cpu-features.c
> +++ b/sysdeps/x86/cpu-features.c
> @@ -18,6 +18,7 @@
>
> #include <dl-hwcap.h>
> #include <libc-pointer-arith.h>
> +#include <isa-level.h>
> #include <get-isa-level.h>
> #include <cacheinfo.h>
> #include <dl-cacheinfo.h>
> @@ -1195,7 +1196,9 @@ no_cpuid:
> TUNABLE_CALLBACK (set_x86_shstk));
> #endif
>
> +#if MINIMUM_X86_ISA_LEVEL < AVX_X86_ISA_LEVEL
> if (GLRO(dl_x86_cpu_features).xsave_state_size != 0)
> +#endif
> {
> if (CPU_FEATURE_USABLE_P (cpu_features, XSAVEC))
> {
Surely this can be written with IF and not IFDEF:
if (MINIMUM_X86_ISA_LEVEL >= AVX_X86_ISA_LEVEL
|| GLRO(dl_x86_cpu_features).xsave_state_size != 0)
r~
next prev parent reply other threads:[~2024-02-29 20:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 17:51 H.J. Lu
2024-02-28 17:57 ` Noah Goldstein
2024-02-29 20:55 ` Richard Henderson [this message]
2024-03-01 2:40 ` Sunil Pandey
2024-03-01 22:22 ` Richard Henderson
2024-03-02 0:18 ` Sunil Pandey
2024-03-02 0:38 ` [PATCH] x86-64: Simplify minimum ISA check ifdef conditional with if Sunil K Pandey
2024-03-03 21:46 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8124c4fc-1838-40b3-bc2e-edf667248568@linaro.org \
--to=richard.henderson@linaro.org \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=skpgkp2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).