From: Paul Eggert <eggert@cs.ucla.edu>
To: "Albert ARIBAUD (3ADEV)" <albert.aribaud@3adev.fr>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v5 2/2] Y2038: make __tz_convert compatible with 64-bit-time
Date: Tue, 19 Jun 2018 23:35:00 -0000 [thread overview]
Message-ID: <812b80eb-c0f6-43f6-4ec8-ad8672bbfd14@cs.ucla.edu> (raw)
In-Reply-To: <20180618191443.9926-3-albert.aribaud@3adev.fr>
On 06/18/2018 12:14 PM, Albert ARIBAUD (3ADEV) wrote:
> +#include <errno.h>
Why does time/ctime.h need this addition? I don't see where the rest of
the patch is using anything that errno.h defines. Similarly for
time/ctime_r.c, time/gmtime.c, time/localtime.c. I suspect this is a
leftover of the older version of this patch that had __set_errno
(EINVAL), and I suggest not including <errno.h> in these files.
> /* Figure out the correct timezone for TM and set `__tzname',
> - `__timezone', and `__daylight' accordingly. */
> + `__timezone', and `__daylight' accordingly.
> + NOTE: this takes a __time64_t value, so passing a time_t value is OK. */
> void
> -__tz_compute (time_t timer, struct tm *tm, int use_localtime)
> +__tz_compute (__time64_t timer, struct tm *tm, int use_localtime)
Why is that "NOTE:" comment line important or needed? The proposed set
of patches never pass a time_t value to __tz_compute. I suspect this
line is a leftover from an older version of the patch, and suggest
removing that line.
Otherwise, the patch looks OK to me.
next prev parent reply other threads:[~2018-06-19 23:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 19:14 [PATCH v5 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD (3ADEV)
2018-06-18 19:14 ` [PATCH v5 1/2] Y2038: Add 64-bit time for all architectures Albert ARIBAUD (3ADEV)
2018-06-19 23:25 ` Paul Eggert
2018-06-20 6:04 ` Albert ARIBAUD
2018-06-20 6:29 ` Albert ARIBAUD
2018-06-20 7:16 ` Albert ARIBAUD
2018-06-20 16:01 ` Paul Eggert
2018-06-20 16:46 ` Albert ARIBAUD
2018-06-20 17:50 ` Paul Eggert
2018-06-18 19:14 ` [PATCH v5 2/2] Y2038: make __tz_convert compatible with 64-bit-time Albert ARIBAUD (3ADEV)
2018-06-19 23:35 ` Paul Eggert [this message]
2018-06-20 6:06 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=812b80eb-c0f6-43f6-4ec8-ad8672bbfd14@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=albert.aribaud@3adev.fr \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).