public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v2 03/14] stdio-common: Simplify printf_unknown interface in vfprintf-internal.c
Date: Mon, 23 May 2022 16:07:14 +0200	[thread overview]
Message-ID: <81c01b70174a17c741e0d7a13126561af52d3175.1653314701.git.fweimer@redhat.com> (raw)
In-Reply-To: <cover.1653314701.git.fweimer@redhat.com>

The called function does not use the args array, so there is no need
to produce it.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
---
 stdio-common/vfprintf-internal.c | 21 +++------------------
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/stdio-common/vfprintf-internal.c b/stdio-common/vfprintf-internal.c
index f8aa2fdafb..fb94961f37 100644
--- a/stdio-common/vfprintf-internal.c
+++ b/stdio-common/vfprintf-internal.c
@@ -672,8 +672,7 @@ static int printf_positional (FILE *s,
 			      unsigned int mode_flags);
 
 /* Handle unknown format specifier.  */
-static int printf_unknown (FILE *, const struct printf_info *,
-			   const void *const *) __THROW;
+static int printf_unknown (FILE *, const struct printf_info *) __THROW;
 
 /* Group digits of number string.  */
 static CHAR_T *group_number (CHAR_T *, CHAR_T *, CHAR_T *, const char *,
@@ -1465,19 +1464,7 @@ printf_positional (FILE *s, const CHAR_T *format, int readonly_format,
 
 	  LABEL (form_unknown):
 	  {
-	    unsigned int i;
-	    const void **ptr;
-
-	    ptr = alloca (specs[nspecs_done].ndata_args
-			  * sizeof (const void *));
-
-	    /* Fill in an array of pointers to the argument values.  */
-	    for (i = 0; i < specs[nspecs_done].ndata_args; ++i)
-	      ptr[i] = &args_value[specs[nspecs_done].data_arg + i];
-
-	    /* Call the function.  */
-	    function_done = printf_unknown (s, &specs[nspecs_done].info,
-					    ptr);
+	    int function_done = printf_unknown (s, &specs[nspecs_done].info);
 
 	    /* If an error occurred we don't have information about #
 	       of chars.  */
@@ -1507,9 +1494,7 @@ printf_positional (FILE *s, const CHAR_T *format, int readonly_format,
 /* Handle an unknown format specifier.  This prints out a canonicalized
    representation of the format spec itself.  */
 static int
-printf_unknown (FILE *s, const struct printf_info *info,
-		const void *const *args)
-
+printf_unknown (FILE *s, const struct printf_info *info)
 {
   int done = 0;
   CHAR_T work_buffer[MAX (sizeof (info->width), sizeof (info->prec)) * 3];
-- 
2.35.3



  parent reply	other threads:[~2022-05-23 14:07 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-23 14:06 [PATCH v2 00/14] vfprintf rework to remove vtables Florian Weimer
2022-05-23 14:07 ` [PATCH v2 01/14] stdio-common: Add printf specifier registry to <printf.h> Florian Weimer
2022-05-23 14:37   ` Andreas Schwab
2022-05-23 14:07 ` [PATCH v2 02/14] stdio-common: Move union printf_arg int <printf.h> Florian Weimer
2022-05-23 14:07 ` Florian Weimer [this message]
2022-05-23 14:07 ` [PATCH v2 04/14] locale: Implement struct grouping_iterator Florian Weimer
2022-05-23 20:00   ` Adhemerval Zanella
2022-05-24 13:31   ` Andreas Schwab
2022-05-24 14:33     ` Florian Weimer
2022-05-23 14:07 ` [PATCH v2 05/14] stdio-common: Introduce buffers for implementing printf Florian Weimer
2022-06-02 17:16   ` Adhemerval Zanella
2022-06-02 17:58     ` Florian Weimer
2022-06-02 18:35       ` Adhemerval Zanella
2022-06-02 18:41         ` Florian Weimer
2022-06-02 18:55           ` Adhemerval Zanella
2022-06-02 19:12             ` Florian Weimer
2022-06-07 14:30       ` Florian Weimer
2022-06-07 16:55       ` Paul Eggert
2022-06-07 17:11         ` Florian Weimer
2022-06-07 17:41           ` Paul Eggert
2022-06-02 18:48   ` Adhemerval Zanella
2022-06-02 18:54     ` Florian Weimer
2022-06-07 16:57   ` Paul Eggert
2022-06-07 17:33     ` Florian Weimer
2022-05-23 14:07 ` [PATCH v2 06/14] stdio-common: Add __printf_function_invoke Florian Weimer
2022-06-03 13:51   ` Adhemerval Zanella
2022-05-23 14:07 ` [PATCH v2 07/14] stdio-common: Add __translated_number_width Florian Weimer
2022-05-23 14:07 ` [PATCH v2 08/14] stdio-common: Convert vfprintf and related functions to buffers Florian Weimer
2022-05-23 20:23   ` Joseph Myers
2022-05-23 20:48     ` Florian Weimer
2022-05-23 14:07 ` [PATCH v2 09/14] stdio-common: Add lock optimization to vfprintf and vfwprintf Florian Weimer
2022-05-23 14:07 ` [PATCH v2 10/14] libio: Convert __vsprintf_internal to buffers Florian Weimer
2022-05-23 14:07 ` [PATCH v2 11/14] libio: Convert __vasprintf_internal " Florian Weimer
2022-05-23 14:08 ` [PATCH v2 12/14] libio: Convert __vdprintf_internal " Florian Weimer
2022-05-23 14:08 ` [PATCH v2 13/14] libio: Convert __obstack_vprintf_internal to buffers (bug 27124) Florian Weimer
2022-05-23 14:08 ` [PATCH v2 14/14] libio: Convert __vswprintf_internal to buffers (bug 27857) Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81c01b70174a17c741e0d7a13126561af52d3175.1653314701.git.fweimer@redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).