From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74367-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 119271 invoked by alias); 3 Nov 2016 20:28:37 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 119244 invoked by uid 89); 3 Nov 2016 20:28:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:472, quarter
X-HELO: mail-ua0-f174.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:subject:to:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding;
        bh=TefdB5DhDIbgyw1R4C3tRo/9ExeWayxrwX0+9UFoPe4=;
        b=XpeQ3Jia5+stmob53xDinK1A8Lxy0nXEvo+spXUfRG6JdcDx/xkm41QKV9tUGKOFiu
         Hfl9V/ae9Tv0P4qElE4ozN38QaRMs/W8ThuxqjuFYFo+/8Ol7W01Bok4Fxc2AVaJN7CE
         s020xRq1DfarSQhMxv/x7TwZFaVjCc7v8AQiw7yvEDtqnR3vBMDL18oSaF1bTR9zUHLQ
         BIgDGVmi7mgDQPjYAQPgT2E1A85TCHebqh3OA7s9T9qvAOoXcYGFE4Q/PMMXAOEU43KX
         bKkFiIuEBNyEQnxj/4DmGhHoHz7Iq/kxfMsmdSlP9As4JkbA5NMdMu/X1dUFjS2euTTT
         0T9Q==
X-Gm-Message-State: ABUngvdDqxuV5ndH62KzCE0/ojMHZkeXIvh1ZCvRIq1h+LYTX9KakVmIINOqtFWpzcR+vdLn
X-Received: by 10.176.6.74 with SMTP id f68mr9035262uaf.37.1478204904596;
        Thu, 03 Nov 2016 13:28:24 -0700 (PDT)
Subject: Re: [PATCH] strftime: support %q to output the quarter of year
To: libc-alpha@sourceware.org
References: <1478202401-5238-1-git-send-email-P@draigBrady.com>
 <87mvhg9vzq.fsf@mid.deneb.enyo.de>
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Message-ID: <8285dd28-9fc7-efa1-b056-69a0cd3d0a6d@linaro.org>
Date: Thu, 03 Nov 2016 20:28:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <87mvhg9vzq.fsf@mid.deneb.enyo.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-SW-Source: 2016-11/txt/msg00120.txt.bz2



On 03/11/2016 17:58, Florian Weimer wrote:
> * Pádraig Brady:
> 
>> This is already supported by gnulib.
> 
> This needs a test case (at least a test case update).
> 
>> +        case L_('q'):           /* GNU extension.  */
>> +          DO_SIGNED_NUMBER (1, tp->tm_mon < -3, tp->tm_mon / 3 + 1U);
>> +          break;
> 
> I don't think we have DO_SIGNED_NUMBER in glibc.
> 

Indeed and you need to indicate how/where exactly you have tested
it.