From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 457E53858D20 for ; Tue, 30 May 2023 12:10:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 457E53858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685448635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nuF6zaYDC5EU6oHxFvTeYiY6Tx9PNhHXRCc6FT8k6zE=; b=RFXMd3d7l0LB3NShBbLnrrc02YUOXDgPPdc7V7ROxI4E7en2dRRSnnZKMI9Id7BglSx++k D2coMDUUiYpMeyGv/zyot9YvB4wyTPFmPKyiUlhQvJaiD3aC11FCA0yTlupd8EcQ2dgMnx M+gi+TH43zfOO51V6FcjJeduiikvS+s= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-72eiu0cmNM6vARoEXowZsQ-1; Tue, 30 May 2023 08:10:34 -0400 X-MC-Unique: 72eiu0cmNM6vARoEXowZsQ-1 Received: by mail-yb1-f200.google.com with SMTP id 3f1490d57ef6-babb52dbb00so10532680276.1 for ; Tue, 30 May 2023 05:10:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685448634; x=1688040634; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nuF6zaYDC5EU6oHxFvTeYiY6Tx9PNhHXRCc6FT8k6zE=; b=Ghk8gNatMW+mIPIy9AxoR4Te3eZzztrQobSrhBcJFZNY09X39+x5cz67HvjkWj0z86 UzafWTw8/SSBTnfLJBuTiOdCu0m+0nfsd01M5QlAs+J8xbzOpn3hRPDYrC1aqsnZeBaK kCpbvIm+/LJ1/hW9+ip9HOIWJu1gf80uSqv5DZ9d6LVmmymxW9JAfyW+dA2zKmDuqOdJ EkZhLr8D/XGaVFYVKQztp+HSr+e9YwmEmJSVospKlAJ8ZwwWXd228jWLawKsUGnxwG8h xvHD+F2w0O+lUYDuvy04RBJmCSilElBhBjhXfXWJ1G0pDooaB2NuTbiOSTLsqYNOh0dt da2g== X-Gm-Message-State: AC+VfDzgk6QOyZg8Luz/xqPYsyQL56mjv8L/neky17fcnYla6zNKenCC lutqt4FJwqjvgKPPBLpli3cvH5HMt+I59y/Z/djWfjnxYDzoZjbuJUiWokHV+KIOEQAMLVPlzvm lYbkOlqfqVfat8ujGM8jn X-Received: by 2002:a25:ad24:0:b0:ba8:5446:8d93 with SMTP id y36-20020a25ad24000000b00ba854468d93mr2412774ybi.12.1685448634285; Tue, 30 May 2023 05:10:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7SqEClOY4qWdEVEJw4e1ytHpqHbGbXZPlg7pS1ACwj6FYr1a0qv78+2klGxRhVjuXAGX8w4g== X-Received: by 2002:a25:ad24:0:b0:ba8:5446:8d93 with SMTP id y36-20020a25ad24000000b00ba854468d93mr2412762ybi.12.1685448634057; Tue, 30 May 2023 05:10:34 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id 7-20020a251907000000b00bac3b28257dsm3441326ybz.51.2023.05.30.05.10.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 05:10:33 -0700 (PDT) Message-ID: <829b1209-50aa-be3b-6659-44202c7999a0@redhat.com> Date: Tue, 30 May 2023 08:10:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/1] Add lint-makefiles Makefile linting test. To: Florian Weimer , Alejandro Colomar Cc: libc-alpha@sourceware.org, Noah Goldstein , Adhemerval Zanella References: <20230519121354.704395-1-carlos@redhat.com> <20230519121354.704395-2-carlos@redhat.com> <878rdkjxqw.fsf@oldenburg3.str.redhat.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <878rdkjxqw.fsf@oldenburg3.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/19/23 08:45, Florian Weimer wrote: > * Alejandro Colomar: > >> Hi Carlos, >> >> On 5/19/23 14:13, Carlos O'Donell via Libc-alpha wrote: >>> We add a `make check` test that lints all Makefiles in the source >>> directory of the glibc build. This linting test ensures that the >>> lines in all Makefiles will be sorted correctly as developers >>> creates patches. >> >> make check is usually to test the result of a build, according the >> GNU guidelines in: >> >> >> >> I believe linting the source code is a different thing, and so I >> used a different target in the Linux man-pages Makefile: 'lint'. >> >> So, in the man-pages project, it goes like this: >> >> lint -> build -> check -> install >> >> Maybe you could follow a similar scheme? Otherwise, it's a bit >> weird to run the linters _after_ building (since `make check` >> requires previously building). > > I think the consistency with the existing tests is more important. The > way Carlos implemented it, it becomes part of developer workflows > automatically. In the intervening time we've already regressed sorting in elf/Makefile, which to me indicates that this needs to be a light-weight linting check during 'make check.' I've reposted the light-weight linting with addtional comments: https://sourceware.org/pipermail/libc-alpha/2023-May/148634.html https://sourceware.org/pipermail/libc-alpha/2023-May/148635.html -- Cheers, Carlos.