* [PATCH] support: Add wrappers for pthread_barrierattr_t
@ 2018-05-29 13:15 Florian Weimer
2018-05-29 13:17 ` Adhemerval Zanella
2018-05-29 13:17 ` Carlos O'Donell
0 siblings, 2 replies; 3+ messages in thread
From: Florian Weimer @ 2018-05-29 13:15 UTC (permalink / raw)
To: libc-alpha
2018-05-29 Florian Weimer <fweimer@redhat.com>
* support/Makefile (libsupport-routines): Add
xpthread_barrierattr_destroy, xpthread_barrierattr_init,
xpthread_barrierattr_setpshared.
* support/xpthread_barrierattr_destroy.c: New file.
* support/xpthread_barrierattr_init.c: Likewise.
* support/xpthread_barrierattr_setpshared.c: Likewise.
diff --git a/support/Makefile b/support/Makefile
index bc2e5c69a2..652d2cdf69 100644
--- a/support/Makefile
+++ b/support/Makefile
@@ -98,6 +98,9 @@ libsupport-routines = \
xpthread_barrier_destroy \
xpthread_barrier_init \
xpthread_barrier_wait \
+ xpthread_barrierattr_destroy \
+ xpthread_barrierattr_init \
+ xpthread_barrierattr_setpshared \
xpthread_cancel \
xpthread_check_return \
xpthread_cond_wait \
diff --git a/support/xpthread_barrierattr_destroy.c b/support/xpthread_barrierattr_destroy.c
new file mode 100644
index 0000000000..3e471f9a81
--- /dev/null
+++ b/support/xpthread_barrierattr_destroy.c
@@ -0,0 +1,26 @@
+/* pthread_barrierattr_destroy with error checking.
+ Copyright (C) 2018 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <support/xthread.h>
+
+void
+xpthread_barrierattr_destroy (pthread_barrierattr_t *attr)
+{
+ xpthread_check_return ("pthread_barrierattr_destroy",
+ pthread_barrierattr_destroy (attr));
+}
diff --git a/support/xpthread_barrierattr_init.c b/support/xpthread_barrierattr_init.c
new file mode 100644
index 0000000000..4ee14e78f3
--- /dev/null
+++ b/support/xpthread_barrierattr_init.c
@@ -0,0 +1,26 @@
+/* pthread_barrierattr_init with error checking.
+ Copyright (C) 2018 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <support/xthread.h>
+
+void
+xpthread_barrierattr_init (pthread_barrierattr_t *attr)
+{
+ xpthread_check_return ("pthread_barrierattr_init",
+ pthread_barrierattr_init (attr));
+}
diff --git a/support/xpthread_barrierattr_setpshared.c b/support/xpthread_barrierattr_setpshared.c
new file mode 100644
index 0000000000..90b2c5bec6
--- /dev/null
+++ b/support/xpthread_barrierattr_setpshared.c
@@ -0,0 +1,26 @@
+/* pthread_barrierattr_setpshared with error checking.
+ Copyright (C) 2018 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <support/xthread.h>
+
+void
+xpthread_barrierattr_setpshared (pthread_barrierattr_t *attr, int pshared)
+{
+ xpthread_check_return ("pthread_barrierattr_setpshared",
+ pthread_barrierattr_setpshared (attr, pshared));
+}
diff --git a/support/xthread.h b/support/xthread.h
index 79358e7c99..623f5ad0ac 100644
--- a/support/xthread.h
+++ b/support/xthread.h
@@ -41,6 +41,9 @@ void xpthread_check_return (const char *function, int value);
void xpthread_barrier_init (pthread_barrier_t *barrier,
pthread_barrierattr_t *attr, unsigned int count);
void xpthread_barrier_destroy (pthread_barrier_t *barrier);
+void xpthread_barrierattr_destroy (pthread_barrierattr_t *);
+void xpthread_barrierattr_init (pthread_barrierattr_t *);
+void xpthread_barrierattr_setpshared (pthread_barrierattr_t *, int pshared);
void xpthread_mutexattr_destroy (pthread_mutexattr_t *);
void xpthread_mutexattr_init (pthread_mutexattr_t *);
void xpthread_mutexattr_setprotocol (pthread_mutexattr_t *, int);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] support: Add wrappers for pthread_barrierattr_t
2018-05-29 13:15 [PATCH] support: Add wrappers for pthread_barrierattr_t Florian Weimer
2018-05-29 13:17 ` Adhemerval Zanella
@ 2018-05-29 13:17 ` Carlos O'Donell
1 sibling, 0 replies; 3+ messages in thread
From: Carlos O'Donell @ 2018-05-29 13:17 UTC (permalink / raw)
To: Florian Weimer, libc-alpha
On 05/29/2018 09:15 AM, Florian Weimer wrote:
> 2018-05-29 Florian Weimer <fweimer@redhat.com>
>
> * support/Makefile (libsupport-routines): Add
> xpthread_barrierattr_destroy, xpthread_barrierattr_init,
> xpthread_barrierattr_setpshared.
> * support/xpthread_barrierattr_destroy.c: New file.
> * support/xpthread_barrierattr_init.c: Likewise.
> * support/xpthread_barrierattr_setpshared.c: Likewise.
My opinion is that there is consensus for all of this support in the
support/ directory, please feel free to commit this without review
e.g. drop [PATCH] and add (Committed) at the end like Joseph does.
Thank you for all of your hard work creating new and useful test cases.
> diff --git a/support/Makefile b/support/Makefile
> index bc2e5c69a2..652d2cdf69 100644
> --- a/support/Makefile
> +++ b/support/Makefile
> @@ -98,6 +98,9 @@ libsupport-routines = \
> xpthread_barrier_destroy \
> xpthread_barrier_init \
> xpthread_barrier_wait \
> + xpthread_barrierattr_destroy \
> + xpthread_barrierattr_init \
> + xpthread_barrierattr_setpshared \
> xpthread_cancel \
> xpthread_check_return \
> xpthread_cond_wait \
> diff --git a/support/xpthread_barrierattr_destroy.c b/support/xpthread_barrierattr_destroy.c
> new file mode 100644
> index 0000000000..3e471f9a81
> --- /dev/null
> +++ b/support/xpthread_barrierattr_destroy.c
> @@ -0,0 +1,26 @@
> +/* pthread_barrierattr_destroy with error checking.
> + Copyright (C) 2018 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <support/xthread.h>
> +
> +void
> +xpthread_barrierattr_destroy (pthread_barrierattr_t *attr)
> +{
> + xpthread_check_return ("pthread_barrierattr_destroy",
> + pthread_barrierattr_destroy (attr));
> +}
> diff --git a/support/xpthread_barrierattr_init.c b/support/xpthread_barrierattr_init.c
> new file mode 100644
> index 0000000000..4ee14e78f3
> --- /dev/null
> +++ b/support/xpthread_barrierattr_init.c
> @@ -0,0 +1,26 @@
> +/* pthread_barrierattr_init with error checking.
> + Copyright (C) 2018 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <support/xthread.h>
> +
> +void
> +xpthread_barrierattr_init (pthread_barrierattr_t *attr)
> +{
> + xpthread_check_return ("pthread_barrierattr_init",
> + pthread_barrierattr_init (attr));
> +}
> diff --git a/support/xpthread_barrierattr_setpshared.c b/support/xpthread_barrierattr_setpshared.c
> new file mode 100644
> index 0000000000..90b2c5bec6
> --- /dev/null
> +++ b/support/xpthread_barrierattr_setpshared.c
> @@ -0,0 +1,26 @@
> +/* pthread_barrierattr_setpshared with error checking.
> + Copyright (C) 2018 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <support/xthread.h>
> +
> +void
> +xpthread_barrierattr_setpshared (pthread_barrierattr_t *attr, int pshared)
> +{
> + xpthread_check_return ("pthread_barrierattr_setpshared",
> + pthread_barrierattr_setpshared (attr, pshared));
> +}
> diff --git a/support/xthread.h b/support/xthread.h
> index 79358e7c99..623f5ad0ac 100644
> --- a/support/xthread.h
> +++ b/support/xthread.h
> @@ -41,6 +41,9 @@ void xpthread_check_return (const char *function, int value);
> void xpthread_barrier_init (pthread_barrier_t *barrier,
> pthread_barrierattr_t *attr, unsigned int count);
> void xpthread_barrier_destroy (pthread_barrier_t *barrier);
> +void xpthread_barrierattr_destroy (pthread_barrierattr_t *);
> +void xpthread_barrierattr_init (pthread_barrierattr_t *);
> +void xpthread_barrierattr_setpshared (pthread_barrierattr_t *, int pshared);
> void xpthread_mutexattr_destroy (pthread_mutexattr_t *);
> void xpthread_mutexattr_init (pthread_mutexattr_t *);
> void xpthread_mutexattr_setprotocol (pthread_mutexattr_t *, int);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] support: Add wrappers for pthread_barrierattr_t
2018-05-29 13:15 [PATCH] support: Add wrappers for pthread_barrierattr_t Florian Weimer
@ 2018-05-29 13:17 ` Adhemerval Zanella
2018-05-29 13:17 ` Carlos O'Donell
1 sibling, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2018-05-29 13:17 UTC (permalink / raw)
To: libc-alpha
On 29/05/2018 10:15, Florian Weimer wrote:
> 2018-05-29 Florian Weimer <fweimer@redhat.com>
>
> * support/Makefile (libsupport-routines): Add
> xpthread_barrierattr_destroy, xpthread_barrierattr_init,
> xpthread_barrierattr_setpshared.
> * support/xpthread_barrierattr_destroy.c: New file.
> * support/xpthread_barrierattr_init.c: Likewise.
> * support/xpthread_barrierattr_setpshared.c: Likewise.
LGTM.
>
> diff --git a/support/Makefile b/support/Makefile
> index bc2e5c69a2..652d2cdf69 100644
> --- a/support/Makefile
> +++ b/support/Makefile
> @@ -98,6 +98,9 @@ libsupport-routines = \
> xpthread_barrier_destroy \
> xpthread_barrier_init \
> xpthread_barrier_wait \
> + xpthread_barrierattr_destroy \
> + xpthread_barrierattr_init \
> + xpthread_barrierattr_setpshared \
> xpthread_cancel \
> xpthread_check_return \
> xpthread_cond_wait \
> diff --git a/support/xpthread_barrierattr_destroy.c b/support/xpthread_barrierattr_destroy.c
> new file mode 100644
> index 0000000000..3e471f9a81
> --- /dev/null
> +++ b/support/xpthread_barrierattr_destroy.c
> @@ -0,0 +1,26 @@
> +/* pthread_barrierattr_destroy with error checking.
> + Copyright (C) 2018 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <support/xthread.h>
> +
> +void
> +xpthread_barrierattr_destroy (pthread_barrierattr_t *attr)
> +{
> + xpthread_check_return ("pthread_barrierattr_destroy",
> + pthread_barrierattr_destroy (attr));
> +}
> diff --git a/support/xpthread_barrierattr_init.c b/support/xpthread_barrierattr_init.c
> new file mode 100644
> index 0000000000..4ee14e78f3
> --- /dev/null
> +++ b/support/xpthread_barrierattr_init.c
> @@ -0,0 +1,26 @@
> +/* pthread_barrierattr_init with error checking.
> + Copyright (C) 2018 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <support/xthread.h>
> +
> +void
> +xpthread_barrierattr_init (pthread_barrierattr_t *attr)
> +{
> + xpthread_check_return ("pthread_barrierattr_init",
> + pthread_barrierattr_init (attr));
> +}
> diff --git a/support/xpthread_barrierattr_setpshared.c b/support/xpthread_barrierattr_setpshared.c
> new file mode 100644
> index 0000000000..90b2c5bec6
> --- /dev/null
> +++ b/support/xpthread_barrierattr_setpshared.c
> @@ -0,0 +1,26 @@
> +/* pthread_barrierattr_setpshared with error checking.
> + Copyright (C) 2018 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <support/xthread.h>
> +
> +void
> +xpthread_barrierattr_setpshared (pthread_barrierattr_t *attr, int pshared)
> +{
> + xpthread_check_return ("pthread_barrierattr_setpshared",
> + pthread_barrierattr_setpshared (attr, pshared));
> +}
> diff --git a/support/xthread.h b/support/xthread.h
> index 79358e7c99..623f5ad0ac 100644
> --- a/support/xthread.h
> +++ b/support/xthread.h
> @@ -41,6 +41,9 @@ void xpthread_check_return (const char *function, int value);
> void xpthread_barrier_init (pthread_barrier_t *barrier,
> pthread_barrierattr_t *attr, unsigned int count);
> void xpthread_barrier_destroy (pthread_barrier_t *barrier);
> +void xpthread_barrierattr_destroy (pthread_barrierattr_t *);
> +void xpthread_barrierattr_init (pthread_barrierattr_t *);
> +void xpthread_barrierattr_setpshared (pthread_barrierattr_t *, int pshared);
> void xpthread_mutexattr_destroy (pthread_mutexattr_t *);
> void xpthread_mutexattr_init (pthread_mutexattr_t *);
> void xpthread_mutexattr_setprotocol (pthread_mutexattr_t *, int);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-29 13:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-29 13:15 [PATCH] support: Add wrappers for pthread_barrierattr_t Florian Weimer
2018-05-29 13:17 ` Adhemerval Zanella
2018-05-29 13:17 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).