From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id EE4473954472 for ; Thu, 29 Apr 2021 11:57:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EE4473954472 Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-539-Y2ZDWW4MNYSMR-juGpJLsw-1; Thu, 29 Apr 2021 07:57:41 -0400 X-MC-Unique: Y2ZDWW4MNYSMR-juGpJLsw-1 Received: by mail-qt1-f200.google.com with SMTP id a15-20020a05622a02cfb02901b5e54ac2e5so23898148qtx.4 for ; Thu, 29 Apr 2021 04:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Dr8nb67/SuqsXxXVtR2joyA9arH/oYJX957M+lP/jJU=; b=iRfANc2Go2suTQ3zIkYoPJoZ3p3uEN7T0vj/fZhuzEw8IJRMf4INzCyMCZdsckuzjn Umbb8HdnXYx/unEL1nGTP1u2d56VbbOLxmwwrvdWKO9kwKQ8PxQinGXuuF3IhTxmmxgA 3wul35gSUhZf39MQsqpMeVnaplaD8rK75DyXWQgsvStqTnUuG5wFvY1i1abDGoWLquvB BEKPOqUHPg8XfVZ3gePmhvuhxAglhS1GJQnF/fIskY2cdjw3bbEGPNqrKJlfpNhkN63n am54jcUzPwpakQGBj8joCXJ6OsEJ+XWjmIGhrGyomzaDZbTwkZZQouoIwhSXIZsijRsh ojRw== X-Gm-Message-State: AOAM533PKfFsIzAoHORovUVRVVTAJut9V8bhJwTKnK32lxzXZFW9NQQn RnsNt8Y2sXhsTy8YxTc0Vr8O6qsP47S2Y/sLgPPA5mIJa4Qnr+QfDCZndmQ+K+l6RvWbiWRJ/W3 cMJc8pBFv5UOkwOlMcU98hWkqP0iI2Szl5OHAq4GsYrmMw7nL5SK0oCKJ0y7a4qeTMThz1w== X-Received: by 2002:ac8:109a:: with SMTP id a26mr30417797qtj.156.1619697461005; Thu, 29 Apr 2021 04:57:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0W6J1cWR5lhe8Dd3nTJiGaqud0H4ND+GdeiYLaxOJHumaWF8DIvXVXBuSu50dURYUoaO9lQ== X-Received: by 2002:ac8:109a:: with SMTP id a26mr30417778qtj.156.1619697460681; Thu, 29 Apr 2021 04:57:40 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id l16sm1979129qkg.91.2021.04.29.04.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 04:57:39 -0700 (PDT) Subject: Re: [PATCH v3] Add new C.UTF-8 locale (Bug 17318) To: Joseph Myers Cc: Florian Weimer , Carlos O'Donell via Libc-alpha References: <20210219032748.564216-1-carlos@redhat.com> <87v99xcxzm.fsf@oldenburg.str.redhat.com> From: Carlos O'Donell Organization: Red Hat Message-ID: <82ee63d5-f60d-46cd-328b-bd1a972720fa@redhat.com> Date: Thu, 29 Apr 2021 07:57:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2021 11:57:45 -0000 On 4/28/21 1:36 PM, Joseph Myers wrote: > On Wed, 28 Apr 2021, Carlos O'Donell via Libc-alpha wrote: > >>>> diff --git a/localedata/locales/i18n_ctype b/localedata/locales/i18n_ctype >>>> index c63e0790fc..c92bb95148 100644 >>>> --- a/localedata/locales/i18n_ctype >>>> +++ b/localedata/locales/i18n_ctype >>>> @@ -26,7 +26,7 @@ fax "" >>>> language "" >>>> territory "Earth" >>>> revision "13.0.0" >>>> -date "2020-06-25" >>>> +date "2021-02-17" >>>> category "i18n:2012";LC_CTYPE >>>> END LC_IDENTIFICATION >>> >>> Those date changes seem spurious. Is this no-op file regeneration >>> really needed? >> >> The protocol is: >> >> cd localedata/unicode-gen >> make install >> >> The spurious regeneration is not needed, but it's easier to run the >> above commands. It gives a date for the last generation for all files >> consistently. > > Is it required to have a date in the file at all? > > For anything that's generated during the glibc build and ends up > installed, we'd avoid having such dates to allow for reproducible builds. > As this is a maintainer generation of something checked in as a source > file, rather than regenerated from makefile dependencies in a normal glibc > build, that doesn't strictly apply, but I still think it would be a good > idea to avoid having dates or other such non-reproducible output in > maintainer-generated files as far as possible. There turns out to be a case where the dates are important. The LC_IDENTIFICATION for the locale, particularly the 'date' field. Now the entirety of LC_IDENTIFICATION is a GNU extension that is metadata about the locale itself and has no strongly documented meanings AFAIK. My plan is to use the Unicode release date as the consistent date. Every time we update Unicode to a new version we would see a date change, but subsequent regeneration would not see any changes. -- Cheers, Carlos.